NTP Fall 2019 wallpapers #6904

karenkliu · 2019-11-13T19:16:11Z

Description

Swap out all of our current wallpapers on the new tab with a fresh set of images. Purpose:

prevent the images from feeling stale
give other photographers/creators a chance to showcase their work
it's fun

Designs

Assets

compressed JPG and WEBP
image assets.zip

photo creds + links
attribution.pdf

Test plan

Images should match those shown in [redacted]
(ones in red should not be showing)

karenkliu · 2019-11-13T19:28:31Z

Maybe apply this .webp compression method in brave/brave-core#3735 as well

jhreis · 2019-11-19T19:53:10Z

I put all the data together in a JSON file. @karenkliu if you could review this data, just for a second pair of eyes that would be great.

Also, do we have a website for "Louis Kim"?

ntp-data.json.zip

center is required for mobile to center the image correctly on mobile.

karenkliu · 2019-11-19T20:18:47Z

@jhreis We're still waiting on a link from Louis Kim; he's been traveling and says he can get it to us "tonight". So I'll post that link here tomorrow.

I checked out the JSON file and noticed a couple things:

They all have center set at '0' except for xavier-balderas-cejudo.jpg, which set at 2560; is that a mistake?
I'd like to help determine what should be the portrait center for these images, how do I do that?
oliwier gesla.jpg is the only file name with a space in it; is that going to be a problem? My bad for overlooking that when I was exporting stuff.

Other than those things, the file name, credits, and links all seem fine.

jamesmudgett · 2019-11-19T21:07:26Z

// center points for mobile portrait:

A - 1280
B - 1630
C - 1277
D - 1975
E - 815
F - 1160
G - 988
H - 682
I - 0
J - 480
K - 1200
L - 780
M - N/A
N - 2185
O  - 1205
P - 1330

jhreis · 2019-11-20T01:10:00Z

I updated the above JSON file with the center points. Thanks @jamesmudgett and @karenkliu

The space in the file name does not impact iOS, if it is problematic for other platforms I can update JSON file.

I think the JSON file is only needed for mobile probably, and only is used in portrait mode.

karenkliu · 2019-11-21T02:30:28Z

@jhreis The attribution link for Louis Kim is louiskimphotography.com

deeppandya · 2019-11-24T10:21:31Z

@karenkliu link louiskimphotography.com doesn't work. can you check with the artist ?

karenkliu · 2019-11-25T17:32:27Z

Sure, I sent them a message. Will post when they get back to me.

karenkliu · 2019-11-26T16:41:21Z

@deeppandya Please go ahead and use that same link. Louis said:

There was a problem with domain mapping. I checked again with my hosting service and they did a manual intervention. Should be up in 24-48 hours.

fmarier · 2019-11-26T19:24:45Z

@karenkliu Do you still have a record of the URLs where you downloaded the images?

I'm asking because, in addition to the photographer's attribution link, we now also keep track of the image URL and the license: https://github.com/brave/brave-core/blob/master/components/brave_new_tab_ui/data/LICENSE

(This is now visible in brave://credits under "Background images".)

karenkliu · 2019-11-26T20:28:45Z

@fmarier Sure, here you go:
2019-11 photo attribution and license.pdf

fmarier · 2019-11-27T00:23:47Z

Thanks @karenkliu . In terms of the URLs in the LICENSE file (as opposed to the attribution link, which you've got covered already in your PDF), it's best to use the ones where we got the image from.

For this batch of images, here's what I was able to find:

karenkliu · 2019-11-27T20:36:11Z

@fmarier Ah okay, got it - I'll do that for next time. This is what I think is right:

1: https://unsplash.com/photos/uwbajDCODj4
2: https://unsplash.com/photos/mawU2PoJWfU
3: https://unsplash.com/photos/4knR_YzeUVc
4: https://unsplash.com/photos/C9jP5AlgcuQ
5: https://unsplash.com/photos/sfgH9dXcMRw
6: Contributor sent the hi-res version through email
7: Contributor sent the hi-res version through email
8: https://unsplash.com/photos/4xv3lqnanYc
9: Contributor sent the hi-res version through email
10: https://unsplash.com/photos/veMnvjmfoxw
11: Contributor sent the hi-res version through email
12: Contributor sent the hi-res version through email
13: Contributor sent the hi-res version through email
14: Contributor sent the hi-res version through email
15: https://unsplash.com/photos/kxIE049IZ1g

As you can see, the URLs in the license file are only available for Unsplash images. The images we selected from direct contributor submissions were not acquired through a link - the contributor supplied us with a high-resolution image to use directly through email. A lot of times the images shown on a photographer's site are not high enough resolution for us to use as a wallpaper because they don't want unauthorized use of their images, so we reached out to them directly to acquire those images. I don't think a URL in the license file would be applicable for those direct contributor submissions.

fmarier · 2019-11-27T23:16:43Z

A lot of times the images shown on a photographer's site are not high enough resolution for us to use as a wallpaper because they don't want unauthorized use of their images, so we reached out to them directly to acquire those images. I don't think a URL in the license file would be applicable for those direct contributor submissions.

Ah good point. I didn't realize they were emailing them to us directly.

I wonder what would be most useful to show in the LICENSE file then. Maybe the low-res image from the photographer's website/Instagram so that people can see where we sourced the images (understanding it may not the exact version that we put in Brave)? The nice thing about having a URL is that you can discover other photos from that photographer or comment on it, but I guess people already do that with the attribution link after finding the exact photo.

Anyways, the point of this is not to create more work for ourselves, just to keep track of where things are from. What would you think about this (for next time):

If we find a photo (low-res or high-res) on a website / Instagram, then we can link to it from the LICENSE file -- we basically just note the URL where we originally found it.
If we get emailed a photo directly (i.e. we didn't find it, it came to us), then we can list it as "sent by contributor through email".

karenkliu · 2019-12-05T19:28:03Z

@fmarier That sounds good to me! For this round I think "sent by contributor through email" would suffice

cezaraugusto · 2019-12-19T15:25:41Z

@fmarier do you think we should update some file/license file after this work lands? I should have a PR open soon with this update.

See brave/brave-browser#6904 (comment) Fix brave/brave-browser#6904

LaurenWags · 2020-03-19T20:43:52Z

Marking as QA/Blocked for now since brave/brave-core#4398 was reverted.

bsclifton · 2020-03-19T21:29:27Z

@LaurenWags it should be there actually- I did open a revert, but we fixed a different way 😄 Let me make a note there (my bad)

edit:
Comment left brave/brave-core#4398 (comment) 😄 Removing QA/Blocked label

kjozwiak · 2020-03-20T00:32:49Z

@bsclifton @rebron @cezaraugusto @karenkliu just double checking, these are the expected images correct?

rebron · 2020-03-20T00:42:06Z

* https://raw.githubusercontent.com/brave/brave-core/8c4bcfee376033fe8d5528f00657b3b603c16d8c/components/img/newtab/backgrounds/anders-jilden.webp

kjozwiak · 2020-03-20T01:21:39Z

Thanks @rebron 👍Missed it when copying/pasting the list I pasted into the uplift channel on Slack.

kjozwiak · 2020-03-27T18:52:50Z

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

Brave | 1.7.76 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)

Went through https://docs.google.com/document/d/1Le1F2G4m04ui-D3GbDkYttKY9q4Hjy-JCOEVujYTyxM/edit and ensured that all the correct images were appearing and ensured that the correct links were being used
ensured that the images that were removed weren't being displayed/cycled through
Will Christiansen credit links are not working as per Attribution for Will Christiansen background image(s) link is broken #8848

Verification passed on

Brave	1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Went through https://docs.google.com/document/d/1Le1F2G4m04ui-D3GbDkYttKY9q4Hjy-JCOEVujYTyxM/edit and ensured that all the correct images were appearing and ensured that the correct links were being used
ensured that the images that were removed weren't being displayed/cycled through
Will Christiansen credit links are not working as per Attribution for Will Christiansen background image(s) link is broken #8848

Verification passed on

Brave	1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Ubuntu 18.04 LTS

Went through https://docs.google.com/document/d/1Le1F2G4m04ui-D3GbDkYttKY9q4Hjy-JCOEVujYTyxM/edit and ensured that all the correct images were appearing and ensured that the correct links were being used
ensured that the images that were removed weren't being displayed/cycled through
Will Christiansen credit links are not working as per Attribution for Will Christiansen background image(s) link is broken #8848

kjozwiak · 2020-03-27T18:54:15Z

@rebron @SergeyZhukovsky @aekeus should these make their way into Android as well? If so, can you please add the OS/Android tag for this issue?

rebron · 2020-03-27T19:07:46Z

NTP wallpapers are already updated on Android, so no additional work for android here.

karenkliu added the feature/new-tab label Nov 13, 2019

karenkliu assigned rebron Nov 13, 2019

rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 20, 2019

rebron assigned cezaraugusto and unassigned rebron Dec 3, 2019

rebron unassigned cezaraugusto Dec 17, 2019

rebron assigned cezaraugusto Dec 18, 2019

bsclifton pushed a commit to brave/brave-core that referenced this issue Mar 5, 2020

NTP: Update images mentioned as having been over-compressed.

c2f1502

See brave/brave-browser#6904 (comment) Fix brave/brave-browser#6904

bsclifton added this to the 1.7.x - Nightly milestone Mar 5, 2020

bsclifton added release-notes/include QA/Yes QA/Test-Plan-Specified labels Mar 5, 2020

cezaraugusto closed this as completed in brave/brave-core#4398 Mar 5, 2020

LaurenWags added the QA/Blocked label Mar 19, 2020

bsclifton removed the QA/Blocked label Mar 19, 2020

kjozwiak added the QA Pass-macOS label Mar 27, 2020

kjozwiak mentioned this issue Mar 27, 2020

Attribution for Will Christiansen background image(s) link is broken #8848

Closed

GeetaSarvadnya added the QA Pass-Win64 label Mar 30, 2020

btlechowski added the QA Pass-Linux label Mar 30, 2020

kjozwiak mentioned this issue Apr 9, 2020

Release Notes for 1.7.x (Release Channel) #9109

Closed

rebron mentioned this issue Apr 29, 2020

Dashboard page elements need more contrast #3051

Closed

rebron mentioned this issue Oct 5, 2021

NTP Fall 2021 wallpapers #18568

Closed

4 tasks

rebron mentioned this issue Apr 4, 2023

NTP Spring 2023 background images #29505

Closed

rebron mentioned this issue Jan 26, 2024

NTP Spring 2024 background images #35598

Closed

rebron mentioned this issue Oct 23, 2024

NTP Fall 2024 background images #41847

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NTP Fall 2019 wallpapers #6904

NTP Fall 2019 wallpapers #6904

karenkliu commented Nov 13, 2019 •

edited by w0ts0n

Loading

karenkliu commented Nov 13, 2019

jhreis commented Nov 19, 2019 •

edited

Loading

karenkliu commented Nov 19, 2019 •

edited

Loading

jamesmudgett commented Nov 19, 2019 •

edited

Loading

jhreis commented Nov 20, 2019 •

edited

Loading

karenkliu commented Nov 21, 2019

deeppandya commented Nov 24, 2019

karenkliu commented Nov 25, 2019

karenkliu commented Nov 26, 2019

fmarier commented Nov 26, 2019

karenkliu commented Nov 26, 2019

fmarier commented Nov 27, 2019

karenkliu commented Nov 27, 2019

fmarier commented Nov 27, 2019

karenkliu commented Dec 5, 2019

cezaraugusto commented Dec 19, 2019

LaurenWags commented Mar 19, 2020

bsclifton commented Mar 19, 2020 •

edited

Loading

kjozwiak commented Mar 20, 2020 •

edited

Loading

rebron commented Mar 20, 2020 •

edited

Loading

kjozwiak commented Mar 20, 2020

kjozwiak commented Mar 27, 2020 •

edited by btlechowski

Loading

kjozwiak commented Mar 27, 2020

rebron commented Mar 27, 2020

NTP Fall 2019 wallpapers #6904

NTP Fall 2019 wallpapers #6904

Comments

karenkliu commented Nov 13, 2019 • edited by w0ts0n Loading

Description

Designs

Assets

Test plan

karenkliu commented Nov 13, 2019

jhreis commented Nov 19, 2019 • edited Loading

karenkliu commented Nov 19, 2019 • edited Loading

jamesmudgett commented Nov 19, 2019 • edited Loading

jhreis commented Nov 20, 2019 • edited Loading

karenkliu commented Nov 21, 2019

deeppandya commented Nov 24, 2019

karenkliu commented Nov 25, 2019

karenkliu commented Nov 26, 2019

fmarier commented Nov 26, 2019

karenkliu commented Nov 26, 2019

fmarier commented Nov 27, 2019

karenkliu commented Nov 27, 2019

fmarier commented Nov 27, 2019

karenkliu commented Dec 5, 2019

cezaraugusto commented Dec 19, 2019

LaurenWags commented Mar 19, 2020

bsclifton commented Mar 19, 2020 • edited Loading

kjozwiak commented Mar 20, 2020 • edited Loading

rebron commented Mar 20, 2020 • edited Loading

kjozwiak commented Mar 20, 2020

kjozwiak commented Mar 27, 2020 • edited by btlechowski Loading

kjozwiak commented Mar 27, 2020

rebron commented Mar 27, 2020

karenkliu commented Nov 13, 2019 •

edited by w0ts0n

Loading

jhreis commented Nov 19, 2019 •

edited

Loading

karenkliu commented Nov 19, 2019 •

edited

Loading

jamesmudgett commented Nov 19, 2019 •

edited

Loading

jhreis commented Nov 20, 2019 •

edited

Loading

bsclifton commented Mar 19, 2020 •

edited

Loading

kjozwiak commented Mar 20, 2020 •

edited

Loading

rebron commented Mar 20, 2020 •

edited

Loading

kjozwiak commented Mar 27, 2020 •

edited by btlechowski

Loading