Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NTP wallpapers (Fall 2019) #4264

Merged
merged 2 commits into from
Jan 2, 2020
Merged

Update NTP wallpapers (Fall 2019) #4264

merged 2 commits into from
Jan 2, 2020

Conversation

cezaraugusto
Copy link
Contributor

Close brave/brave-browser#6904

Submitter Checklist:

Test Plan:

  • New tab page images should be updated.
  • Author attribution should match PDF file located in the referenced issue.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for two entries which are missing links.

components/brave_new_tab_ui/data/LICENSE Outdated Show resolved Hide resolved
components/brave_new_tab_ui/data/LICENSE Outdated Show resolved Hide resolved
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cezaraugusto Do you know which settings you used to compress these images? The file sizes are often a lot lower than the files that they are replacing. They don't seem to be to be as crisp and I can notice a few artifacts, but will double check on different screens and resolutions if the quality of these has been seen by design team yet.

@bsclifton
Copy link
Member

@fmarier ready for re-review 😄

@bsclifton
Copy link
Member

@cezaraugusto even though we merged, would you be able to answer questions by @petemill?

I checked myself on Nightly and the images are not horrible, but there are some quality issues (compression artifacts, pixelation)

cezaraugusto added a commit that referenced this pull request Jan 8, 2020
Follow-up of brave/brave-browser#6904

Some people noticed a decrease in quality in our last update
#4264. This PR uses the same
image bundle, but this time without further image compression.
Note that these files are the original files sent by design.
bsclifton added a commit that referenced this pull request Jan 10, 2020
Unfixes brave/brave-browser#6904

-----

Revert "Merge pull request #4264 from brave/ca-6904"

This reverts commit 9d81779, reversing
changes made to 0266020.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NTP Fall 2019 wallpapers
4 participants