-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NTP wallpapers (Fall 2019) #4264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for two entries which are missing links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cezaraugusto Do you know which settings you used to compress these images? The file sizes are often a lot lower than the files that they are replacing. They don't seem to be to be as crisp and I can notice a few artifacts, but will double check on different screens and resolutions if the quality of these has been seen by design team yet.
@fmarier ready for re-review 😄 |
@cezaraugusto even though we merged, would you be able to answer questions by @petemill? I checked myself on Nightly and the images are not horrible, but there are some quality issues (compression artifacts, pixelation) |
Follow-up of brave/brave-browser#6904 Some people noticed a decrease in quality in our last update #4264. This PR uses the same image bundle, but this time without further image compression. Note that these files are the original files sent by design.
Unfixes brave/brave-browser#6904 ----- Revert "Merge pull request #4264 from brave/ca-6904" This reverts commit 9d81779, reversing changes made to 0266020.
Close brave/brave-browser#6904
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.