NTP: Update images mentioned as having been over-compressed #4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
requested review from
fmarier,
petemill,
bsclifton and
NejcZdovc
cezaraugusto
changed the title
fmarier
requested changes
Jan 21, 2020
cezaraugusto
force-pushed
the
ca-6904-3
branch
from
dbb3658 to
dba34dc
Compare
cezaraugusto
force-pushed
the
ca-6904-3
branch
3 times, most recently
from
f6d772b to
2aea120
Compare
32 tasks
fmarier
added a commit
to brave/brave-browser
that referenced
this pull request
Mar 6, 2020
This reverts commit 350ea99. Since we a PR (brave/brave-core#4398) has been accidentaly merged with incorrect licensing info, breaking all release builds, it makes sense to ensure that these kinds of errors are detected early, during development, instead of during CI.
29 tasks
|
This introduced a problem with licensing; CI wasn't checked before merge. It's holding up Nightly. Will need to revert |
|
NOTE: Revert I mentioned was abandoned; this WAS properly fixed with #4864 😄 When build problem happened, it was an older version ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#6904
Fix brave/brave-browser#7997
This PR includes new images provided in brave/brave-browser#6904 (comment) without any extra change. Please reach out to the design team if there are concerns about image compression/quality. This PR also reverts #4357, making #4264 available again.