Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ben Karpinski's photo attribution link from Fall 2019 wallpapers #7997

Closed
karenkliu opened this issue Jan 31, 2020 · 4 comments · Fixed by brave/brave-core#4398 or brave/brave-core#5045

Comments

@karenkliu
Copy link

karenkliu commented Jan 31, 2020

Description:

Currently, Ben Karpinski's photo attribution link is set as www.benkarpinski.com/landscapes. He has requested that we update it to http://bklandscapes.com/. His image is included in the Fall 2019 batch of new wallpapers.

Screen Shot 2020-01-31 at 11 34 54 AM

Test plan

  1. Load picture (thumbnail shown above)
  2. Make sure image is attributed properly to Ben Karpinski
@LaurenWags
Copy link
Member

Marking as QA/Blocked for now since brave/brave-core#4398 was reverted.

@bsclifton
Copy link
Member

@LaurenWags it should be there actually- I did open a revert, but we fixed a different way 😄 Let me make a note there (my bad)

Comment left brave/brave-core#4398 (comment) 😄 Removing QA/Blocked label

@LaurenWags
Copy link
Member

LaurenWags commented Mar 24, 2020

Verified using

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Issue from description still reproduces. When Ben Karpinski's image is shown, his image is still attributed to https://benkarpinski.com/landscapes/ not http://bklandscapes.com/ as mentioned in the description.

Screen Shot 2020-03-24 at 10 07 33 AM

Logged follow up issue #8831

@bsclifton
Copy link
Member

removing QA/Yes and milestone as #8831 is a duplicate of this issue

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment