reduce background image size on NTP #3735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
added
CI/skip-android
cezaraugusto
requested review from
AndriusA,
petemill,
bsclifton and
bradleyrichter
|
Removing ci/skip-windows so we can test builds on low power device |
|
@cezaraugusto could you explain which method you used to reduce the size of the webp files? |
|
Usually when decreasing size, there's going to be a load or processing hit to make up for the difference (ex: decompressing). Especially as the JPG is already compressed Would leave it up to reviewers if this new approach is good 😄 |
|
I think we can close this in favor of #4264 |
|
@petemill SGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cut down all NTP background image size by ~60%.
Image quality doesn't seem to be reduced. Tagging @bradleyrichter to double-check.
@AndriusA mentioned that in devices with lower screen resolution our NTP felt sluggish. This PR aims to improve that.
Added CI skip to all platforms but macOS since it's likely that reviewers are using it and these labels speed up builds considerably.
Below a comparison table regarding image size reduction.