Attribution for Will Christiansen background image(s) link is broken

[mbacchi]

Test plan

1. Refresh NTP until photo is The photo Glacier Peak
2. Click website link in attribution
3. It should work

Description

The photo Glacier Peak came up and I clicked on the attribution but it brought me to chrome://newtab/www.theskyfolk.com instead of the correct URL.

It looks like the background.ts link field needs to include https:// at the beginning of the link address, else it will prepend chrome://newtab to the beginning, sending users to the wrong location.

Image 14 also would require the complete link, in addition to image 13.

[kjozwiak]

Both of the images from Will Christiansen are missing links as @mbacchi mentioned. These are the ones that don't have links when clicking on the credit link:

• https://raw.githubusercontent.com/brave/brave-core/8c4bcfee376033fe8d5528f00657b3b603c16d8c/components/img/newtab/backgrounds/will-christiansen-glacier-peak.webp
• https://raw.githubusercontent.com/brave/brave-core/8c4bcfee376033fe8d5528f00657b3b603c16d8c/components/img/newtab/backgrounds/will-christiansen-ice.webp

[mbacchi]

@kjozwiak I opened a PR (5068) to fix this but the test-install steps failed on mac/windows. I'm going to restart the pr builder and see if it works today.

[kjozwiak]

Awesome, thanks @mbacchi 👍 Ran into this when I started running through #6904 and noticed you created the issue. Thanks for finding/spotting it!

@rebron @bsclifton should we get this uplifted into 1.7.x as the new images will be on Release in ~a week or so as per #6904?

[bsclifton]

Sure- that's a small enough one. Let me check out the PR real quick 👍

[LaurenWags]

Verified passed with

Brave	1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from description

• Also verified for this image from Will Christiansen

Verification passed on

Brave	1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from description
  
  

Verification passed on

Brave	1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Ubuntu 18.04 LTS

• Verified test plan from description