Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the link to prevent loading in newtab (uplift to 1.7.x) #5088

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Fix the link to prevent loading in newtab (uplift to 1.7.x) #5088

merged 1 commit into from
Mar 27, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Mar 27, 2020 •
edited by kjozwiak
Loading

Uplift of #5068
Fixes brave/brave-browser#8848

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Mar 27, 2020
@brave-builds brave-builds added this to the 1.7.x - Beta milestone Mar 27, 2020
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv March 27, 2020 20:46
@bsclifton bsclifton added the CI/skip Do not run CI builds (except noplatform) label Mar 27, 2020
kjozwiak
kjozwiak approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. Please make sure that the correct milestone is being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 02c0e32 into 1.7.x Mar 27, 2020
@kjozwiak kjozwiak deleted the pr5068_issues/8848_1.7.x branch March 27, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Milestone
1.7.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @bsclifton @brave-browser-releases