Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the link to prevent loading in newtab #5068

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Fix the link to prevent loading in newtab #5068

merged 1 commit into from
Mar 27, 2020

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Mar 26, 2020

Fixes: brave/brave-browser#8848

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 27a8597 into master Mar 27, 2020
@bsclifton bsclifton deleted the issues/8848 branch March 27, 2020 20:43
@bsclifton bsclifton added this to the 1.8.x - Nightly milestone Mar 27, 2020
brave-builds pushed a commit that referenced this pull request Mar 27, 2020
@mbacchi mbacchi added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux and removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribution for Will Christiansen background image(s) link is broken
2 participants