Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard page elements need more contrast #3051

Closed
cndouglas opened this issue Jan 22, 2019 · 1 comment
Closed

Dashboard page elements need more contrast #3051

cndouglas opened this issue Jan 22, 2019 · 1 comment
Labels
accessibility closed/no-milestone priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion

Comments

@cndouglas
Copy link
Contributor

Description

The text and buttons on the dashboard sometimes are hard to see. In particular, the white buttons at the bottom right blend in with light colored backgrounds.

I recommend that a dark shadow be added around the text/buttons to provide sufficient contrast for both light and dark backgrounds.

Steps to Reproduce

For Brave 0.60.16 dev.

  1. Open a new tab.
  2. Refresh the page until you get a light background, like the "beach" background.
  3. Try to read all the text and buttons.

Actual result:

The "Estimated Time Saved" text and Bookmarks button are hard to see:

Expected result:

All the text and buttons should be visible.

Reproduces how often:

Sometimes, with certain backgrounds.

Brave version (brave://version info)

Brave | 0.60.16 Chromium: 72.0.3626.64 (Official Build) dev(64-bit)
Revision | eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS | Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes, 0.60.16 dev.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? Not applicable.
  • Is the issue reproducible on the latest version of Chrome? Not applicable.

Additional Information

@rebron rebron added this to the 1.x Backlog milestone Jan 23, 2019
@rebron rebron added suggestion priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Feb 6, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@rebron
Copy link
Collaborator

rebron commented Apr 29, 2020

Closing. Fixed with #6904 to account for contrast and readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility closed/no-milestone priority/P5 Not scheduled. Don't anticipate work on this any time soon. suggestion
Projects
None yet
Development

No branches or pull requests

3 participants