Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP Spring 2023 background images #29505

Closed
rebron opened this issue Apr 4, 2023 · 7 comments
Closed

NTP Spring 2023 background images #29505

rebron opened this issue Apr 4, 2023 · 7 comments
Assignees
Labels
feature/new-tab OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Apr 4, 2023

Description

Swap out all of our current wallpapers on the new tab with a fresh set of images.

Design (to add):

Assets:

Miscellaneous Information:

Related/prior issues:
#6904
#18568

@rebron rebron added OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 4, 2023
@rebron rebron added feature/new-tab priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include labels Apr 4, 2023
@aguscruiz
Copy link

@aguscruiz
Copy link

@petemill
Copy link
Member

Do we have the original version of these images? Usually we compress them with with https://squoosh.app/ (or similar) to make sure there's no pixelation at high-ish resolution, usually to webp because that's the smallest file size for that quality. I'm happy to do that conversion unless we're completely happy with these? They mostly seem fine, but I'm seeing a bit of pixelation on a 4k 21" display on a few of the images that have the sea, and especially on the sun in the image with the hand. If anything we can at least maintain existing quality and reduce size with .webp - I say that because this is a few more images than we have now. Right now our images total 6.7mb and this new set totals 9.5mb. 50% addition - perhaps not the end of the world, but we have to consider mobile connections (especially android), so we should do all we can without sacrificing quality.

Which image do you want to be the default one bundled with the browser, to be shown before the pack is downloaded? At the moment it's https://github.com/brave/brave-core/blob/master/components/img/newtab/backgrounds/dylan-malval_sea-min.webp

@aguscruiz
Copy link

aguscruiz commented Apr 26, 2023

Yeah sure, I have the originals here:

https://drive.google.com/drive/folders/1P1_bG5K_pNcfhlD-g4Bm0zXJjOsYB8mp?usp=sharing

As for the ones that look bad, we can probably take them out, the one with the hand is kinda problematic, so we could remove it if it's gonna look bad.

Let's see after your compression if the size get better, hopefully!

@rebron
Copy link
Collaborator Author

rebron commented Apr 27, 2023

Let's use this one https://drive.google.com/drive/u/1/folders/1aWhOBJoT5zAAsWzRM7Qg98yStPl98v8o Corwin-Prescott-3_Q10_x1458.jpg to be bundled as the first one shown.

@aguscruiz
Copy link

Let's use this one https://drive.google.com/drive/u/1/folders/1aWhOBJoT5zAAsWzRM7Qg98yStPl98v8o Corwin-Prescott-3_Q10_x1458.jpg to be bundled as the first one shown.

This is the image, renamed it in Drive so that link no longer works:
https://drive.google.com/file/d/1PKIxD_L4Tr2dD5AmPKKuOzi6a1djJwwb/view?usp=sharing

image

@rebron
Copy link
Collaborator Author

rebron commented Jun 13, 2023

Closing. Released via component update on June 1st.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-tab OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Projects
None yet
Development

No branches or pull requests

3 participants