Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP Fall 2021 wallpapers #18568

Closed
4 tasks done
rebron opened this issue Oct 5, 2021 · 12 comments
Closed
4 tasks done

NTP Fall 2021 wallpapers #18568

rebron opened this issue Oct 5, 2021 · 12 comments
Assignees
Labels
closed/duplicate Issue has already been reported feature/new-tab OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 5, 2021

Description

Swap out all of our current wallpapers on the new tab with a fresh set of images.

Purpose:
prevent the images from feeling stale
give other photographers/creators a chance to showcase their work
it's fun!

Design

Screen Shot 2021-10-05 at 11 19 38 AM

Assets

Assets and photo attribution:
https://bravesoftware.slack.com/archives/C7TG12KC3/p1633458074003900
AVIF, WEBP, and compressed JPG available.
For the photo attribution - Corwin and David won't have any links.

Test plan

[placeholder]

Miscellaneous information:

Related/prior issues
#6904

@rebron rebron added OS/Desktop feature/new-tab priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Oct 5, 2021
@karenkliu
Copy link

Designs added!

@rebron rebron added the OS/Android Fixes related to Android browser functionality label Oct 21, 2021
@simonhong
Copy link
Member

simonhong commented Oct 22, 2021

@rebron which one image should be displayed as a default when component is not ready on android?
Current default one is spencer_moore_lake.webp. Or we can use it again with above new image set?

@simonhong
Copy link
Member

simonhong commented Oct 22, 2021

New NTP Background Images component is uploaded to dev-goupdater and it can be used via --use-dev-goupdater-url switch.

From local build android,

@rebron
Copy link
Collaborator Author

rebron commented Oct 27, 2021

@bradleyrichter Thoughts on default image for Android.
@simonhong I like Dylan's image. The third one in the right column with the rocks and water.

@bradleyrichter
Copy link

@rebron Do you mean column 1, row 2?

@bradleyrichter
Copy link

That should be fine for a first try.

@rebron
Copy link
Collaborator Author

rebron commented Oct 27, 2021

I like this one as default.
Screen Shot 2021-10-27 at 3 08 54 PM

But this one is fine too.
Screen Shot 2021-10-27 at 3 08 40 PM

@karenkliu
Copy link

Let's do this as the default :)

image

@simonhong
Copy link
Member

Closed as all sub-tasks are completed.

@simonhong simonhong added closed/duplicate Issue has already been reported closed/invalid labels Nov 2, 2021
@simonhong
Copy link
Member

simonhong commented Nov 2, 2021

and set duplicated as above sub-tasks PR can be tracked separately.

@stephendonner
Copy link

@simonhong is this really QA/Yes, given that it's a duplicate/invalid? If so, what's the test plan? Just confirm that all images made it to the component, right?

@simonhong
Copy link
Member

@stephendonner Yes, we update new BG images via component. and I wrote test plan in above each sub-tasks.
and set qa/no to this meta issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/new-tab OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Projects
None yet
Development

No branches or pull requests

6 participants