Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default NTP wallpaper on Android #19128

Closed
Tracked by #18568
simonhong opened this issue Nov 1, 2021 · 1 comment · Fixed by brave/brave-core#10791
Closed
Tracked by #18568

Update default NTP wallpaper on Android #19128

simonhong opened this issue Nov 1, 2021 · 1 comment · Fixed by brave/brave-core#10791
Assignees
@simonhong
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.33.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Nov 1, 2021 •
edited
Loading

This is sub-task of #18568 for replacing default bg image on Android.

STR:

  1. Launch browser with clean profile
  2. Open NTP and check Dylan Malval's image is displayed till NTP Background Images component is loaded.
@simonhong simonhong added the OS/Android Fixes related to Android browser functionality label Nov 1, 2021
@simonhong simonhong self-assigned this Nov 1, 2021
@simonhong simonhong mentioned this issue Nov 1, 2021
Closed
4 tasks
@simonhong simonhong changed the title Update NTP Fall 2021 wallpapers on Android Update default NTP wallpaper on Android Nov 1, 2021
@simonhong simonhong mentioned this issue Nov 1, 2021
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Nov 1, 2021
@simonhong
Updated default ntp wallpaper image on Android
60f4de3 
fix brave/brave-browser#19128
@simonhong simonhong added this to the 1.33.x - Nightly milestone Nov 2, 2021
@stephendonner
Copy link

Verified PASSED using Brave nightly, version 1.33.69, Chromium 96.0.4664.35 on a Google Pixel XL, running Android 9.

Steps:

  1. new install
  2. disabled Wi-Fi
  3. opened a new-tab page after installation
  4. opened a couple more new-tab pages
  5. confirmed -- when offline -- I always got Dylan Malval's image
  6. reconnected to Wi-Fi
  7. restarted Brave
  8. confirmed new-tab pages cycled through the rest of the wallpaper images
example example example example
Screenshot_20211108-125636 Screenshot_20211108-130032 Screenshot_20211108-130152 Screenshot_20211108-130413

@simonhong simonhong mentioned this issue Nov 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Updated default ntp wallpaper image on Android brave/brave-core
2 participants
@stephendonner @simonhong