Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated default ntp wallpaper image on Android #10791

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 1, 2021

fix brave/brave-browser#19128

This will be merged after resolving brave/brave-browser#19157

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch browser with clean profile
  2. Open NTP and check Dylan Malval's image is displayed till NTP Background Images component is loaded.

@simonhong simonhong added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Nov 1, 2021
@simonhong simonhong requested a review from wchen342 November 1, 2021 05:08
@simonhong simonhong self-assigned this Nov 1, 2021
@simonhong simonhong force-pushed the update_default_ntp_wallpaper_android branch from e219b0b to 60f4de3 Compare November 1, 2021 05:11
Copy link
Contributor

@wchen342 wchen342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simonhong simonhong merged commit ec8c865 into master Nov 2, 2021
@simonhong simonhong deleted the update_default_ntp_wallpaper_android branch November 2, 2021 02:52
@simonhong simonhong added this to the 1.33.x - Nightly milestone Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default NTP wallpaper on Android
2 participants