Upgrade from Chromium 125 to Chromium 126

[emerick]

Upgrade from Chromium 125 to Chromium 126

https://chromium.googlesource.com/chromium/src/+log/125.0.6422.60..126.0.6478.17/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

• Verify that browser colors, spacing, UI look correct (tabs, tab groups, tab search, sidebar, NTB, etc.)
• Verify bookmarks functionality including bookmarks sidebar panel
• Verify that Safety Check is still hidden in brave://settings (and also that Safety Hub does not appear)
• Verify NTP functionality
• Verify brave://settings toolbar functionality
• Verify all functionality related to tab "hover cards"
• Verify download widget functionality
• Verify that brave://welcome shows as expected on first-run
• Verify that updates work as expected on Mac
• Verify that sync continues to work as expected
• Verify that hamburger menu has correct/expected entries/ordering in regular and private browsers

iOS Affected areas:

• Nothing specific to note here

Android Affected areas:

• URL bar UI (make sure its look doesn't change)
• Tab overview UI (make sure there is still a bottom panel)
• Brave news
• Brave Ads notifications.
• Close all tabs - expected to have browser alive
• Icons of sites at rewards UI on Android
• Password manager - should allow to save and view passwords

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.68.50 Chromium: 126.0.6478.17 (Official Build) nightly (64-bit)
-- | --
Revision | 72b186fbe4e288f53b0ee102f6ec66133b41a992
OS | Windows 10 Version 22H2 (Build 19045.4412)

• Logged [CR 126] Privacy and security settings icon is inherited from Chrome #38593
• Logged [CR 126] Search engine, Downloads and System settings icons are inherited from Chrome #38595
• Logged [CR 126] Show all bookmarks icon is inherited from CR 126 #38589
• Logged Exit settings is hidden from the app menu on higher resolutions #38587
• Logged [CR 126] Install Password Manager icon and the modal popup buttons are inherited from Chrome #38599
• Logged [CR 126] Share this page icon is inherited from chrome #38601
• Logged Mouse hover on the Customize list text makes text invisible in the NTP search box #38608
• Logged Search suggestions are not shown in the NTP search box even when the search suggestions are enabled #38610
• Logged [CR 126] In brave://history the text Your browsing history appears here is positioned up same as chrome 126  #38638
• Logged Buttons are overlapping on the edit bookmarks modal via bookmarks sidebar panel #38639
• Logged [CR 126] Update brave notification text is not visible and update brave icon is changed #38645

Verify that browser colors, spacing, UI look correct (tabs, tab groups, tab search, sidebar, NTB, etc.)_PASSED

1. Colors, spacing, UI : covered testing while verifying settings comparison below
2. NTP : covered testing while verifying NTP functionality below
3. Tabs : covered testing while verifying tab hover cards below

Tab groups:

• Confirmed that users can create tab groups
• Confirmed that user can drag and drop the tabs into the created tab groups
• Confirmed that user can move the tab group to new window

Tab search:

• Confirmed that Tab search icon is aligned correctly and click on it shows the list of Tabs
• Confirmed that users can search any tab via Tab search modal

Example	Example

Sidebar:

• Confirmed that Sidebar items looks correctly on the sidebar
• Confirmed that click on each item on sidebar works as expected
• Bookmarks edit buttons are misaligned. Logged an issue Buttons are overlapping on the edit bookmarks modal via bookmarks sidebar panel #38639

Example	Example	Example

Verify bookmarks functionality including bookmarks sidebar panel_PASSED

• Confirmed that bookmarks can be added via NTP, Import bookmarks and settings via brave://settings/getStarted and Import bookmarks via bookmarks manager
• Confirmed that added bookmarks can be viewed/opened/edited/deleted
• Confirmed that bookmarks added in other devices are synced across all the devices in a sync chain
• Confirmed that synched bookmarks can be viewed/opened/edited/deleted
• Confirmed that imported/added/synched bookmarks are shown under bookmarks on sidebar panel
• Confirmed that bookmarks can be viewed/edited/deleted/undo on sidebar panel
• Confirmed that bookmarks looks good in both visual view and compact view

Example	Example	Example

Verify that Safety Check is still hidden in brave://settings (and also that Safety Hub does not appear)_PASSED

• Confirmed that safety check settings is still not added via brave://settings on Brave
  

Verify NTP functionality_PASSED

• Confirmed that the NTP search is enabled by default in Brave nightly
• Search suggestions are not shown even when search suggestion settings are enabled via brave://settings/appearance - logged a follow up issue Search suggestions are not shown in the NTP search box even when the search suggestions are enabled #38610
• Mouse hover on the Customize list changes the text color to white - logged a follow up issue Mouse hover on the Customize list text makes text invisible in the NTP search box #38608
• Click on Customize list in the search dropdown opens up the NTP dashboard settings with NTP search engine options
• Change the NTP search engine option via NTP dashboard and confirmed that the selected search engine is shown in the search dropdown
• Confirmed user can perform NTP search using the custom search engine
• Confirmed that NTP search widget is not shown on the NTP when the show search engine toggle is turned off via NTP dashboard settings search menu
• Confirmed that the NTP search is enabled even when the Brave news is turned on
• Confirmed that enable/disable NTP widgets are working as expected

Example	Example	Example	Example	Example	Example	Example

Verify brave://settings toolbar functionality_PASSED

• Covered the testing under settings comparison section
• Logged a follow up issue [CR 126] In brave://history the text Your browsing history appears here is positioned up same as chrome 126  #38638

Verify all functionality related to tab "hover cards"_PASSED

Tab shapes:

• Confirmed that Tab shapes are shown as expected in Card tab type hover mode
• Confirmed that Tab shapes are shown as expected in Card with preview tab type hover mode
• Confirmed that Tab shapes are shown as expected in Tooltip tab type hover mode
• Confirmed that Tab hover types works as expected on vertical tab orientation

Card	Card with preview	Tooltip	vertical tab

Verify download widget functionality_PASSED

• Confirmed that Open in folder and Delete from history buttons are replaced by options via 3 dot menu under brave://download widget
  
• Confirmed that click on Open in folder option via 3 dot menu opens up download file folder path as expected
• Confirmed that click on Delete from history option via 3 dot menu removes the download history from brave://downloads widget as expected
• Confirmed that user can find Pause and Resume options via 3 dot menu
  
• Confirmed Pause, Resume and Cancel options works as expected

Verify that brave://welcome shows as expected on first-run_Inprogress_PASSED

• Confirmed that brave://welcome looks good on browser first launch
• Confirmed that controls/buttons on each slide works as expected

Example	Example	Example	Example

Verify that sync continues to work as expected_PASSED

• Verified the sync functionality in general and it works fine without any issues
• When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices
• Confirmed the bookmarks synched across all the devices in a sync chain
• Confirmed that bookmarks added before after the sync chain are synched across all the devices in a sync chain
• When 2 devices are in a sync chain, remove a device resets the sync chain
• Confirmed that bookmarks, passwords, extensions, reading list, Saved tab groups, history, open tabs, address, email, phone number synched across all the devices in a sync chain
• Confirmed that remove a bookmark from device 1 in sync chain removes the bookmark from the other devices in a sync chain

Example	Example	Example

Verify that hamburger menu has correct/expected entries/ordering in regular and private browsers_PASSED

1. Regular window:

• The settings menu Password and autofill is shown before the History menu, the old settings Password Manager is included inside the Password and autofill menu

1.68.50 Chromium: 126.0.6478.17	1.66.115 Chromium: 125.0.6422.112

• Bookmarks is renamed as Bookmarks and lists and bookmarks submenus are included inside the Bookmarks and lists menu

1.68.50 Chromium: 126.0.6478.17	1.66.115 Chromium: 125.0.6422.112

• A new settings Translate is added below the Print menu and Find menu is renamed as Find and edit and find and edit sub menus are included inside the Find and edit menu
• A new settings Save and share is added below the Find and edit menu

1.68.50 Chromium: 126.0.6478.17	1.66.115 Chromium: 125.0.6422.112

2. Private window:

• Private window hamburger menu items are same as regular windows menu items (except Brave VPN and History, which is expected)

3. Tor window:

• Tor window hamburger menu items are same as regular windows menu items (except New tor connection for this site and History, which is expected)

4. Guest window:

• The guest windows hamburger menu settings are same as old (CR125) settings, just the new settings are Translate, Find and edit and Save and share are added

Regular window	Private window	Tor window	Guest window

---

Settings comparison

• The following menu items are added via Hamburger menu
  1. The bookmarks settings is renamed as Bookmarks and lists
  2. The Password and autofill settings is added, click on it shows the following menu items
     • Password Manager
     • Payment methods
     • Addresses and more
  3. Show all bookmarks new setting is added via Bookmarks and lists settings menu
  4. Reading list new setting is added via Bookmarks and lists settings menu

Example	Example	Example

• A new settings Show pinned tabs in all windows is added via brave://settings/appearance.
  1. By default this settings is disabled
  6. Enabled the flag #brave-shared-pinned-tabs via brave://flags
  7. Enable the settings Show pinned tabs in all windows via brave://settings/appearance and open few sites and pin the tabs in windows 1 and open windows 2 and ensured that the pinned tabs are shown on windows 2

Example	Example	Example

• Clear browsing data is renamed as Delete browsing data as part of CR 126.

Example	Example

• The content settings Automatically remove permissions from unused sites is added as part of CR 126, looks like useful settings.
  

Brave startup calls

• Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
• Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

[GeetaSarvadnya]

@LaurenWags @stephendonner: Please verify the desktop affected area item Verify that updates work as expected on Mac. Thanks!

[stephendonner]

Upgrade checks (using x64 .dmg):

Case 1: C126 --> C126 on-demand upgrade check - PASSED

1. install C126 from https://build-artifacts.brave.com/test-brave-browser-build-macos-x64/1220/Brave-Browser-Nightly-x64.dmg
2. launch via terminal using --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml
3. watch logs, confirm no update found
4. close Brave
5. (note, to check deltas, launch Fiddler Everywhere or similar before continuing)
6. relaunch using --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly/appcast.xml
7. navigate to brave://settings/help and ensure that an update has been found/applied

[96144:259:0528/202839.220853:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[96144:259:0528/202839.222883:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)
[96144:259:0528/202839.224748:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)
[96144:259:0528/202941.057061:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)

8. confirm you are prompted to Relaunch to get an update

Once relaunched, ensure the correct version was installed per the following

brave://settings/help	brave://version

Case 2: C125 --> C126 on-demand upgrade check - PASSED

1. install C125 from https://github.com/brave/brave-browser/releases/tag/v1.68.36
2. launch via terminal using --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml
3. watch logs, confirm no update found
4. close Brave
5. (if you want to check deltas, launch Fiddler Everywhere or similar, before continuing)
6. relaunch with --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly/appcast.xml
7. navigate to brave://settings/help and ensure that an update has been applied

[95802:259:0528/161834.808608:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[95802:259:0528/161834.809954:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)
[95802:259:0528/161834.810516:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)
[95802:259:0528/161836.745463:WARNING:CONSOLE(5)] "crbug/1173575, non-JS module files deprecated.", source: chrome://resources/js/load_time_data_deprecated.js (5)
[95802:259:0528/161933.579174:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)

8. confirm you are prompted to Relaunch to get update

Once relaunched, ensure the correct version was installed as per the following:

brave://settings/help	brave://version

Case 3: C126 --> C126 background-upgrade check - PASSED

1. Install C126 build via https://build-artifacts.brave.com/test-brave-browser-build-macos-x64/1220/Brave-Browser-Nightly-x64.dmg
2. Launch via terminal as follows: --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle)
3. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
4. Close browser
5. Delete the following:

• com.brave.Browser.nightly folder from ~/Library/Caches
• com.brave.Browser.nightly.plist file from ~/Library/Preferences
• Alternatively you can probably advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.

6. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
7. After computer restart, Relaunch with --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly/appcast.xml
8. DO NOT navigate to brave://settings/help
9. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)

[831:259:0528/210811.624631:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[831:259:0528/210811.626273:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)
[831:259:0528/210811.626859:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)
[831:259:0528/210858.890868:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)

10. Close and restart the browser via terminal with same command as step 7
11. Check version is updated under brave://version

Case 4: C125 --> C126 background-upgrade check - PASSED

1. Install C125 build via https://github.com/brave/brave-browser/releases/tag/v1.68.36
2. Launch via terminal as follows: --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle)
3. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
4. Close browser
5. Delete the following:

• com.brave.Browser.nightly folder from ~/Library/Caches
• com.brave.Browser.nightly.plist file from ~/Library/Preferences
• Alternatively you can probably advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.

6. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
7. After computer restart, Relaunch with --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly/appcast.xml
8. DO NOT navigate to brave://settings/help
9. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)

[756:259:0528/212518.848865:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[756:259:0528/212518.851260:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)
[756:259:0528/212518.852084:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)
[765:12035:0528/212537.222494:ERROR:ssl_client_socket_impl.cc(879)] handshake failed; returned -1, SSL error code 1, net_error -100
[756:259:0528/212606.068573:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 23 May 2024 15:22:10 +0000, Version: 1.68.39.0)

10. Close and restart the browser via terminal with same command as step 7
11. Check version is updated under brave://version

[hffvld]

Verified on Pixel 6 using version(s):

Device/OS: Pixel 6 / oriole-user 14 AP1A.240405.002 release-keys
Brave build: 1.68.55 
Chromium: 126.0.6478.17 (Official Build) canary (64-bit) 

• Filed follow-up issues that are not related to Cr126 changes Unable to download passwords on local storage #38655, Chrome help page is opened instead of Brave one when tapping ? on Brave Password Manager screen #38684
• Existing issue for the website icons old favicons not being updated to v2 via brave://rewards after uprade - follow up to #37941 #38115

---

URL bar UI (make sure its look doesn't change)

ACTUAL RESULTS:

• Verified that the URL search bar looks the same as before in the Standard and Private tab
• Verified that Share, Copy & Edit buttons are available
• Verified that search with QR code and Voice search are working

---

Standard tab

1	2	3	4

Private tab

1	2	3	4

Tab overview UI (make sure there is still a bottom panel)

ACTUAL RESULTS:

• Verified that the Tab overview UI has + and Main menu on the bottom
• Verified the same for the Standard and Private tab

---

1	2	3	4

Brave news

ACTUAL RESULTS:

• Verified that Brave News is working as expected
• Verified that it's possible to add/remove news sources
• Verified that the long tap on the news card is working

---

1	2	3	4

Brave Ads notifications

ACTUAL RESULTS:

• Verified that ad notifications are shown as expected
• Verified that all logs are shown as expected including View, Click, Land and Dismiss

---

1	2	3

Close all tabs - expected to have browser alive

ACTUAL RESULTS:

• Verified that Brave stays opened when closing all tabs
• Verified that Closing all tabs closes Brave is OFF by default

---

1	2	3	4

Icons of sites at rewards UI on Android

ACTUAL RESULTS:

• Observed that website icons on the Rewards page are still not shown. We have already opened ticket for this issue old favicons not being updated to v2 via brave://rewards after uprade - follow up to #37941 #38115

---

1	2

Password manager - should allow to save and view passwords

ACTUAL RESULTS:

• Verified that the Brave Password Manager offers to save a password
• Verified that the saved password can be used to sign in on a website
• Verified that saved password can be seen and editable if needed

---

1	2	3	4

[stephendonner]

Upgrade checks (using arm64 .dmg):

C126 --> C126 on-demand upgrade check - PASSED

1. Install C126 PR build (https://build-artifacts.brave.com/test-brave-browser-build-macos-arm64/625/Brave-Browser-Nightly-arm64.dmg)
2. Launch via terminal as follows: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle)
3. Watch logs, confirm no update found (can also visit brave://settings/help but close this tab prior to closing the browser)
4. Close Brave
5. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing.
6. Relaunch with /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly-arm64/appcast.xml
7. Navigate to brave://settings/help and ensured that an update has been found/being applied

[49615:259:0528/132714.302853:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[49615:259:0528/132714.304065:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)
[49615:259:0528/132714.305815:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)
[49615:259:0528/132759.415776:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)

8. Confirm you are prompted to "Relaunch" to get update (note, if you click "Relaunch" button you will relaunch and could potentially pick up a newer Nightly that is on the previous Chromium version. Closing and then relaunching via the terminal will not update you again)

Once relaunched, ensured the correct version was installed as per the following:

Example	Example

C125 --> C126 on-demand upgrade check - PASSED

1. Install C125 build via https://github.com/brave/brave-browser/releases/tag/v1.68.36
2. Launch via terminal as follows: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle)
3. Watch logs, confirm no update found (can also visit brave://settings/help but close this tab prior to closing the browser)
4. Close Brave
5. Relaunch with /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly-arm64/appcast.xml
6. Navigate to brave://settings/help and ensured that an update has been found/being applied

[52785:259:0528/144300.754281:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[52785:259:0528/144300.755806:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)
[52785:259:0528/144300.757067:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)
[52785:259:0528/144304.417965:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)

7. Confirm you are prompted to "Relaunch" to get update (see note in first case about this button)

Once relaunched, ensured the correct version was installed as per the following:

Example	Example

C126 --> C126 background upgrade check - PASSED

1. Install C126 PR build ( https://build-artifacts.brave.com/test-brave-browser-build-macos-arm64/624/Brave-Browser-Nightly-arm64.dmg)
2. Launch via terminal as follows: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle)
3. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
4. Close browser
5. Delete the following:

• com.brave.Browser.nightly folder from ~/Library/Caches
• com.brave.Browser.nightly.plist file from ~/Library/Preferences
• Alternatively you can probably advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.

6. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
7. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing.
8. After computer restart, Relaunch with /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly-arm64/appcast.xml
9. DO NOT navigate to brave://settings/help
10. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)

[887:259:0528/205449.649101:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[887:259:0528/205449.650532:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)
[887:259:0528/205449.651766:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)
[887:259:0528/205504.241607:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)

11. Close and restart the browser via terminal with same command as step 8
12. Check version is updated under brave://version

C125 --> C126 background upgrade check - PASSED

1. Install C125 build via https://github.com/brave/brave-browser/releases/tag/v1.68.36
2. Launch via terminal as follows: /Applications/Brave\ Browser\ Nightly.app/Contents/MacOS/Brave\ Browser\ Nightly --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up any newer Nightly versions that have already been uploaded to sparkle)
3. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
4. Close browser
5. Delete the following:

• com.brave.Browser.nightly folder from ~/Library/Caches
• com.brave.Browser.nightly.plist file from ~/Library/Preferences
• Alternatively you can probably advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.

6. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
7. After computer restart, Relaunch with --args --enable-logging=stderr --update-feed-url=https://updates-panel.brave.com/sparkle/Brave-Browser/nightly-arm64/appcast.xml
8. DO NOT navigate to brave://settings/help
9. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)

[890:259:0528/204522.763935:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[890:259:0528/204522.765249:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)
[890:259:0528/204522.766457:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)
[890:259:0528/204603.465728:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 23 May 2024 14:57:45 +0000, Version: 1.68.39.0)

11. Close and restart the browser via terminal with same command as step 7
12. Check version is updated under brave://version

[stephendonner]

@LaurenWags @stephendonner: Please verify the desktop affected area item Verify that updates work as expected on Mac. Thanks!

x64: #37788 (comment) ✅

arm64: #37788 (comment) ✅

[kjozwiak]

Labelling as QA/NO & release-notes/exclude in favour of #38675 (comment).