Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CR 126] Show all bookmarks icon is inherited from CR 126 #38589

Closed
1 of 6 tasks
GeetaSarvadnya opened this issue May 27, 2024 · 7 comments · Fixed by brave/brave-core#23976
Closed
1 of 6 tasks

[CR 126] Show all bookmarks icon is inherited from CR 126 #38589

GeetaSarvadnya opened this issue May 27, 2024 · 7 comments · Fixed by brave/brave-core#23976
Assignees
@simonhong
Labels
branding OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.67.x - Release

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #37788
Show all bookmarks icon is inherited from CR 126

Steps to reproduce

  1. Clean profile 1.68.50
  2. Click on the hamburger menu
  3. Click on Bookmarks and lists
  4. Show all bookmarks icon is inherited from CR 126

Actual result

Show all bookmarks icon is inherited from CR 126

image

Expected result

Show all bookmarks settings should have brave branded icon

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.68.50 Chromium: 126.0.6478.17 (Official Build) nightly (64-bit)
Revision 72b186fbe4e288f53b0ee102f6ec66133b41a992
OS Windows 10 Version 22H2 (Build 19045.4412)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @brave/qa-team @emerick @rebron
@GeetaSarvadnya GeetaSarvadnya mentioned this issue May 27, 2024
Closed
@GeetaSarvadnya
Copy link
Author

cc: @aguscruiz

@aguscruiz
Copy link

We can use the current bookmarks icon here:
Design
https://www.figma.com/design/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?node-id=6697-27337&t=B9Uj4dHnKD9GZsuA-1

@GeetaSarvadnya
Copy link
Author

The following settings should have the brave icons

The ones that are from new menu items:

Main menu:

  • Translate
  • Find and edit
  • Find and share
    image

Passwords and autofill:

  • Password manager
  • Payment methods
  • Addresses and more
    image

Bookmarks:

  • Show all bookmarks
    image

@GeetaSarvadnya
Copy link
Author

Please refer https://bravesoftware.slack.com/archives/CU5UXM3EC/p1716812764653739?thread_ts=1716477777.596219&cid=CU5UXM3EC for more info

@rebron rebron moved this to In progress in Settings May 28, 2024
@rebron rebron changed the title Show all bookmarks icon is inherited from CR 126 [CR 126] Show all bookmarks icon is inherited from CR 126 May 31, 2024
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 31, 2024
@simonhong
Copy link
Member

checking.

@simonhong simonhong mentioned this issue Jun 4, 2024
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Jun 5, 2024
@simonhong
Re-branding app menu's icon
2bd08cb 
fix brave/brave-browser#38589
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone Jun 5, 2024
@brave-builds brave-builds mentioned this issue Jun 5, 2024
Merged
7 tasks
@kjozwiak kjozwiak moved this from In progress to Completed in Settings Jun 6, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Jun 6, 2024

The above requires 1.67.108 or higher for 1.67.x verification 👍

@GeetaSarvadnya
Copy link
Author

Verification PASSED on

Brave | 1.67.108 Chromium: 126.0.6478.40 (Official Build) beta (64-bit)
-- | --
Revision | a286dc9f61f7d70fbf0157fcf3d924b00297d450
OS | Windows 10 Version 22H2 (Build 19045.4412)

image

@rebron rebron removed this from Settings Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
branding OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

Re-branding app menu's icon brave/brave-core
7 participants
@kjozwiak @emerick @rebron @simonhong @aguscruiz @GeetaSarvadnya @brave-builds