Re-branding app menu's icon

[simonhong]

fix brave/brave-browser#38589

Resolves

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

See the linked issue

[simonhong]

@aguscruiz @rebron
We have another new sub menus - Find and Edit and Save and Share
I think we need to update the icons of their sub menu entries. Don't have these sub menu design in figma.
Find is our icon but others are from upstream.

and if we want to enable Reading List sub menu, their ones also needs to be updated.

[aguscruiz]

@simonhong added all the missing ones to our Figma
https://www.figma.com/design/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?node-id=6697-27337&t=hv9qaLCoqTHbRLip-1

There's a couple new icons. that need to be synced from Nala, like "Cut"

[simonhong]

@simonhong added all the missing ones to our Figma https://www.figma.com/design/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?node-id=6697-27337&t=hv9qaLCoqTHbRLip-1

There's a couple new icons. that need to be synced from Nala, like "Cut"

@aguscruiz Just want to double check about Install facebook icon above.
figma uses clipboard icon for it. it's right?
We're using another icon so far.

[fallaciousreasoning]

Looks great, thanks @simonhong !

[aguscruiz]

@simonhong added all the missing ones to our Figma https://www.figma.com/design/H11ZOl6JMYbCTW4ZJXqR5V/%F0%9F%A6%81-Browser?node-id=6697-27337&t=hv9qaLCoqTHbRLip-1
There's a couple new icons. that need to be synced from Nala, like "Cut"

@aguscruiz Just want to double check about Install facebook icon above. figma uses clipboard icon for it. it's right? We're using another icon so far.

Whoops, my bad. Yeah the one you have is the right one. I'll fix in Figma

[kjozwiak]

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.68.76 Chromium: 126.0.6478.26 (Official Build) nightly (64-bit)
-- | --
Revision | 997c487ad3e5dee61238fe8fed55bb085aa89074
OS | Windows 11 Version 23H2 (Build 22631.3672)

Using the STR/examples outlined via brave/brave-browser#38589 (comment), brave/brave-browser#38589 (comment) & #23976 (comment), ensured that the correct icons were being used via the Hamburger Menu as per the following:

Example	Example	Example	Example	Example	Example