Upgrade from Chromium 125 to Chromium 126 #23233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdesouza-chromium
force-pushed
the
cr126
branch
from
bf720c3 to
8b3cb31
Compare
github-actions
bot
added
CI/run-network-audit
|
A Storybook has been deployed to preview UI for the latest push |
cdesouza-chromium
force-pushed
the
cr126
branch
from
b2f7607 to
cfcc336
Compare
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
…ed parameter anymore Related Chromium change: [SurfacePolish][CleanUp] Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter. Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter. Bug: 331667743 Change-Id: Id575285bd8d903e067e4c8c7a8edf6a433cafa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530104
Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/a90215339806ae4f6a512a63d84fa06063c7f3ff [SurfacePolish][CleanUp] Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter. Clean up surface polish code related with SURFACE_POLISH_LESS_BRAND_SPACE_PARAM parameter. Bug: 331667743 Change-Id: Id575285bd8d903e067e4c8c7a8edf6a433cafa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5530104
…ated Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/a3bca21ae74b12a3373b7df0e51d46a19c8b872a Modularize webui_util.h Several desktop-only methods are moved to webui_util_desktop. These methods are marked as deprecated, as they use disallowed methods. Bug: 339497734 Change-Id: I5f58ab882b8325581ec66290f69c98131fb3b6af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528814
This icon shows up as the Page Info icon for brave://settings, among other places. Chromium change: https://source.chromium.org/chromium/chromium/src/+/b2294323445cdef22b355708c6b4b691235c9804 commit b2294323445cdef22b355708c6b4b691235c9804 Author: Emily Shack <[email protected]> Date: Tue May 7 20:03:21 2024 +0000 Remove CustomizeChromeSupportsChromeRefresh2023 Also removes a test hack that was causing failures with these changes. The flags referenced in that hack are also getting cleaned up concurrently, and should no longer ever be false. Additionally, removes kCustomizeChromeSidePanelNoChromeRefresh2023, which is no longer used. #chrome-refresh-2023-cleanup Bug: 335903631, 335904195, 41492974
Removed upstream colors.
…password store. Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/d8a8c88e167001e6262883973dac7fed724c7a7e Reland "[UPM] Always set use_login_database_as_backend to false for android" This is a reland of commit 6183fd7d4b080a7a70ecaf123408d86101ebfdec The CL was reverted because of the tests breakage. The reason for that was that one of the bots had an outdated GMS Core version. The problem was fixed in the CL crrev.com/c/5490111. Original change's description: > [UPM] Always set use_login_database_as_backend to false for android > > IMPORTANT: Using the login database on Android will be deprecated in > about 6 months. This CL makes using the GMS Core for password storing > the default approach. > > chrome_public_apk can still be built with the login database by setting > the argument use_login_database_as_backend=true in the args.gn. > The default value of use_login_database_as_backend is set to false on > Android in this CL. > > The increase of binary size is taking place because the build flag value is changed, which causes our feature code to be compiled for Chromium builds now. Chrome builds already contain the code, so for those, this change is a no-op. > > Bug: 331746629 > Binary-Size: Size increase is unavoidable (see above) > Change-Id: Ibf3fe2d6c63bae521496d722ceebe7d0b4ac41d2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5402473 > Reviewed-by: Andrew Grieve <[email protected]> > Reviewed-by: Vasilii Sukhanov <[email protected]> > Commit-Queue: Anna Tsvirchkova <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1292307} Bug: 331746629 Binary-Size: Size increase is unavoidable (see above) Change-Id: I0f62a2dc0a4c764fef738995eeae666af06f9653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5493819
Chromium change: https://source.chromium.org/chromium/chromium/src/+/67a610e6329dc0bdc58408725a044871f460fa59 commit 67a610e6329dc0bdc58408725a044871f460fa59 Author: Jong Ahn <[email protected]> Date: Tue May 7 00:43:47 2024 +0000 [Structured Metrics]: Remove old nearby share feature flag. It has been some time since this has launched so removing feature flag. Bug: 336801244
Chromium change: https://source.chromium.org/chromium/chromium/src/+/153730cf46e506f9306cee4896f66a8314661188 commit 153730cf46e506f9306cee4896f66a8314661188 Author: Joshua Pawlicki <[email protected]> Date: Tue Apr 16 15:14:57 2024 +0000 Reland "Chrome/Updater: Use the updater scheduler to ensure updater presence." This is a reland of commit 6c8d9f199eb403213d463b85787040c0f4736580 The original CL is patchset 1. Original change's description: > Chrome/Updater: Use the updater scheduler to ensure updater presence. > > The goal of this CL is to simplify and consolidate the number of flows > that lead to installation of the updater. This reduces contention on > the updater locks, etc, and may improve the startup performance of > Chrome and the reliability of the promotion infobar. These changes have > the following effects: > > 1. Installation of the updater and registration of Chrome will happen > 19 seconds after browser startup, rather than twice during message > loop and UI pre-initialization. > 2. The promotion infobar will be shown at that time, if necessary, > rather than right away. This is beneficial in some cases since > previously the infobar wouldn't be shown in cases where the profile > selection dialog is shown. > 3. The infobar will be shown on the first run of Chrome if needed. > 4. The infobar will shown several hours into the browsing session if > it did not previously show, or if things have changed and promotion > is now needed. > > There is still one other path to EnsureUpdater that I did not alter > here - if Chrome is restarted with a chrome://help tab open, that tab > will initiate an on-demand update check, installing the updater if > necessary. Multiple such tabs might cause contention on the locks, but > do not cause any errors. Performance issues associated with that seem > infrequent and don't justify additional complexity in my opinion. > > Fixed: b/332911252 > Change-Id: Ibdef62b1807f25e7cddaf8f41ab37ca2499cf969 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5425369 > Auto-Submit: Joshua Pawlicki <[email protected]> > Reviewed-by: Mark Mentovai <[email protected]> > Commit-Queue: Joshua Pawlicki <[email protected]> > Reviewed-by: Greg Thompson <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1287969} Change-Id: If70f187f22e2ea3b557d6430e5af5afcfe3d88fe
The necessary substitution for the side panel type doesn't propagate to browser tests. This change adds an override to account for it in this new test. Chromium change: https://chromium.googlesource.com/chromium/src/+/6af23c1169286add9ccffde22ace7e4781efb981 commit 6af23c1169286add9ccffde22ace7e4781efb981 Author: Duncan Mercer <[email protected]> Date: Thu May 16 00:50:34 2024 +0000 Reland "[lensoverlay] Fix side panel interactions" This reverts commit d55b86a5ac50f4ef75d71be5a2e955b1c4dd4aeb. Reason for revert: Disabled failing tests for ChromeOS. Original change's description: > Revert "[lensoverlay] Fix side panel interactions" > > This reverts commit d5923aacfdaeb3c86cb09269c9e819e1348f3c08. > > Reason for revert: Linux MSan failures > > Original change's description: > > [lensoverlay] Fix side panel interactions > > > > 1) If a side panel is open when the overlay is invoked, we > > close it and wait for it to close before taking a > > screenshot. This plays the side panel sliding close > > animation which refows the page so it is ready for the > > screenshot. > > 2) When we are closing the overlay, if our side panel is open, > > we wait close it and wait for it to finish closing before > > hiding the overlay. This allows our overlay to smoothly grow > > before hiding, making a less jarring transition. > > > > Since we are relying on events from the side panel, and other > > clients of the side panel can interrupt the sequence we are > > waiting for, it is important we never get in a stuck state. To do > > this, I added a closing interrupted event, which notifies us if > > the side panel was closing but got reopened. With this close > > interrupted event, along with precise state tracking in the > > overlay, the overlay should be robust enough to not get stuck > > waiting for side panel close/open. > > > > Bug: b:337344507, b:328296424 > > Change-Id: I5e9755e2d51831a79ce825a6d5cd6bbc042bf2c9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5534998 > > Reviewed-by: Thomas Lukaszewicz <[email protected]> > > Reviewed-by: Mark Pearson <[email protected]> > > Commit-Queue: Duncan Mercer <[email protected]> > > Reviewed-by: Erik Chen <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1301006} > > Bug: b:337344507, b:328296424 > Change-Id: I499b9347691d361c9c7d45873679aeca73ac1b31 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5541053 > Commit-Queue: Kalvin Lee <[email protected]> > Owners-Override: Kalvin Lee <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1301114} Bug: b:337344507, b:328296424
This change also replaces `obsoleted` with `deprecated` for iOS 16 marked types to produce warnings instead of errors for references to those types
fixes brave/brave-browser#38524 Related Chromium change: https://source.chromium.org/chromium/chromium/src/+/d185bd9ea3aa006e8dfc789dce07f3d902886c9a [Android] Allow CachedFlags to specify test defaults This mimics fieldtrial_testing_config.json for CachedFlag in tests. It does not affect the flag value in developer builds like fieldtrial_testing_config.json does, however. Bug: 40239922 Change-Id: I8b67a6c2feeadd5ce12dcf6d41fe4c2e3e3d240f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5523173
|
A Storybook has been deployed to preview UI for the latest push |
24 tasks
emerick
added a commit
that referenced
this pull request
May 29, 2024
Upgrade from Chromium 125 to Chromium 126
kjozwiak
pushed a commit
that referenced
this pull request
May 30, 2024
* [CodeHealth] Use span for args on `redirect_cc` (#23698) This change corrects the build errors when building `redirect_cc` with `-Wunsafe-buffers-usage`, by introducing a span argument to handle access to the array of strings in `argv`. The resulting code is more readable, and also relies on the hardening features available to span. * Bytecode tests for static methods (#23699) * Static/regular method is now arg of methodExists * Removed Brave**** classes from methodExists/classExists tests * Merge pull request #23233 from brave/cr126 Upgrade from Chromium 125 to Chromium 126 * Fix test_data dependency. (#23841) * Merge pull request #23862 from brave/search_promotion_layout Fixed search promotion's layout regression * Merge pull request #23869 from brave/cr126-followup-fix-share-this-page-icon Use Brave branded icon for Share this page * Merge pull request #23868 from brave/cr126-followup-fix-settings-icons Fix use of upstream icons in brave://settings * Merge pull request #23871 from brave/cr126-followup-disable-pwa-universal-install Disable PWA universal install feature flag * Merge pull request #23874 from brave/cr126-followup-disable-security-privacy-feature-flags Disable features flagged by privacy/security team * Upgrade from Chromium 126.0.6478.17 to Chromium 126.0.6478.26 (#23896) * Update from Chromium 126.0.6478.17 to Chromium 126.0.6478.26. * Conflict-resolved patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26. * Update patches from Chromium 126.0.6478.17 to Chromium 126.0.6478.26. * Updated strings for Chromium 126.0.6478.26. * Merge pull request #23897 from brave/android_search_widget_crash Fixes a crash on search widget on Android * Merge pull request #23894 from brave/cr126-followup-disable-sync-promo Disable showing sync promo * Merge pull request #23902 from brave/cr126-followup-fix-dangerous-downloads-ui Disable safe_browsing::kImprovedDownloadPageWarnings feature flag * Merge pull request #23909 from brave/help_bubble_view_button_regressions Fixed HelpBubbleView's secondary button text is not visible * Fixed color of switch at Shields and content filters (#23910) Fixed color of switch at Shields and content filters --------- Co-authored-by: cdesouza-chromium <[email protected]> Co-authored-by: AlexeyBarabash <[email protected]> Co-authored-by: goodov <[email protected]> Co-authored-by: Simon Hong <[email protected]> Co-authored-by: Serg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#37788
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: