Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 126.0.6478.17 to Chromium 126.0.6478.26 #38675

Closed
emerick opened this issue May 29, 2024 · 7 comments · Fixed by brave/brave-core#23896
Closed

Upgrade from Chromium 126.0.6478.17 to Chromium 126.0.6478.26 #38675

emerick opened this issue May 29, 2024 · 7 comments · Fixed by brave/brave-core#23896
Assignees

Comments

@emerick
Copy link
Contributor

emerick commented May 29, 2024

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/126.0.6478.17..126.0.6478.26?pretty=fuller&n=10000

QA tests

  • Check branding items
  • Check for version bump

Minor Chromium bump

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

The above requires 1.67.101 or higher for 1.67.x verification 👍

@kjozwiak
Copy link
Member

Quick overview of the work remaining re: affected areas due to C126 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #37788 (comment):

Platforms that still need to check/verify the affected areas due to C124 changes as per #36346 (comment):

  • Android Tablet - Still requires a pass through the affected areas.
  • macOS - Still requires a pass through the affected areas.
  • Linux - Still requires a pass through the affected areas.

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.67.101 Chromium: 126.0.6478.26 (Official Build) beta (64-bit)
-- | --
Revision | a561f4b53cdb831888e5cd702d2b8f9598c00f50
OS | Windows 10 Version 22H2 (Build 19045.4412)

image

@stephendonner
Copy link

stephendonner commented Jun 3, 2024

Verification PASSED using

Brave | 1.67.104 Chromium: 126.0.6478.26 (Official Build) beta (x86_64)
-- | --
Revision | 9a4d1cb2f47a60953416cd3f39f0520e4dd4cf0e
OS | macOS Version 14.5 (Build 23F79)
Verify that browser colors, spacing, UI look correct (tabs, tab groups, tab search, sidebar, NTB, etc. - PASSED
  1. Colors, spacing, UI : covered testing while verifying settings comparison below
  2. NTP : covered testing while verifying NTP functionality below
  3. Tabs : covered testing while verifying tab hover cards below

Tab groups:

  • Confirmed that users can create tab groups
  • Confirmed that user can drag and drop the tabs into the created tab groups
  • Confirmed that user can move the tab group to new window
Screen Shot 2024-06-03 at 3 15 05 PM

Tab search:

  • Confirmed that Tab search icon is aligned correctly and click on it shows the list of Tabs
  • Confirmed that users can search any tab via Tab search modal
Example Example
Screen Shot 2024-06-03 at 3 19 09 PM Screen Shot 2024-06-03 at 3 19 17 PM

Sidebar:

Example Example Example
Screen Shot 2024-06-03 at 3 23 15 PM Screen Shot 2024-06-03 at 3 27 34 PM Screen Shot 2024-06-03 at 3 29 29 PM
Verify bookmarks functionality including bookmarks sidebar panel - PASSED
  • Confirmed that bookmarks can be added via NTP, Import bookmarks and settings via brave://settings/getStarted and Import bookmarks via bookmarks manager
  • Confirmed that added bookmarks can be viewed/opened/edited/deleted
  • Confirmed that bookmarks added in other devices are synced across all the devices in a sync chain
  • Confirmed that synched bookmarks can be viewed/opened/edited/deleted
  • Confirmed that imported/added/synched bookmarks are shown under bookmarks on sidebar panel
  • Confirmed that bookmarks can be viewed/edited/deleted/undo on sidebar panel
  • Confirmed that bookmarks looks good in both visual view and compact view
Example Example Example
Screen Shot 2024-06-04 at 3 17 12 PM Screen Shot 2024-06-04 at 3 17 36 PM Screen Shot 2024-06-04 at 3 17 51 PM
Verify that Safety Check is still hidden in brave://settings (and also that Safety Hub does not appear) - PASSED
  • Confirmed that safety check settings is still not added via brave://settings on Brave
Screen Shot 2024-06-03 at 3 54 46 PM
Verify NTP functionality - PASSED
  • Confirmed that the NTP search is available via brave://flags
  • Encountered ssue Search suggestions are not shown in the NTP search box even when the search suggestions are enabled #38610
  • Click on Customize list in the search dropdown opens up the NTP dashboard settings with NTP search engine options
  • Change the NTP search engine option via NTP dashboard and confirmed that the selected search engine is shown in the search dropdown
  • Confirmed user can perform NTP search using the custom search engine
  • Confirmed that NTP search widget is not shown on the NTP when the show search engine toggle is turned off via NTP dashboard settings search menu
  • Confirmed that the NTP search is enabled even when the Brave news is turned on
  • Confirmed that enable/disable NTP widgets are working as expected
Example Example Example Example
Screen Shot 2024-06-04 at 12 15 00 AM Screen Shot 2024-06-04 at 12 15 11 AM Screen Shot 2024-06-04 at 3 36 56 PM Screen Shot 2024-06-04 at 3 37 01 PM
Verify brave://settings toolbar functionality - PASSED
Verify all functionality related to tab "hover cards" - PASSED

Tab shapes:

  • Confirmed that Tab shapes are shown as expected in Card tab type hover mode
  • Confirmed that Tab shapes are shown as expected in Card with preview tab type hover mode
  • Confirmed that Tab shapes are shown as expected in Tooltip tab type hover mode
  • Confirmed that Tab hover types works as expected on vertical tab orientation
Card Card with preview Tooltip vertical tab
Screen Shot 2024-06-03 at 4 15 26 PM Screen Shot 2024-06-03 at 4 18 05 PM Screen Shot 2024-06-03 at 4 19 06 PM Screen Shot 2024-06-03 at 4 26 17 PM
Verify download widget functionality - PASSED
  • Confirmed that Open in folder and Delete from history buttons are replaced by options via 3 dot menu under brave://download widget
Screen Shot 2024-06-03 at 4 04 54 PM
  • Confirmed that click on Open in folder option via 3 dot menu opens up download file folder path as expected

  • Confirmed that click on Delete from history option via 3 dot menu removes the download history from brave://downloads widget as expected

  • Confirmed that user can find Pause and Resume options via 3 dot menu

  • Confirmed Pause, Resume and Cancel options works as expected

Screen Shot 2024-06-03 at 4 10 32 PM
Verify that brave://welcome shows as expected on first-run - PASSED
  • Confirmed that brave://welcome looks good on browser first launch
  • Confirmed that controls/buttons on each slide works as expected
Example Example Example Example
Screen Shot 2024-06-03 at 3 38 05 PM Screen Shot 2024-06-03 at 3 38 25 PM Screen Shot 2024-06-03 at 3 38 31 PM Screen Shot 2024-06-03 at 3 38 38 PM
Verify that sync continues to work as expected - PASSED
  • Verified the sync functionality in general and it works fine without any issues
  • When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices
  • Confirmed the bookmarks synched across all the devices in a sync chain
  • Confirmed that bookmarks added before after the sync chain are synched across all the devices in a sync chain
  • When 2 devices are in a sync chain, remove a device resets the sync chain
  • Confirmed that bookmarks, passwords, extensions, reading list, Saved tab groups, history, open tabs, address, email, phone number synched across all the devices in a sync chain
  • Confirmed that remove a bookmark from device 1 in sync chain removes the bookmark from the other devices in a sync chain
Example Example Example
Screen Shot 2024-06-04 at 10 04 15 AM Screen Shot 2024-06-04 at 10 11 40 AM Screen Shot 2024-06-04 at 10 11 44 AM
Verify that hamburger menu has correct/expected entries/ordering in regular and private browsers - PASSED

1. Regular window:

  • The settings menu Password and autofill is shown before the History menu, the old settings Password Manager is included inside the Password and autofill menu
1.67.104 Chromium: 126.0.6478.26 1.66.118 Chromium: 125.0.6422.147
Screen Shot 2024-06-04 at 3 47 11 PM Screen Shot 2024-06-04 at 5 47 02 PM
  • Bookmarks is renamed as Bookmarks and lists and bookmarks submenus are included inside the Bookmarks and lists menu
1.67.104 Chromium: 126.0.6478.26 1.66.118 Chromium: 125.0.6422.147
Screen Shot 2024-06-04 at 3 58 13 PM Screen Shot 2024-06-04 at 5 47 47 PM
  • A new settings Translate is added below the Print menu and Find menu is renamed as Find and edit and find and edit sub menus are included inside the Find and edit menu
  • A new settings Save and share is added below the Find and edit menu
1.67.104 Chromium: 126.0.6478.26 1.66.118 Chromium: 125.0.6422.147
Screen Shot 2024-06-04 at 5 50 06 PM Screen Shot 2024-06-04 at 5 48 46 PM

2. Private window:

  • Private window hamburger menu items are same as regular windows menu items (except Brave VPN and History, which is expected)

3. Tor window:

  • Tor window hamburger menu items are same as regular windows menu items (except New tor connection for this site and History, which is expected)

4. Guest window:

  • The guest windows hamburger menu settings are same as old (CR125) settings, just the new settings are Translate, Find and edit and Save and share are added
Regular window Private window Tor window Guest window
Screen Shot 2024-06-04 at 3 29 21 PM Screen Shot 2024-06-04 at 3 26 13 PM Screen Shot 2024-06-04 at 3 27 28 PM Screen Shot 2024-06-04 at 3 27 37 PM

Settings comparison - PASSED

  • The following menu items are added via Hamburger menu
    1. The bookmarks settings is renamed as Bookmarks and lists
    2. The Password and autofill settings is added, click on it shows the following menu items
      • Password Manager
      • Payment methods
      • Addresses and more
    3. Show all bookmarks new setting is added via Bookmarks and lists settings menu
    4. Reading list new setting is added via Bookmarks and lists settings menu
Example Example Example
Screen Shot 2024-06-04 at 5 54 11 PM Screen Shot 2024-06-04 at 5 55 31 PM Screen Shot 2024-06-04 at 5 55 50 PM
  • Clear browsing data is renamed as Delete browsing data as part of CR 126.
Example Example
Screen Shot 2024-06-04 at 6 01 12 PM Screen Shot 2024-06-04 at 6 01 15 PM
  • The content settings Automatically remove permissions from unused sites is added as part of CR 126, looks like useful settings.
Screen Shot 2024-06-04 at 6 02 34 PM

Brave startup calls - PASSED

  • Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 3, 2024
@LaurenWags
Copy link
Member

LaurenWags commented Jun 3, 2024

Verified with

Brave | 1.67.100 Chromium: 125.0.6422.112 (Official Build) beta (x86_64)
-- | --
Revision | 34fcbb6655521b55468af6c63601a8e3c5d24cd2
OS | macOS Version 13.6.7 (Build 22G720)

From #37788 (comment):

  • Verify that updates work as expected on Mac
x64 (.dmg) - on-demand update - deltas - PASSED
  1. Note current and previous public versions
  2. Install previous public version (x64 .dmg)
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Screenshot 2024-06-03 at 2 31 26 PM
  1. Close browser
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing.
  3. Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
Screenshot 2024-06-03 at 2 33 46 PM
[30357:259:0603/143253.917996:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[30357:259:0603/143253.920621:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[30357:259:0603/143253.921679:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[30357:259:0603/143301.332514:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 7
  2. Check version is updated under brave://version
Example Example
Screenshot 2024-06-03 at 2 34 20 PM Screenshot 2024-06-03 at 2 34 26 PM
  1. Confirmed delta updates:
Example Example
Screenshot 2024-06-03 at 2 33 12 PM Screenshot 2024-06-03 at 2 33 25 PM
x64 (.dmg) - on-demand update - no deltas - PASSED
  1. Note current public version
  2. Install an older version on the same channel (x64 .dmg) - example: https://github.com/brave/brave-browser/releases/tag/v1.66.103
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Screenshot 2024-06-03 at 2 44 21 PM
  1. Close browser
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing. However, deltas will not be used in this case since the version is not the previous public one.
  3. Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
Screenshot 2024-06-03 at 2 45 53 PM
[30992:259:0603/144446.596141:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[30992:259:0603/144446.598397:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[30992:259:0603/144446.599465:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[30992:259:0603/144524.922981:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 7
  2. Check version is updated under brave://version
Example Example
Screenshot 2024-06-03 at 2 46 26 PM Screenshot 2024-06-03 at 2 46 33 PM
x64 (.dmg) - background update - deltas - PASSED
  1. Find out what the current and previous public versions are.
  2. Install previous public version (x64 .dmg)
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Screenshot 2024-06-03 at 3 18 36 PM
  1. Close browser
  2. Delete the following:
  • com.brave.Browser.beta folder from ~/Library/Caches
  • com.brave.Browser.beta.plist file from ~/Library/Preferences
  • Alternatively you can advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.
  1. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing.
  3. After computer restart, Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. DO NOT navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
[31881:259:0603/182027.439535:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[31881:259:0603/182027.441684:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[31881:259:0603/182027.442727:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[31881:259:0603/182034.969686:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 8
  2. Check version is updated under brave://version
Screenshot 2024-06-03 at 6 22 05 PM
  1. Confirmed delta updates:
Example Example
Screenshot 2024-06-03 at 6 20 38 PM Screenshot 2024-06-03 at 6 20 49 PM
x64 (.dmg) - background update - no deltas - PASSED
  1. Find out what the current and previous public versions are.
  2. Install an older version on the same channel (x64 .dmg) - example: https://github.com/brave/brave-browser/releases/tag/v1.66.103
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Screenshot 2024-06-03 at 3 37 13 PM
  1. Close browser
  2. Delete the following:
  • com.brave.Browser.beta folder from ~/Library/Caches
  • com.brave.Browser.beta.plist file from ~/Library/Preferences
  • Alternatively you can advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.
  1. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing. However, deltas will not be used in this case since the version is not the previous public one.
  3. After computer restart, Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. DO NOT navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
[849:259:0603/154134.593714:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[849:259:0603/154134.596564:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[849:259:0603/154134.597155:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[849:259:0603/154209.660898:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 8
  2. Check version is updated under brave://version
Screenshot 2024-06-03 at 3 42 52 PM
universal (.dmg) - on-demand update - no deltas - PASSED
  1. Note current public version
  2. Install any older version on same channel (universal .dmg) - example: https://github.com/brave/brave-browser/releases/tag/v1.67.90
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Screenshot 2024-06-03 at 3 54 09 PM
  1. Close browser
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing. Remember, deltas are generally only used when going from one public version to the next public version. However, deltas will not be used in this case since deltas are not used when going from universal --> architecture specific versions as per when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915.
  3. Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
Screenshot 2024-06-03 at 3 55 32 PM
[1346:259:0603/155422.893227:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[1346:259:0603/155422.895731:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[1346:259:0603/155422.896843:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[1346:259:0603/155502.597960:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 7
  2. Check version is updated under brave://version
Example Example
Screenshot 2024-06-03 at 3 56 04 PM Screenshot 2024-06-03 at 3 56 12 PM
universal (.dmg) - background update - no deltas - PASSED
  1. Note current public version
  2. Install any older version on same channel (universal .dmg) - example: https://github.com/brave/brave-browser/releases/tag/v1.67.90
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Screenshot 2024-06-03 at 4 19 06 PM
  1. Close browser
  2. Delete the following:
  • com.brave.Browser.beta folder from ~/Library/Caches
  • com.brave.Browser.beta.plist file from ~/Library/Preferences
  • Alternatively you can advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.
  1. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
  2. Note, if you want to check for deltas, at this point open something like Fiddler Everywhere before continuing. Will encounter when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915 if you installed from previous public universal build. (I did not do that here)
  3. After computer restart, Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. DO NOT navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
[871:259:0603/162209.403581:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[871:259:0603/162209.408169:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[871:259:0603/162209.421741:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[871:259:0603/162255.437148:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 8
  2. Check version is updated under brave://version
Screenshot 2024-06-03 at 4 23 47 PM
universal (.pkg) - on-demand update - no deltas - PASSED
  1. Note current public version
  2. Install any older version on same channel (universal .pkg) - example: https://github.com/brave/brave-browser/releases/tag/v1.67.90
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Example Example
Screenshot 2024-06-04 at 4 14 58 PM Screenshot 2024-06-04 at 4 15 37 PM
  1. Close browser
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing. Remember, deltas are generally only used when going from one public version to the next public version. However, deltas will not be used in this case since deltas are not used when going from universal --> architecture specific versions as per when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915.
  3. Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below logs before proceeding)
Example Example
Screenshot 2024-06-04 at 4 17 30 PM Screenshot 2024-06-04 at 4 17 45 PM
[8826:259:0604/161625.668664:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[8826:259:0604/161625.671297:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[8826:259:0604/161625.672505:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[8826:259:0604/161702.928948:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 7
  2. Check version is updated under brave://version
Example Example
Screenshot 2024-06-04 at 4 18 35 PM Screenshot 2024-06-04 at 4 18 42 PM
universal (.pkg) - background update - no deltas - PASSED
  1. Note current public version
  2. Install any older version on same channel (universal .pkg) - example: https://github.com/brave/brave-browser/releases/tag/v1.67.90
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Example Example
Screenshot 2024-06-04 at 4 28 26 PM Screenshot 2024-06-04 at 4 28 59 PM
  1. Close browser
  2. Delete the following:
  • com.brave.Browser.beta folder from ~/Library/Caches
  • com.brave.Browser.beta.plist file from ~/Library/Preferences
  • Alternatively you can advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.
  1. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
  2. Note, if you want to check for deltas, at this point open something like Fiddler Everywhere before continuing. Will encounter when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915 if you installed from previous public universal build. (I did not do that here)
  3. After computer restart, Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. DO NOT navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below logs before proceeding)
[9271:259:0604/192940.426231:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[9271:259:0604/192940.428426:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
[9271:259:0604/193003.415533:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:20:19 +0000, Version: 1.67.100.0)
Example Example
Screenshot 2024-06-04 at 7 30 00 PM Screenshot 2024-06-04 at 7 30 43 PM
  1. Close and restart the browser via terminal with same command as step 8
  2. Check version is updated under brave://version
Example Example
Screenshot 2024-06-04 at 7 31 48 PM Screenshot 2024-06-04 at 7 32 04 PM

Verified with

Brave | 1.67.100 Chromium: 125.0.6422.112 (Official Build) beta (arm64)
-- | --
Revision | 34fcbb6655521b55468af6c63601a8e3c5d24cd2
OS | macOS Version 14.5 (Build 23F79)

From #37788 (comment):

  • Verify that updates work as expected on Mac
arm64 (.dmg) - on-demand update - deltas - PASSED
  1. Note current and previous public versions
  2. Install previous public version (arm64 .dmg)
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Screenshot 2024-06-04 at 10 21 21 AM
  1. Close browser
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing.
  3. Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
Screenshot 2024-06-04 at 10 23 40 AM
[33730:259:0604/102318.849046:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[33730:259:0604/102318.853026:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[33730:259:0604/102318.854772:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[33730:259:0604/102323.512483:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 7
  2. Check version is updated under brave://version
Example Example
Screenshot 2024-06-04 at 10 24 00 AM Screenshot 2024-06-04 at 10 24 07 AM
  1. Confirmed delta updates:
Example Example
Screenshot 2024-06-04 at 10 29 32 AM Screenshot 2024-06-04 at 10 29 47 AM
arm64 (.dmg) - on-demand update - no deltas - PASSED
  1. Note current public version
  2. Install an older version on the same channel (arm64 .dmg) - example: https://github.com/brave/brave-browser/releases/tag/v1.66.102
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Screenshot 2024-06-04 at 10 58 15 AM
  1. Close browser
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing. However, deltas will not be used in this case since the version is not the previous public one.
  3. Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
Screenshot 2024-06-04 at 10 59 22 AM
[35206:259:0604/105838.423029:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[35206:259:0604/105838.426378:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[35206:259:0604/105838.428025:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[35206:259:0604/105906.797856:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 7
  2. Check version is updated under brave://version
Example Example
Screenshot 2024-06-04 at 10 59 41 AM Screenshot 2024-06-04 at 10 59 48 AM
arm64 (.dmg) - background update - deltas - PASSED
  1. Find out what the current and previous public versions are.
  2. Install previous public version (arm64 .dmg)
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Screenshot 2024-06-04 at 11 12 19 AM
  1. Close browser
  2. Delete the following:
  • com.brave.Browser.beta folder from ~/Library/Caches
  • com.brave.Browser.beta.plist file from ~/Library/Preferences
  • Alternatively you can advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.
  1. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing.
  3. After computer restart, Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. DO NOT navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
[1274:259:0604/111650.262313:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[1274:259:0604/111650.265944:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[1274:259:0604/111650.266587:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[1274:259:0604/111654.216340:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 8
  2. Check version is updated under brave://version
Screenshot 2024-06-04 at 11 46 53 AM
  1. Confirmed delta updates:
Example Example
Screenshot 2024-06-04 at 11 17 00 AM Screenshot 2024-06-04 at 11 17 15 AM
arm64 (.dmg) - background update - no deltas - PASSED
  1. Find out what the current and previous public versions are.
  2. Install an older version on the same channel (x64 .dmg) - example: https://github.com/brave/brave-browser/releases/tag/v1.66.102
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)

Screenshot 2024-06-04 at 1 25 46 PM

  1. Close browser
  2. Delete the following:
  • com.brave.Browser.beta folder from ~/Library/Caches
  • com.brave.Browser.beta.plist file from ~/Library/Preferences
  • Alternatively you can advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.
  1. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing. However, deltas will not be used in this case since the version is not the previous public one.
  3. After computer restart, Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. DO NOT navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
[3207:259:0604/162622.217558:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[3207:259:0604/162622.220272:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[3207:259:0604/162622.221523:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[3207:259:0604/162650.514574:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 8
  2. Check version is updated under brave://version

Screenshot 2024-06-04 at 4 27 56 PM

universal (.dmg) - on-demand update - no deltas - PASSED
  1. Note current public version
  2. Install any older version on same channel (universal .dmg) - example: https://github.com/brave/brave-browser/releases/tag/v1.67.90
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)

Screenshot 2024-06-04 at 2 57 41 PM

  1. Close browser
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing. Remember, deltas are generally only used when going from one public version to the next public version. However, deltas will not be used in this case since deltas are not used when going from universal --> architecture specific versions as per when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915.
  3. Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)

Screenshot 2024-06-04 at 2 58 59 PM

[3525:259:0604/145757.791906:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[3525:259:0604/145757.795320:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[3525:259:0604/145757.797178:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[3525:259:0604/145823.776217:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 7
  2. Check version is updated under brave://version
Example Example
Screenshot 2024-06-04 at 2 59 15 PM Screenshot 2024-06-04 at 2 59 23 PM
universal (.dmg) - background update - no deltas - PASSED
  1. Note current public version
  2. Install any older version on same channel (universal .dmg) - example: https://github.com/brave/brave-browser/releases/tag/v1.67.90
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)

Screenshot 2024-06-04 at 4 02 20 PM

  1. Close browser
  2. Delete the following:
  • com.brave.Browser.beta folder from ~/Library/Caches
  • com.brave.Browser.beta.plist file from ~/Library/Preferences
  • Alternatively you can advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.
  1. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
  2. Note, if you want to check for deltas, at this point open something like Fiddler Everywhere before continuing. Will encounter when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915 if you installed from previous public universal build. (I did not do that here)
  3. After computer restart, Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. DO NOT navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below before proceeding)
[952:259:0604/160441.147101:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[952:259:0604/160441.150761:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[952:259:0604/160441.151351:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
[952:259:0604/160509.027048:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Thu, 30 May 2024 11:27:03 +0000, Version: 1.67.100.0)
  1. Close and restart the browser via terminal with same command as step 8
  2. Check version is updated under brave://version

Screenshot 2024-06-04 at 4 05 32 PM

universal (.pkg) - on-demand update - no deltas - PASSED
  1. Note current public version
  2. Install any older version on same channel (universal .pkg) - example: https://github.com/brave/brave-browser/releases/tag/v1.67.90
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Example Example
Screenshot 2024-06-04 at 4 38 50 PM Screenshot 2024-06-04 at 4 40 13 PM
  1. Close browser
  2. Note, if you want to check deltas, at this point open something like Fiddler Everywhere before continuing. Remember, deltas are generally only used when going from one public version to the next public version. However, deltas will not be used in this case since deltas are not used when going from universal --> architecture specific versions as per when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915.
  3. Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. Navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below logs before proceeding)
Example Example
Screenshot 2024-06-04 at 4 41 35 PM Screenshot 2024-06-04 at 4 41 47 PM
[1392:259:0604/164044.044830:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[1392:259:0604/164044.048755:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Tue, 04 Jun 2024 20:32:17 +0000, Version: 1.67.105.0)
[1392:259:0604/164044.050080:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 04 Jun 2024 20:32:17 +0000, Version: 1.67.105.0)
[1392:259:0604/164111.081030:INFO:sparkle_glue.mm(386)] brave update: will install update on quit with AppcastItem(Date: Tue, 04 Jun 2024 20:32:17 +0000, Version: 1.67.105.0)
  1. Close and restart the browser via terminal with same command as step 7
  2. Check version is updated under brave://version
Example Example
Screenshot 2024-06-04 at 4 42 09 PM Screenshot 2024-06-04 at 4 42 15 PM
universal (.pkg) - background update - no deltas - PASSED
  1. Note current public version
  2. Install any older version on same channel (universal .pkg) - example: https://github.com/brave/brave-browser/releases/tag/v1.67.90
  3. Launch via terminal as follows: /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --update-feed-url=https://updates.brave.com/sparkle/Brave-Browser/nothanks/appcast.xml (this is so you don't pick up the latest version you noted in an earlier step)
  4. Watch logs, confirm no update found (can also visit brave://settings/help but be sure to close this tab prior to closing the browser)
Example Example
Screenshot 2024-06-04 at 4 47 20 PM Screenshot 2024-06-04 at 4 49 20 PM
  1. Close browser
  2. Delete the following:
  • com.brave.Browser.beta folder from ~/Library/Caches
  • com.brave.Browser.beta.plist file from ~/Library/Preferences
  • Alternatively you can advance your computer clock ~4 hours, I am fairly certain deleting at least one of the above files removes the timer check for background updates.
  1. Restart your computer if you deleted files (if you just advanced computer clock this step isn't necessary)
  2. Note, if you want to check for deltas, at this point open something like Fiddler Everywhere before continuing. Will encounter when updating from universal binary to architecture specific version, the delta update fails and falls back to full installer - follow up to 27398 #28915 if you installed from previous public universal build. (I did not do that here)
  3. After computer restart, Relaunch with /Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr
  4. DO NOT navigate to brave://settings/help
  5. Watch the logs and see that an update is found (be sure you have all of the below logs before proceeding)
[1698:259:0604/194955.367495:INFO:sparkle_glue.mm(323)] brave update: did finish loading appcast
[1698:259:0604/194955.370335:INFO:sparkle_glue.mm(329)] brave update: did find valid update with AppcastItem(Date: Tue, 04 Jun 2024 20:32:17 +0000, Version: 1.67.105.0)
[1698:259:0604/195027.673931:INFO:sparkle_glue.mm(350)] brave update: willDownloadUpdate with AppcastItem(Date: Tue, 04 Jun 2024 20:32:17 +0000, Version: 1.67.105.0)
Example Example
Screenshot 2024-06-04 at 7 50 26 PM Screenshot 2024-06-04 at 7 50 56 PM
  1. Close and restart the browser via terminal with same command as step 8
  2. Check version is updated under brave://version
Example Example
Screenshot 2024-06-04 at 7 51 47 PM Screenshot 2024-06-04 at 7 52 02 PM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 3, 2024

Verification PASSED using

Brave	1.67.104 Chromium: 126.0.6478.26 (Official Build) beta (64-bit) 
Revision	9a4d1cb2f47a60953416cd3f39f0520e4dd4cf0e
OS	Linux

Filed:

Encountered:

Verify that browser colors, spacing, UI look correct (tabs, tab groups, tab search, sidebar, NTB, etc.) - PASSED
  1. Colors, spacing, UI : covered testing while verifying settings comparison below
  2. NTP : covered testing while verifying NTP functionality below
  3. Tabs : covered testing while verifying tab hover cards below

Tab groups:

  • Confirmed that users can create tab groups
  • Confirmed that user can drag and drop the tabs into the created tab groups
  • Confirmed that user can move the tab group to new window
example example example
image image image

Tab search:

  • Confirmed that Tab search icon is aligned correctly and click on it shows the list of Tabs
  • Confirmed that users can search any tab via Tab search modal
Example Example
image image

Sidebar:

  • Confirmed that Sidebar items looks correctly on the sidebar
  • Confirmed that click on each item on sidebar works as expected

image

Verify bookmarks functionality including bookmarks sidebar panel - PASSED
  • Confirmed that bookmarks can be added via NTP, Import bookmarks and settings via brave://settings/getStarted and Import bookmarks via bookmarks manager
  • Confirmed that added bookmarks can be viewed/opened/edited/deleted
  • Confirmed that bookmarks added in other devices are synced across all the devices in a sync chain
  • Confirmed that synched bookmarks can be viewed/opened/edited/deleted
  • Confirmed that imported/added/synched bookmarks are shown under bookmarks on sidebar panel
  • Confirmed that bookmarks can be viewed/edited/deleted/undo on sidebar panel
  • Confirmed that bookmarks looks good in both visual view and compact view
example example example example example example example
image image image image image image image
Verify that Safety Check is still hidden in brave://settings (and also that Safety Hub does not appear) - PASSED

image

Verify NTP functionality - PASSED
  • Enabled NTP search widget in Brave Beta via brave://flags
  • Search suggestions are shown when enabled Improve search suggestions in brave://settings/search
  • Mouse hover on the Customize list does not change the text color to white. (However this was reproduced in 1.68.x )
  • Click on Customize list in the search dropdown opens up the NTP dashboard settings with NTP search engine options
  • Change the NTP search engine option via NTP dashboard and confirmed that the selected search engine is shown in the search dropdown
  • Updated favicon for selected search engine is shown - Failed Search engine favicon should be updated when a different search engine is selected via customize dashboard #38778
  • Confirmed user can perform NTP search using the custom search engine
  • Confirmed that NTP search widget is not shown on the NTP when the show search engine toggle is turned off via NTP dashboard settings search menu
  • Confirmed that the NTP search is enabled even when the Brave news is turned on
  • Confirmed that enable/disable NTP widgets are working as expected
example example example example example example example example example
image image image image image image image image image
Verify brave://settings toolbar functionality - PASSED
  • Covered the testing under settings comparison section
1.67.104 Chromium: 126.0.6478.26 1.66.115 Chromium: 125.0.6422.112
image image
Verify all functionality related to tab "hover cards" - PASSED
  • Confirmed that Tab shapes are shown as expected in Card tab type hover mode
  • Confirmed that Tab shapes are shown as expected in Card with preview tab type hover mode
  • Confirmed that Tab shapes are shown as expected in Tooltip tab type hover mode
  • Confirmed that Tab hover types works as expected on vertical tab orientation
Card Card with preview Tooltip vertical tab
image image image image
Verify download widget functionality - PASSED
  1. Confirmed Remove from list and Keep dangerous file buttons are shown under brave://download widget
  2. Confirmed Pause, Cancel, Retry options works as expected
  3. Confirmed that click on Open in folder option via 3 dot menu opens up download file folder path as expected
  4. Confirmed that click Clear all option via 3 dot menu removes the download history from brave://downloads widget as expected
Step 1 Step 2a Step 2b Step 2c step 4
image image image image image
Verify that brave://welcome shows as expected on first-run - PASSED
  • Confirmed that brave://welcome looks good on browser first launch
  • Confirmed that controls/buttons on each slide works as expected
screen 1 screen 2 screen 3 scree 4 screen 5
image image image image image
Verify that sync continues to work as expected - PASSED
  • Verified the sync functionality in general and it works fine without any issues
  • When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices
  • Confirmed the bookmarks synched across all the devices in a sync chain
  • Confirmed that bookmarks added before after the sync chain are synched across all the devices in a sync chain
  • When 2 devices are in a sync chain, remove a device resets the sync chain
  • Confirmed that bookmarks, passwords, extensions, reading list, Saved tab groups, history, open tabs, address, email, phone number synched across all the devices in a sync chain
  • Confirmed that remove a bookmark from device 1 in sync chain removes the bookmark from the other devices in a sync chain
Example Example Example Example
image image image image
Verify that hamburger menu has correct/expected entries/ordering in regular and private browsers - PASSED

1. Regular window:

  • The settings menu Password and autofill is shown before the History menu, the old settings Password Manager is included inside the Password and autofill menu
1.67.104 Chromium: 126.0.6478.26 1.66.115 Chromium: 125.0.6422.112
image image
image image
  • Bookmarks is renamed as Bookmarks and lists
  • bookmarks submenus are included inside the Bookmarks and lists menu
  • Additionally Show all Bookmarks is shown
  • Additionally Reading list is shown
1.67.104 Chromium: 126.0.6478.26 1.66.115 Chromium: 125.0.6422.112
image image
image image
  • A new settings Translate is added below the Print menu and Find menu is renamed as Find and edit and find and edit sub menus are included inside the Find and edit menu
  • A new settings Save and share is added below the Find and edit menu
1.67.104 Chromium: 126.0.6478.26 1.66.115 Chromium: 125.0.6422.112
image image

2. Private window:

  • Private window hamburger menu items are same as regular windows menu items (except Brave VPN and History, which is expected)

image

3. Tor window:

  • Tor window hamburger menu items are same as regular windows menu items (except New tor connection for this site and History, which is expected)

image

4. Guest window:

  • The guest windows hamburger menu settings are same as old (CR125) settings, just the new settings are Translate, Find and edit and Save and share are added
Regular window Private window Tor window Guest window
image image image image

Settings comparison

  • The following menu items are added via Hamburger menu
    1. The bookmarks settings is renamed as Bookmarks and lists
    2. The Password and autofill settings is added, click on it shows the following menu items
      • Password Manager
      • Payment methods
      • Addresses and more
    3. Show all bookmarks new setting is added via Bookmarks and lists settings menu
    4. Reading list new setting is added via Bookmarks and lists settings menu
1.67.104 Chromium: 126.0.6478.26 1.66.115 Chromium: 125.0.6422.112
image image
image image
image image
  • A new settings Show pinned tabs in all windows is added via brave://settings/appearance in only 1.68.69. This setting by default is disabled. However this setting is not shown in 1.67.104
1.67.104 Chromium: 126.0.6478.26 1.68.69 Chromium: 126.0.6478.26
image image
  • Clear browsing data is renamed as Delete browsing data as part of CR 126.
Example Example
image image
  • The content settings Automatically remove permissions from unused sites is added as part of CR 126, looks like useful settings.

image

@kjozwiak
Copy link
Member

kjozwiak commented Jun 6, 2024

Labelling as QA/No & release-notes/exclude in favour of #38848 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants