-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 126.0.6478.17 to Chromium 126.0.6478.26 #38675
Comments
The above requires |
Quick overview of the work remaining re: affected areas due to Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #37788 (comment):
Platforms that still need to check/verify the affected areas due to
|
Verification
|
Example | Example |
---|---|
Sidebar:
- Confirmed that Sidebar items looks correctly on the sidebar
- Confirmed that click on each item on sidebar works as expected
- Bookmarks edit buttons are misaligned. Logged an issue Buttons are overlapping on the edit bookmarks modal via bookmarks sidebar panel #38639
Example | Example | Example |
---|---|---|
Verify bookmarks functionality including bookmarks sidebar panel - PASSED
- Confirmed that bookmarks can be added via NTP,
Import bookmarks and settings
via brave://settings/getStarted andImport bookmarks
via bookmarks manager - Confirmed that added bookmarks can be viewed/opened/edited/deleted
- Confirmed that bookmarks added in other devices are synced across all the devices in a sync chain
- Confirmed that synched bookmarks can be viewed/opened/edited/deleted
- Confirmed that imported/added/synched bookmarks are shown under bookmarks on sidebar panel
- Confirmed that bookmarks can be viewed/edited/deleted/undo on sidebar panel
- Confirmed that bookmarks looks good in both visual view and compact view
Example | Example | Example |
---|---|---|
Verify that Safety Check is still hidden in brave://settings (and also that Safety Hub does not appear) - PASSED
- Confirmed that safety check settings is still not added via brave://settings on Brave
Verify NTP functionality - PASSED
- Confirmed that the NTP search is available via
brave://flags
- Encountered ssue Search suggestions are not shown in the NTP search box even when the search suggestions are enabled #38610
- Click on
Customize list
in the search dropdown opens up the NTP dashboard settings with NTP search engine options - Change the NTP search engine option via NTP dashboard and confirmed that the selected search engine is shown in the search dropdown
- Confirmed user can perform NTP search using the custom search engine
- Confirmed that NTP search widget is not shown on the NTP when the
show search engine
toggle is turned off via NTP dashboard settings search menu - Confirmed that the NTP search is enabled even when the Brave news is turned on
- Confirmed that enable/disable NTP widgets are working as expected
Example | Example | Example | Example |
---|---|---|---|
Verify brave://settings toolbar functionality - PASSED
- Covered the testing under
settings comparison
section - Logged a follow up issue [CR 126] In brave://history the text
Your browsing history appears here
is positioned up same as chrome 126 #38638
Verify all functionality related to tab "hover cards" - PASSED
Tab shapes:
- Confirmed that Tab shapes are shown as expected in
Card
tab type hover mode - Confirmed that Tab shapes are shown as expected in
Card with preview
tab type hover mode - Confirmed that Tab shapes are shown as expected in
Tooltip
tab type hover mode - Confirmed that Tab hover types works as expected on vertical tab orientation
Card | Card with preview | Tooltip | vertical tab |
---|---|---|---|
Verify download widget functionality - PASSED
- Confirmed that
Open in folder
andDelete from history
buttons are replaced by options via 3 dot menu under brave://download widget
-
Confirmed that click on
Open in folder
option via 3 dot menu opens up download file folder path as expected -
Confirmed that click on
Delete from history
option via 3 dot menu removes the download history from brave://downloads widget as expected -
Confirmed that user can find
Pause
andResume
options via 3 dot menu -
Confirmed
Pause
,Resume
andCancel
options works as expected
Verify that brave://welcome shows as expected on first-run - PASSED
- Confirmed that brave://welcome looks good on browser first launch
- Confirmed that controls/buttons on each slide works as expected
Example | Example | Example | Example |
---|---|---|---|
Verify that sync continues to work as expected - PASSED
- Verified the sync functionality in general and it works fine without any issues
- When 3 devices are in sync chain, remove a device from the sync chain doesn't reset the sync chain, sync chain still exists between two devices
- Confirmed the bookmarks synched across all the devices in a sync chain
- Confirmed that bookmarks added before after the sync chain are synched across all the devices in a sync chain
- When 2 devices are in a sync chain, remove a device resets the sync chain
- Confirmed that bookmarks, passwords, extensions,
reading list
,Saved tab groups
, history, open tabs, address, email, phone number synched across all the devices in a sync chain - Confirmed that remove a bookmark from device 1 in sync chain removes the bookmark from the other devices in a sync chain
Example | Example | Example |
---|---|---|
Verify that hamburger menu has correct/expected entries/ordering in regular and private browsers - PASSED
1. Regular window:
- The settings menu
Password and autofill
is shown before theHistory
menu, the old settingsPassword Manager
is included inside thePassword and autofill
menu
1.67.104 Chromium: 126.0.6478.26 |
1.66.118 Chromium: 125.0.6422.147 |
---|---|
Bookmarks
is renamed asBookmarks and lists
and bookmarks submenus are included inside theBookmarks and lists
menu
1.67.104 Chromium: 126.0.6478.26 |
1.66.118 Chromium: 125.0.6422.147 |
---|---|
- A new settings
Translate
is added below thePrint
menu andFind
menu is renamed asFind and edit
and find and edit sub menus are included inside theFind and edit
menu - A new settings
Save and share
is added below theFind and edit
menu
1.67.104 Chromium: 126.0.6478.26 |
1.66.118 Chromium: 125.0.6422.147 |
---|---|
2. Private window:
- Private window hamburger menu items are same as regular windows menu items (except Brave VPN and History, which is expected)
3. Tor window:
- Tor window hamburger menu items are same as regular windows menu items (except
New tor connection for this site
and History, which is expected)
4. Guest window:
- The guest windows hamburger menu settings are same as old (CR125) settings, just the new settings are
Translate
,Find and edit
andSave and share
are added
Regular window | Private window | Tor window | Guest window |
---|---|---|---|
Settings comparison - PASSED
- The following menu items are added via Hamburger menu
- The
bookmarks
settings is renamed asBookmarks and lists
- The
Password and autofill
settings is added, click on it shows the following menu itemsPassword Manager
Payment methods
Addresses and more
Show all bookmarks
new setting is added viaBookmarks and lists
settings menuReading list
new setting is added viaBookmarks and lists
settings menu
- The
Example | Example | Example |
---|---|---|
Clear browsing data
is renamed asDelete browsing data
as part of CR 126.
Example | Example |
---|---|
- The content settings
Automatically remove permissions from unused sites
is added as part of CR 126, looks like useful settings.
Brave startup calls - PASSED
- Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
- Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile
Verified with
From #37788 (comment):
x64 (.dmg) - on-demand update - deltas - PASSED
x64 (.dmg) - on-demand update - no deltas - PASSED
x64 (.dmg) - background update - deltas - PASSED
x64 (.dmg) - background update - no deltas - PASSED
universal (.dmg) - on-demand update - no deltas - PASSED
universal (.dmg) - background update - no deltas - PASSED
universal (.pkg) - on-demand update - no deltas - PASSED
universal (.pkg) - background update - no deltas - PASSED
Verified with
From #37788 (comment):
arm64 (.dmg) - on-demand update - deltas - PASSED
arm64 (.dmg) - on-demand update - no deltas - PASSED
arm64 (.dmg) - background update - deltas - PASSED
arm64 (.dmg) - background update - no deltas - PASSED
universal (.dmg) - on-demand update - no deltas - PASSED
universal (.dmg) - background update - no deltas - PASSED
universal (.pkg) - on-demand update - no deltas - PASSED
universal (.pkg) - background update - no deltas - PASSED
|
Verification
Filed: Encountered:
Verify that browser colors, spacing, UI look correct (tabs, tab groups, tab search, sidebar, NTB, etc.) - PASSED
Tab groups:
Tab search:
Sidebar:
Verify bookmarks functionality including bookmarks sidebar panel - PASSED
Verify that Safety Check is still hidden in brave://settings (and also that Safety Hub does not appear) - PASSEDVerify NTP functionality - PASSED
Verify brave://settings toolbar functionality - PASSED
Verify all functionality related to tab "hover cards" - PASSED
Verify download widget functionality - PASSED
Verify that brave://welcome shows as expected on first-run - PASSED
Verify that sync continues to work as expected - PASSED
Verify that hamburger menu has correct/expected entries/ordering in regular and private browsers - PASSED1. Regular window:
2. Private window:
3. Tor window:
4. Guest window:
Settings comparison
|
Labelling as |
Minor Chromium bump
https://chromium.googlesource.com/chromium/src/+log/126.0.6478.17..126.0.6478.26?pretty=fuller&n=10000
QA tests
Minor Chromium bump
The text was updated successfully, but these errors were encountered: