Upgrade from Chromium 123 to Chromium 124 #36346

mkarolin · 2024-02-23T17:35:09Z

Upgrade from Chromium 123 to Chromium 124

https://chromium.googlesource.com/chromium/src/+log/123.0.6312.4...124.0.6315.0/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

Site settings page is not missing any permissions.
Verify that navigator.brave.isBrave() works (from the DevTools console).
Shields functionality to disable scripts and enable individual scripts works
Clear browsing data works on Leo chat data
Avatar toolbar button looks/works as expected
Settings -> Web3 -> Wallet Networks -> Add: search field works correctly
Shields and VPN panels buttons work correctly to show the panel
Dropping multiple urls or files onto the tabstrip works (regular + vertical)
Ad notifications look correct (no layout anomalies)
Bookmarks and reading list colors look ok (there are some changes in cr124)
SpeedReader icon/button works correctly

iOS Affected areas:

Bookmarks management (adding, editing, deleting) works as expected

Android Affected areas:

Wallet (double check there is no regression)
Bottom toolbar (double check there is no regression especially on scroll)
Sync (double check QR code works)
Search widget (double check it works as expected)
Autofill address (double check no regression there)

The text was updated successfully, but these errors were encountered:

MadhaviSeelam · 2024-04-09T16:02:38Z

Verification PASSED using

Brave | 1.66.70 Chromium: 124.0.6367.29 (Official Build) nightly (64-bit)
-- | --
Revision | 7f64bd490824f00eff78cc4c4688371b28e09031
OS | Windows 11 Version 23H2 (Build 22631.3374)

Filed following bugs:
#37434
#37438
#37442
#37444
#37450

Site settings page is not missing any permissions - PASSED

Confirmed permissions show and expiration work as expected as below

until I close this site
for 24 hours
for 1 week
forever

example	example	example	example	example	example

Verify that `navigator.brave.isBrave()` works (from the DevTools console) - PASSED

Shields functionality to disable scripts and enable individual scripts works-PASSED

navigated to Blizzard.com
confirmed Block scripts toggle on/off for Per-site in Shields panel and in global defaults page (brave://settings/shields) worked as expected

example	example	example	example	example

Clear browsing data works on Leo chat data - PASSED

Note: `Clear browsing data` doesn't work as there is no option in `brave://settings/clearBrowserData`. It should be `Clear Leo Data` from `brave://settings/leo-assistant` and was confirmed by @mkarolin

Confirmed previous Leo chat was removed/not shown in a tab when clicked on Clear Leo Data in brave://settings/leo-assistant. Opt-in page shown when tab was closed and reloaded the page and queried with Leo.

2024-04-10_10h47_38.mp4

Avatar toolbar button looks/works as expected - PASSED

Imported profiles via onboarding and switched profiles
Added new profile via Hamburger menu >> More tools >> Add new profile
Added new profile via Profile manager

Confirmed Avatar toolbar button worked as expected

example	example	example	example

Settings -> Web3 -> Wallet Networks -> Add: search field works correctly - PASSED

Confirmed able to search and Add network via Add: Search Network field in brave://settings/wallet/networks

example	example	example	example

Shields and VPN panels buttons work correctly to show the panel - PASSED

Shields panel

Confirmed Shields Up/Down worked as expected
Confirmed when turned off Show the number of blocked items on the Shields icon toggle, Shields icon hides blocked items
Global defaults & Filter lists links work as expected
Advance Controls panel collapse/expand as expected

example	example	example	example

VPN

New subscription
Connected and Disconnected successfully
via VPN Panel - Passed
via hamburger menu - Passed
via Network Settings panel - Passed

Note: Below issues exist in 1.66.69 Chromium: 123.0.6312.105.

Connect/Disconnect issues via Network settings may not be working correctly
Could not refresh after session expiration

example	example	example	example

Dropping multiple urls or files onto the tabstrip works (regular + vertical) - PASSED

Confirmed able to add files/urls in vertical view mode
Confirmed able to add files/urls to horizontal tab strip

example	example	example	example

Ad notifications look correct (no layout anomalies) - PASSED

example	example

Bookmarks and reading list colors look ok (there are some changes in cr124) - PASSED

_Bookmarks - PASSED

Sidebar

Dark theme	Light theme

Bookmarks dialog
Add bookmark/Remove/Edit bookmarks
Filed bug for folder field highlighted in red when hovered over in the Bookmarks dialog #37434

Dark theme	Light theme

Bookmarks bar

Dark theme	Light theme

All bookmarks

Dark theme	Light theme

brave://bookmarks

Dark theme	Light theme

Reading List - PASSED

Dark theme	Light theme

SpeedReader icon/button works correctly - PASSED

Clean profile 1.64.x CR124 build
Restarted the browser
Visited time.com
Clicked headline article https://time.com/6965043/2024-solar-eclipse-cleveland/
Clicked on the Turn on Speedreader icon in the URL bar
Confirmed the article rendered in Speedreader mode
Confirmed when turned off Speedreader icon, original article is shown
Verified rest of the functionalities work as expected (Text to speech, Leo & appearance settings)
Filed [CR124] Always use Speedreader... toggles show red when hovered in the Tune Speedreader dialog #37438 for toggles in Tune Speedreader dialog highlighted red when hovered over.

example	example	example

hffvld · 2024-04-09T23:28:42Z

Verified on iPhone 14using version(s):

Device/OS: iPhone 14 / iOS 17.5
Brave build: 1.66 (70)
BraveCore: 1.66.70 (124.0.6367.29)

Bookmarks management (adding, editing, deleting) works as expected

ACTUAL RESULTS:

Verified that creating, editing, deleting, importing, and exporting bookmarks is working

1	2	3	4

hffvld · 2024-04-10T00:54:17Z

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP21.240305.005 release-keys
Brave build: 1.66.70
Chromium: 124.0.6367.29 (Official Build) canary (64-bit)

Wallet (double check there is no regression)

ACTUAL RESULTS:

Verified that creating new and restoring existing Brave Wallet is working
Verified that Reset and clear wallet data is working

1	2

Bottom toolbar (double check there is no regression, especially on scroll)

ACTUAL RESULTS:

Verified that the Bottom toolbar is working
Verified that scrolling is working and the Search toolbar is not disappearing

1	2	3

2024-04-09_17-50-57.mp4

Sync (double check QR code works)

ACTUAL RESULTS:

Verified that the new Sync chain can be created, and other devices can join using Code Words or QR Code
Verified that test device can join existing Sync chain using Code Words or QR Code
Verified that any device or Sync chain can be deleted
Verified that Sync is working (History, Recent Tabs, Passwords, Bookmarks, etc.)

1	2	3	4

Search widget (double check it works as expected)

ACTUAL RESULTS:

Verified that the search widget is working: regular search, voice search and search in Private tab
Verified the same by setting different search engines

1	2	3

Autofill address (double check no regression there)

ACTUAL RESULTS:

Verified that Password manager autofill is working by default in a Standard tab only. In the Private tab, you must open Password Manager manually and pick saved login credentials.
Verified that Name and Address autofill works in the Standard and Private tabs. Autofill is not shown in the Private tab if the toggle for Autofill in private tabs is OFF in the settings.

1	2	3	4	5

stephendonner · 2024-04-10T19:41:20Z

Verification `PASSED` using

Brave | 1.66.74 Chromium: 124.0.6367.29 (Official Build) nightly (64-bit)
-- | --
Revision | 43c41a798003efcabf0d292cb2a5efdcc633857b
OS | Windows 10 Version 22H2 (Build 19045.4291)

Get started ✅

`1.66.74`	`1.66.57`

No new settings

Appearance ✅

Appearance / Toolbar ✅

`1.66.74`	`1.66.57`

No new settings

Tabs / Sidebar ✅

`1.66.74`	`1.66.57`

No new settings

Content ✅

`1.66.74`	`1.66.57`

No new settings

Shields ✅

`1.66.74`	`1.66.57`

No new settings

NOTE: per #36859, settings have been moved around

NOTE: Block fingerprinting preference is now an On/Off toggle

Privacy and security ✅

`1.66.74`	`1.66.57`

No new settings

NOTE: per #36859, settings have been moved around

NOTE: WebRTC IP handling policy moved below Clear browsing data

Tor windows ✅

`1.66.74`	`1.66.57`

No new settings

#36933: Automatically redirect .onion sites has been removed

Web3 ✅

Wallet ✅

`1.66.74`	`1.66.57`

No new settings

IPFS / Web3 domains ✅

`1.66.74`	`1.66.57`

No new settings

Leo ✅

`1.66.74`	`1.66.57`

No new settings

Sync ✅

`1.66.74`	`1.66.57`

No new settings

Search engine ✅

`1.66.74`	`1.66.57`

No new changes

Extensions ✅

`1.66.74`	`1.66.57`

No new changes

Autofill and passwords ✅

`1.66.74`	`1.66.57`

No new changes

Languages ✅

`1.66.74`	`1.66.57`

No new changes

Downloads ✅

`1.66.74`	`1.66.57`

No new settings

Help tips ✅

`1.66.74`	`1.66.57`

No new settings

System ✅

`1.66.74`	`1.66.57`

No new settings

Reset settings ✅

`1.66.74`	`1.66.57`

No new settings

---

Encountered/logged:

kjozwiak · 2024-04-11T20:04:19Z

The above requires 1.65.110 or higher for 1.65.x verification 👍

LaurenWags · 2024-04-12T14:58:19Z

Verified with

Brave	1.65.110 Chromium: 124.0.6367.29 (Official Build) (x86_64) 
Revision	6271fdd3c799c0db71c1e6ca8c83888a7bbbfbd2
OS	macOS Version 13.6.6 (Build 22G630)

Encountered #37515 and #37517 while testing.

Site settings page is not missing any permissions - PASSED

Confirmed site settings page (accessed via "tune" icon in URL bar) displays as expected.
Compared site settings page on 1.65.110 Chromium: 124.0.6367.29 to 1.64.122 Chromium: 123.0.6312.122:

Confirmed no permissions were missing.

1.64.122	1.65.110

Spot checked that if permissions were updated, they were reflected on this page.

Example	Example

Spot checked that if a site uses cookies, they are displayed when clicking on "Cookies and Site Data" from site settings page.

Example	Example

Verify that `navigator.brave.isBrave()` works (from the DevTools console) - PASSED

Confirmed returned the same as 1.64.122 Chromium: 123.0.6312.122.
Also confirmed result from visiting https://jsbin.com/sexawix/edit?html,js,console is the same as in 1.64.122 Chromium: 123.0.6312.122.

1.64.122	1.65.110

Shields functionality to disable scripts and enable individual scripts works - PASSED

navigated to Blizzard.com
confirmed Block scripts toggle on/off per-site in Shields panel worked as expected
confirmed able to "Allow" individual scripts from panel once blocked

example	example	example	example

Using a fresh profile (not the one from above), confirmed Block scripts toggle on/off in global defaults page (brave://settings/shields) worked as expected
confirmed able to "Allow" individual scripts from panel once blocked

example	example	example	example

Clear browsing data works on Leo chat data - PASSED

Note: Clear browsing data doesn't work as there is no option in brave://settings/clearBrowserData. It should be Clear Leo Data from brave://settings/leo-assistant and was confirmed by Max

Confirmed previous Leo chat was removed/not shown in a tab when clicked on Clear Leo Data in brave://settings/leo-assistant. Opt-in page shown when tab was closed and reloaded the page and queried with Leo.

example	example	example	example	example

Avatar toolbar button looks/works as expected - PASSED

Imported profiles via onboarding and switched profiles
Added new profile via Hamburger menu >> More tools >> Add new profile
Added new profile via Profile manager

Confirmed Avatar toolbar button worked as expected

example	example

Settings -> Web3 -> Wallet Networks -> Add: search field works correctly - PASSED

Confirmed able to search and Add network via Add: Search Network field in brave://settings/wallet/networks
Confirm network added displays under brave://wallet/crypto/portfolio/assets

example	example	example	example	example

Shields and VPN panels buttons work correctly to show the panel - PASSED

Shields panel

Confirmed Shields Up/Down worked as expected
Confirmed when turned off Show the number of blocked items on the Shields icon toggle, Shields icon hides blocked items
Global defaults & Filter lists links work as expected
Advance Controls panel collapse/expand as expected

example	example	example	example	example

VPN

New subscription
Connected and Disconnected successfully
- via VPN Panel - Passed
- via hamburger menu - Passed
- via Network Settings panel - Passed
Confirmed able to access VPN settings via VPN Panel (gear icon)
Confirmed able to change region via VPN Panel

example	example	example	example	example	example

Dropping multiple urls or files onto the tab strip works (regular + vertical) - PASSED

Confirmed able to drop files/urls on tab strip in horizontal view mode
Confirmed able to drop files/urls on tab strip in vertical view mode

example	example	example	example

Ad notifications look correct (no layout anomalies) - PASSED

System Notifications	Custom Notifications

Brave	1.65.112 Chromium: 124.0.6367.29 (Official Build) (x86_64) 
Revision	1ccdfe627ad458201908007edf699da1f3bfc02b
OS	macOS Version 13.6.6 (Build 22G630)

Bookmarks and reading list colors look ok - PASSED

Bookmarks

Sidebar

Dark theme	Light theme

Bookmarks dialog
Add bookmark/Remove/Edit bookmarks

Dark theme	Light theme

Bookmarks bar

Dark theme	Light theme

All bookmarks

Dark theme	Light theme

brave://bookmarks

Dark theme	Light theme

Reading List

Dark theme	Light theme

SpeedReader icon/button works correctly - PASSED

Clean profile 1.65.x RC build
Restarted the browser
Visited time.com
Clicked headline article https://time.com/6965325/dua-lipa-interview-time100-2024/
Clicked on the Turn on Speedreader icon in the URL bar
Confirmed the article rendered in Speedreader mode
Confirmed when turned off Speedreader icon, original article is shown
Verified rest of the functionalities work as expected (Text to speech, Leo & appearance settings)

example	example	example	example

stephendonner · 2024-04-12T16:19:40Z

Verification `PASSED` using

Brave	1.65.110 Chromium: 124.0.6367.29 (Official Build) (64-bit) 
Revision	6271fdd3c799c0db71c1e6ca8c83888a7bbbfbd2
OS	Linux

Site settings page is not missing permissions - PASSED

`1.64.122`	`1.65.110`

Spot-checked that if permissions were updated, they were reflected on this page.

Example	Example	Example

Spot-checked that if a site uses cookies, they are displayed when clicking on Cookies and Site Data from the site settings page.

Example | Example
--- | --- | ---

Verify that navigator.brave.isBrave() works (from the DevTools console) - PASSED

Shields functionality to disable scripts and enable individual scripts works - PASSED

example	example	example	example	example	example	example

Clear browsing data works on Leo chat data - PASSED

example	example	example	example	example

Avatar toolbar button looks/works as expected - PASSED

example	example	example	example	example

Settings -> Web3 -> Wallet Networks -> Add: search field works correctly - PASSED

example	example	example	example	example	example	example

Shields and VPN panels buttons work correctly to show the panel - PASSED

`Shields`

example	example	example

`VPN`

Unavailable on `linux`.

Dropping multiple urls or files onto the tabstrip works (regular + vertical) - PASSED

example	example	example	example	example	example

Ad notifications look correct (no layout anomalies) - SKIPPING for now due to VM

Bookmarks and reading list colors look ok (there are some changes in cr124) - PASSED

example	example	example

SpeedReader icon/button works correctly - PASSED

example	example	example	example	example

Encountered:

modals no longer have Brave colors/style #37515

kjozwiak · 2024-04-16T05:39:24Z

Labelling as QA/No & release-notes/exclude in favour of #37552.

Uni-verse · 2024-04-17T00:21:55Z

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.65.113 Chromium: 124.0.6367.60 (Official Build) (64-bit) 
Revision	c1a6c6e73c1f2f1e5bf00a6f0d42065219845887
OS	Android 13; Build/TP1A.220624.014; 33; REL

Wallet

Performed a quick spot check for Wallet and Wallet panel in URL bar to ensure nothing obvious has regressed.

Example	Example	Example	Example	Example

Sync

Ensured starting a sync chain is successful and data is transferred.
Ensured joining sync chain is successful and data is transferred.
Ensured bookmarks is the only option enabled by default.
Ensured History, Passwords and bookmarks are synced to other devices on chain.

Example	Example	Example	Example	Example

Search Widget

Ensured adding Search Widget to home screen works.
Ensured adding Home screen widget via hamburger menu works.
Ensured that tapping on the search field on the Brave Widget will open search.
Ensured tapping on the favorites works.

Example	Example	Example	Example

Autofill Address

Ensured Save and fill addresses is enabled by default.
Ensured address form fields can be autofilled for when enabled.
Ensured that address autofill is not shown when disabled.

Example	Example	Example

mkarolin added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop labels Feb 23, 2024

mkarolin assigned samartnik, cdesouza-chromium and mkarolin Feb 23, 2024

mkarolin mentioned this issue Feb 26, 2024

Upgrade from Chromium 123 to Chromium 124. brave/brave-core#22320

Merged

24 tasks

mkarolin closed this as completed in brave/brave-core#22320 Apr 9, 2024

brave-builds added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Apr 9, 2024

brave-builds added this to the 1.66.x - Nightly milestone Apr 9, 2024

MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 9, 2024

mkarolin mentioned this issue Apr 9, 2024

Upgrade from Chromium 123 to Chromium 124 (1.65.x). brave/brave-core#22984

Merged

24 tasks

MadhaviSeelam mentioned this issue Apr 9, 2024

[CR 124] "Card" look displayed for the list of bookmarks and readlists in the sidebar panel #37444

Closed

hffvld added OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone labels Apr 9, 2024

This was referenced Apr 9, 2024

[CR124] Folder field is highlighted red when hovered in the Bookmarks dialog #37434

Closed

[C124] Blue color scrollbar for bookmarks & reading list in the sidebar panel #37442

Closed

MadhaviSeelam mentioned this issue Apr 10, 2024

Red highlight shown on the Brave VPN toggle in the hamburger menu #37450

Closed

hffvld added the QA Pass - Android ARM label Apr 10, 2024

stephendonner mentioned this issue Apr 11, 2024

<select> widget backgrounds in brave://setings are dark gray, not black like they used to be #37484

Open

stephendonner added the QA Pass-Win64 label Apr 11, 2024

brave-builds removed this from the 1.66.x - Beta milestone Apr 11, 2024

brave-builds added this to the 1.65.x - Release milestone Apr 11, 2024

LaurenWags added the QA/Test-All-Platforms label Apr 12, 2024

LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 15, 2024

LaurenWags mentioned this issue Apr 15, 2024

Desktop Release Notes for 1.65.x Release #37587

Closed

stephendonner added the QA Pass-Linux label Apr 15, 2024

stephendonner mentioned this issue Apr 15, 2024

Search or add network in Wallet Networks is broken until you've created a local wallet #37598

Closed

kjozwiak added QA/No release-notes/exclude and removed QA/Yes release-notes/include labels Apr 16, 2024

kjozwiak mentioned this issue Apr 16, 2024

Upgrade from Chromium 124.0.6367.29 to Chromium 124.0.6367.60. #37552

Closed

Uni-verse added the QA Pass - Android Tab label Apr 17, 2024

This was referenced May 30, 2024

Upgrade from Chromium 126.0.6478.17 to Chromium 126.0.6478.26 #38675

Closed

Upgrade from Chromium 126.0.6478.26 to Chromium 126.0.6478.40 #38848

Closed

kjozwiak mentioned this issue Jun 12, 2024

Upgrade from Chromium 126.0.6478.40 to Chromium 126.0.6478.56 #38974

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade from Chromium 123 to Chromium 124 #36346

Upgrade from Chromium 123 to Chromium 124 #36346

mkarolin commented Feb 23, 2024 •

edited

Loading

MadhaviSeelam commented Apr 9, 2024 •

edited

Loading

hffvld commented Apr 9, 2024

hffvld commented Apr 10, 2024 •

edited

Loading

stephendonner commented Apr 10, 2024 •

edited

Loading

Appearance / Toolbar ✅

Tabs / Sidebar ✅

kjozwiak commented Apr 11, 2024

LaurenWags commented Apr 12, 2024 •

edited

Loading

stephendonner commented Apr 12, 2024 •

edited

Loading

`Shields`

`VPN`

Unavailable on `linux`.

kjozwiak commented Apr 16, 2024

Uni-verse commented Apr 17, 2024 •

edited

Loading

Upgrade from Chromium 123 to Chromium 124 #36346

Upgrade from Chromium 123 to Chromium 124 #36346

Comments

mkarolin commented Feb 23, 2024 • edited Loading

MadhaviSeelam commented Apr 9, 2024 • edited Loading

hffvld commented Apr 9, 2024

hffvld commented Apr 10, 2024 • edited Loading

stephendonner commented Apr 10, 2024 • edited Loading

Verification PASSED using

Get started ✅

Appearance ✅

Appearance / Toolbar ✅

Tabs / Sidebar ✅

Content ✅

Shields ✅

Privacy and security ✅

Tor windows ✅

Web3 ✅

Wallet ✅

IPFS / Web3 domains ✅

Leo ✅

Sync ✅

Search engine ✅

Extensions ✅

Autofill and passwords ✅

Languages ✅

Downloads ✅

Help tips ✅

System ✅

Reset settings ✅

kjozwiak commented Apr 11, 2024

LaurenWags commented Apr 12, 2024 • edited Loading

stephendonner commented Apr 12, 2024 • edited Loading

Verification PASSED using

Shields

VPN

Unavailable on linux.

Encountered:

kjozwiak commented Apr 16, 2024

Uni-verse commented Apr 17, 2024 • edited Loading

mkarolin commented Feb 23, 2024 •

edited

Loading

MadhaviSeelam commented Apr 9, 2024 •

edited

Loading

hffvld commented Apr 10, 2024 •

edited

Loading

stephendonner commented Apr 10, 2024 •

edited

Loading

Verification `PASSED` using

LaurenWags commented Apr 12, 2024 •

edited

Loading

stephendonner commented Apr 12, 2024 •

edited

Loading

Verification `PASSED` using

`Shields`

`VPN`

Unavailable on `linux`.

Uni-verse commented Apr 17, 2024 •

edited

Loading