Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR124] Always use Speedreader... toggles show red when hovered in the Tune Speedreader dialog #37438

Closed
MadhaviSeelam opened this issue Apr 9, 2024 · 3 comments · Fixed by brave/brave-core#22994
Assignees
Labels
bug Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 9, 2024

Due to C124 changes for Bookmarks & Reading list, Always use Speedreader... toggles show red when hovered hovered in the Tune Speedreader dialog

Steps to Reproduce

  1. install 1.66.70
  2. launch Brave
  3. visit cnn.com and click an article
  4. enable the article in speedreader mode
  5. click on Tune Speedreader dialog
  6. enable one of the toggles and hover over

Actual result:

toggles show highlighted with red when hovered for both enabled and disabled toggles

example example
image image

Expected result:

Should not show red when hovered over

Reproduces how often:

Easily

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@mkarolin @rebron
cc: @aguscruiz @brave/qa-team

@mkarolin
Copy link
Contributor

This is caused by ui/views/controls/button/toggle_button.cc using colors like ui::kColorToggleButtonThumbOnHover and ui::kColorToggleButtonHover that are only defined when Chromium Refresh 2023 is enabled: https://source.chromium.org/chromium/chromium/src/+/main:ui/color/color_mixers.cc;l=30

@kjozwiak
Copy link
Member

The above requires 1.65.110 or higher for 1.65.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 15, 2024

Verification PASSED on

Brave | 1.65.112 Chromium: 124.0.6367.29 (Official Build) (64-bit)
-- | --
Revision | 1ccdfe627ad458201908007edf699da1f3bfc02b
OS | Windows 10 Version 22H2 (Build 19045.4170)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants