Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search or add network in Wallet Networks is broken until you've created a local wallet #37598

Closed
stephendonner opened this issue Apr 15, 2024 · 4 comments

Comments

@stephendonner
Copy link

Description

Search or add network in Wallet Networks is broken until you've created a local wallet

Found while testing #36346, but not a regression 👍

Steps to Reproduce

  1. install 1.67.11
  2. launch Brave
  3. open brave://settings/web3
  4. click on Wallet Networks
  5. type meter or similar
  6. click on the dropdown widget

Actual result:

Nothing happens

Screen Shot 2024-04-15 at 11 28 22 AM

Expected result:

Should show search results or be disabled, if not available until post-wallet creation

example example
Screen Shot 2024-04-15 at 12 11 07 PM Screen Shot 2024-04-15 at 12 11 11 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.67.11 Chromium: 124.0.6367.29 (Official Build) nightly (x86_64) 
Revision	06909a5f7dbab621eb4432c4508134add6bf3c7b
OS	macOS Version 11.7.10 (Build 20G1427)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

cc @supermassive @srirambv @brave/qa-team

@srirambv
Copy link
Contributor

This is expected behaviour as the components that has the mappings are not downloaded until wallet is created/restored.

@srirambv srirambv closed this as not planned Won't fix, can't repro, duplicate, stale Apr 22, 2024
@stephendonner
Copy link
Author

This is expected behaviour as the components that has the mappings are not downloaded until wallet is created/restored.

Yes, but as @supermassive agrees, it's a bad user-experience. Can we consider this?

@supermassive
Copy link

I would say we need to disable this UI until wallet is created

@srirambv
Copy link
Contributor

Entire Wallet settings under Web3 setting needs to be hidden in that case until wallet is created. I think its ok to show nothing in dropdown if there is no wallet created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants