Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<select> widget backgrounds in brave://setings are dark gray, not black like they used to be #37484

Open
stephendonner opened this issue Apr 11, 2024 · 3 comments
Assignees
Labels
bug feature/global-settings Settings at browser level independent of shields settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes regression

Comments

@stephendonner
Copy link

Description

<select> widget backgrounds in brave://setings are dark gray, not black like they used to be

Found while testing C124: #36346

Steps to Reproduce

  1. install 1.66.74`
  2. launch Brave
  3. open brave://settings
  4. compare the color of the background of the <select> widget's Dashboard

Actual result:

Background color is dark gray

Expected result:

image

Background color is black

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.66.74 Chromium: 124.0.6367.29 (Official Build) nightly (64-bit)
-- | --
Revision | 43c41a798003efcabf0d292cb2a5efdcc633857b
OS | Windows 10 Version 22H2 (Build 19045.4291)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

cc @mkarolin @rebron @brave/qa-team

@rebron
Copy link
Collaborator

rebron commented Apr 12, 2024

cc: @aguscruiz

@rebron rebron added needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. priority/P4 Planned work. We expect to get to it "soon". labels Apr 12, 2024
@aguscruiz
Copy link

This is part of the design updates from Nala. It's not a bug, it's a feature 😂.
It'll look better once we bring in the rest of the styles from Nala.

image

@stephendonner
Copy link
Author

@aguscruiz @rebron would one of you mind marking this as WONTFIX/`as designed, etc.? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/global-settings Settings at browser level independent of shields settings needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes regression
Projects
None yet
Development

No branches or pull requests

3 participants