Exit settings is hidden from the app menu on higher resolutions

[GeetaSarvadnya]

Description

Found while testing #37788
Exit settings is missing from the hamburger menu

Steps to reproduce

1. Clean profile 1.68.50
2. Click on the hamburger menu
3. Exit settings is missing from the hamburger menu

Actual result

Exit settings is missing from the hamburger menu

Expected result

Exit settings should be present in the hamburger menu

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave	1.68.50 Chromium: 126.0.6478.17 (Official Build) nightly (64-bit)
Revision	72b186fbe4e288f53b0ee102f6ec66133b41a992
OS	Windows 10 Version 22H2 (Build 19045.4412)

Channel information

• release (stable)
• beta
• nightly

Reproducibility

• with Brave Shields disabled
• with Brave Rewards disabled
• in the latest version of Chrome

Miscellaneous information

cc: @rebron @brave/qa-team @emerick

[emerick]

I can't repro this with nightly on Windows 11. According to the upstream code, the "Exit" menu should show on Windows and be hidden on Mac which is what I'm seeing.

[GeetaSarvadnya]

I can see Exit menu option on Hamburger menu on Windows 11x64, but not on Windows 10 x64. Looks like windows 10 x64 specific issue.

[stephendonner]

I just installed

Brave | 1.68.58 Chromium: 126.0.6478.17 (Official Build) nightly (64-bit)
-- | --
Revision | ec786b623be34c911487c24144c0650bdd057fc1
OS | Windows 10 Version 22H2 (Build 19045.4412)

The Exit option is there for me 👍

[GeetaSarvadnya]

I have two windows 10 x64 machines. In one machine the Exit button is shown and in other machine the Exit option isn't shown. Based on the system resolution, the exit option is shown.

Machine 1 - Windows 10 x64 - The Exit menu option isn't shown with default 150 % recommended resolution

Example	Example

If I change the 150 % recommended resolution to 125% I can see the exit menu option via hamburger menu

Example	Example

Machine 2 - Windows 10 x64 - The Exit menu option is shown with default 125 % recommended resolution

Example	Example

[GeetaSarvadnya]

cc: @emerick @rebron #38587 (comment)

[emerick]

Oh, is that because at the increased resolution the menu becomes scrollable (i.e., the Exit option scrolled off the end and maybe the scrollbar is not visible?) That's the only conceivable option I can imagine, because the menu item "should" physically be there.

[GeetaSarvadnya]

@emerick : With CR126, the hamburger menu items are increased, this is also one of the reason why the menu item Exit is not shown with default (recommended) resolution.

[stephendonner]

Oh, is that because at the increased resolution the menu becomes scrollable (i.e., the Exit option scrolled off the end and maybe the scrollbar is not visible?) That's the only conceivable option I can imagine, because the menu item "should" physically be there.

@emerick this is how it is for me, yes:

• invisible scrollbar
• X Exit below Settings

[stephendonner]

Oh, is that because at the increased resolution the menu becomes scrollable (i.e., the Exit option scrolled off the end and maybe the scrollbar is not visible?) That's the only conceivable option I can imagine, because the menu item "should" physically be there.

@emerick this is how it is for me, yes:

• invisible scrollbar
• X Exit below Settings

2024-05-30_09h27_06.mp4

[stephendonner]

And Chrome has this little expand arrow

[GeetaSarvadnya]

Chrome Vs Brave

[simonhong]

working on this.

[GeetaSarvadnya]

@simonhong @emerick: The issue is fixed and working fine now. I could see the Exit settings menu with default screen resolution 150%. Looks like removal Translate settings would have fixed the issue? not sure.

[rebron]

I think with Upgrade notifications and adding IPFS users may still run into this issue. So we'll still need the scroll.

[simonhong]

Hmm, I couldn't repro. I can see scroll arrow like below. dev build, nightly all same on my Win11 machine.
Investigating what could make arrow invisible.

[emerick]

Did you try with increased screen resolution @simonhong?

[simonhong]

Did you try with increased screen resolution @simonhong?

Yes, above one was with 200%.
Edit: Ah, it's scale. resolution was recommended one and it's highest.

[rebron]

This might be Windows 10 specific.

[rebron]

I can't reproduce this either. I'm going to go ahead and close per #38587 (comment). In Nightly, 1.69.15, with the new sidebar settings moved to the top level, I'm getting a scroll bar on Windows 10. On Beta 1.68.85 and in RC 1.67.113, I'm still seeing Exit so it's not a problem there either. Expanding to 175% I'm able to scroll up and down.

Windows 10 with recommended 150% and 1920x1080 display resolution.

[GeetaSarvadnya]

@emerick @simonhong The issue is arising again on 1.67.115 due to addition of Delete browsing data hamburger menu settings.

cc: @rebron