[CR 126] Update brave notification text is not visible and update brave icon is changed

[GeetaSarvadnya]

Description

Found while testing #37788
Update brave notification text is not visible and update brave icon is changed

Steps to reproduce

1. Clean profile 1.68.50 CR 126
2. Open brave://settings/help
3. Wait for an update don't click on Relaunch
4. Update brave notification is shown
5. Update brave notification text is not visible and update brave icon is changed

Actual result

Update brave notification text is not visible and update brave icon is changed

Expected result

Install 1.68.45 - CR 125, the build before CR126 nightly build, the update brave notification is shown as expected

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave	1.68.50 Chromium: 126.0.6478.17 (Official Build) nightly (64-bit)
Revision	72b186fbe4e288f53b0ee102f6ec66133b41a992
OS	Windows 10 Version 22H2 (Build 19045.4412)

Channel information

• release (stable)
• beta
• nightly

Reproducibility

• with Brave Shields disabled
• with Brave Rewards disabled
• in the latest version of Chrome

Miscellaneous information

cc: @brave/qa-team @emerick @rebron @mherrmann

[kjozwiak]

Just adding some more context/data. Seeing the same issue in Win 11 x64 using the following build(s):

Brave | 1.68.58 Chromium: 126.0.6478.17 (Official Build) nightly (64-bit)
-- | --
Revision | ec786b623be34c911487c24144c0650bdd057fc1
OS | Windows 11 Version 23H2 (Build 22631.3672)

[emerick]

@simonhong Will probably leave this one in your hands if that's OK.

[simonhong]

working on this.

[bsclifton]

Ran into this today (build before fix) - nice work @simonhong 😄 And thanks for logging @GeetaSarvadnya

[kjozwiak]

The above requires 1.67.106 or higher for 1.67.x verification 👍 Just a quick note, created #38810 in case we want to improve the highlight/selection UX/UI. However, Chrome looks the same so we might just want to leave it. @simonhong provided the following image re: Chrome having the same UI/UX experience:

[LaurenWags]

Verified with

Brave	1.67.107 Chromium: 126.0.6478.26 (Official Build) beta (arm64) 
Revision	2831369c7540d93e98f38d9b463f6762430a7982
OS	macOS Version 14.5 (Build 23F79)

Installed above version, confirmed that the update to 1.67.108 naturally displayed on the hamburger menu:

[LaurenWags]

Verified with

Brave | 1.67.107 Chromium: 126.0.6478.26 (Official Build) beta (x86_64)
-- | --
Revision | 2831369c7540d93e98f38d9b463f6762430a7982
OS | macOS Version 13.6.7 (Build 22G720)

Reproduced the issue using 1.67.105:

Dark	Light

Using 1.67.107:

• Launched via terminal with --args --enable-logging=stderr --simulate-critical-update
• Confirmed no red/orange coloring on menu item (hamburger menu with "Update" text is red as expected)
• Confirmed expected icon on hamburger menu item for "Relaunch to Update Brave"

Dark	Light

Encountered:

• update color of "Relaunch to Update Brave" hamburger menu item on dark/light themes #38919
• [CR 126] hamburger "Update" prompt is missing a color when using light theme #38899
• improve the selection highlight when hovering over Relaunch to update Brave via Hamburger Menu - follow up to #38645 #38810

[MadhaviSeelam]

Verification PASSED using

Brave | 1.67.107 Chromium: 126.0.6478.26 (Official Build) beta (64-bit)
-- | --
Revision | 2831369c7540d93e98f38d9b463f6762430a7982
OS | Windows 11 Version 23H2 (Build 22631.3672)

Reproduced the issue using 1.67.105:

Light	Dark

Using 1.67.107:

• Launched via terminal with --enable-logging=stderr --simulate-critical-upgrade
• Confirmed no red/orange coloring on menu item
• Confirmed expected icon on hamburger menu item for "Relaunch to Update Brave"

Light	Dark