[CR 126] hamburger "Update" prompt is missing a color when using light theme

[LaurenWags]

Description

When the hamburger shows that an update is available, it displays in green, orange, or red. These colors display fine on dark theme but on light theme only green and red show. The second color (presumably orange to match dark theme) just displays as black.

This is not new with C126, occurs on 1.66.x with C125 also.

Steps to reproduce

1. Launch via terminal with --args --enable-logging=stderr --simulate-upgrade
2. Watch the hamburger menu
3. After ~20-30s it will show the green "Update" notification on the hamburger menu (works on both light and dark theme)
4. After another ~20-30s it will show the orange "Update" notification on the hamburger menu in dark theme only. Light theme displays this as black.
5. Finally after another ~20-30s it will show the red "Update" notification on the hamburger menu (works on both light and dark theme)

Note, if step 1 doesn't work, launch without --simulate-upgrade first on a clean install, then relaunch with it. I think sometimes it doesn't work on an initial launch.

Actual result

second update color on light theme doesn't match dark theme

Expected result

Light theme should probably also have an orange color

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.66.x, 1.67.x

Channel information

• release (stable)
• beta
• nightly

Reproducibility

• with Brave Shields disabled
• with Brave Rewards disabled
• in the latest version of Chrome

Miscellaneous information

For comparison, here's 1.66.x vs 1.67.x:

1.66.x	1.67.x

cc @rebron @aguscruiz

[simonhong]

checking

[kjozwiak]

@LaurenWags I couldn't get Nightly to change to the Orange phase after trying a bunch of methods/waiting and moving the time forward. I managed to reproduce it on Release using your STR/Cases pretty easily as per the following:

Going to uplift the above as it's a simple colour change. This is the last issue that needs to be uplifted before we can kick of the final RC. Hopefully it's easier to check/verify on the RC rather than on Nightly.

[kjozwiak]

The above requires 1.67.115 or higher for 1.67.x verification 👍

[LaurenWags]

Verified with

Brave | 1.67.115 Chromium: 126.0.6478.56 (Official Build) (x86_64)
-- | --
Revision | e1f8b4850805c2eea958bad7220c5e6e9202efaa
OS | macOS Version 13.6.7 (Build 22G720)

1. Launch 1.67.115 without any command line switches
2. Close and relaunch via terminal with --args --enable-logging=stderr --simulate-upgrade
3. Watch the hamburger menu
4. Confirmed after ~20-30s it will show the green "Update" notification on the hamburger menu
5. Confirmed after another ~20-30s it will show the orange "Update" notification on the hamburger menu
6. Confirmed after another ~20-30s it will show the red "Update" notification on the hamburger menu
7. Repeated above test with light theme

Dark Theme	Light Theme