Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CR 126] Privacy and security settings icon is inherited from Chrome #38593

Closed
1 of 6 tasks
GeetaSarvadnya opened this issue May 27, 2024 · 4 comments · Fixed by brave/brave-core#23868
Closed
1 of 6 tasks

[CR 126] Privacy and security settings icon is inherited from Chrome #38593

GeetaSarvadnya opened this issue May 27, 2024 · 4 comments · Fixed by brave/brave-core#23868
Assignees
@emerick
Labels
branding feature/settings OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.67.x - Release

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #37788
Privacy and security settings icon is inherited from Chrome

Steps to reproduce

  1. Clean profile 1.68.50
  2. Open brave://settings/
  3. Look for the Privacy and security settings in the left navigation settings menu
  4. Privacy and security settings icon is inherited from Chrome

Actual result

Privacy and security settings icon is inherited from Chrome
image

Expected result

Privacy and security settings should have brave branded icon

image

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.68.50 Chromium: 126.0.6478.17 (Official Build) nightly (64-bit)
Revision 72b186fbe4e288f53b0ee102f6ec66133b41a992
OS Windows 10 Version 22H2 (Build 19045.4412)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc: @brave/qa-team @emerick @rebron
@GeetaSarvadnya GeetaSarvadnya changed the title Privacy and security settings icon is inherited from Chrome CR 126 - Privacy and security settings icon is inherited from Chrome May 27, 2024
@GeetaSarvadnya GeetaSarvadnya mentioned this issue May 27, 2024
Closed
@GeetaSarvadnya
Copy link
Author

cc: @aguscruiz

@aguscruiz
Copy link

Let's keep our current icon here

@emerick emerick self-assigned this May 28, 2024
@emerick emerick mentioned this issue May 28, 2024
Merged
24 tasks
@emerick emerick added this to the 1.68.x - Nightly milestone May 28, 2024
@emerick emerick mentioned this issue May 28, 2024
Merged
24 tasks
@rebron rebron moved this to Completed in Settings May 28, 2024
@kjozwiak
Copy link
Member

The above requires 1.67.101 or higher for 1.67.x verification 👍

@GeetaSarvadnya
Copy link
Author

Verification PASSED on

Brave | 1.67.101 Chromium: 126.0.6478.26 (Official Build) beta (64-bit)
-- | --
Revision | a561f4b53cdb831888e5cd702d2b8f9598c00f50
OS | Windows 10 Version 22H2 (Build 19045.4412)
  • Ensured that Privacy and security settings icon is brave branded
    image

@rebron rebron changed the title CR 126 - Privacy and security settings icon is inherited from Chrome [CR 126] Privacy and security settings icon is inherited from Chrome Jun 5, 2024
@rebron rebron removed this from Settings Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
branding feature/settings OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

Fix use of upstream icons in brave://settings brave/brave-core
5 participants
@kjozwiak @emerick @aguscruiz @GeetaSarvadnya @brave-builds