-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport "HBASE-28807 Remove some useless code and add some logs for CanaryTool" to branch-3 #6213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apache#5641) Co-authored-by: sunhao5 <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
…pache#5716) Signed-off-by: Nihal Jain <[email protected]>
apache#5689) HBASE-27949 [JDK17] Add JDK17 compilation and unit test support to nightly job HBASE-26372 [JDK17] Jenkins build support
…(addendum) (apache#5717) Signed-off-by: Nihal Jain <[email protected]>
…#5709) We see unit test failures in Jenkins that look like this: ``` java.lang.IllegalArgumentException: run queue not empty at org.apache.hbase.thirdparty.com.google.common.base.Preconditions.checkArgument(Preconditions.java:143) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.load(ProcedureExecutor.java:332) at org.apache.hadoop.hbase.procedure2.ProcedureExecutor.init(ProcedureExecutor.java:665) at org.apache.hadoop.hbase.procedure2.ProcedureTestingUtility.restart(ProcedureTestingUtility.java:132) at org.apache.hadoop.hbase.procedure2.ProcedureTestingUtility.restart(ProcedureTestingUtility.java:100) at org.apache.hadoop.hbase.master.procedure.MasterProcedureTestingUtility.restartMasterProcedureExecutor(MasterProcedureTestingUtility.java:85) at org.apache.hadoop.hbase.master.assignment.TestRollbackSCP.testFailAndRollback(TestRollbackSCP.java:180) ``` This isn't enough information to debug the situation. The test code in question looks reasonable enough – it clears the object for re-use between tests. However, somewhere between stop/clear/start we miss something. Add some toString implementations and dump the objects in the preconditions. Signed-off-by: Duo Zhang <[email protected]>
…ition (apache#5699) When a region is in transition, it may briefly have a null ServerName in meta. The RegionSizeCalculator calls RegionLocator.getAllRegionLocations() and does not handle the possibility that a RegionLocation.getServerName() could be null. The ServerName is eventually passed into an Admin call, which results in an NPE. This has come up in other contexts. For example, taking a look at getAllRegionLocations() impl, we have checks to ensure that we don't call null server names. We need to similarly handle the possibility of nulls in RegionSizeCalculator. Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Hui Ruan <[email protected]>
Assume a user has a series of backups: Full1, Inc2, Inc3, where a table has not changed between Full1 and Inc3, but has changed after Inc3. When restoring that table to Inc3, a log warning was outputted mentioning there was no need for a restore. This message in fact means there is no need for the incremental restore portion of the restore process. Signed-off-by: Nihal Jain <[email protected]> (cherry picked from commit 102c1b6)
…he#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Pankaj Kumar < [email protected]>
…h broken pipe instead of bad auth (apache#5740) Also change the IPC related tests to test different combinations of rpc server&client, for example, NettyRpcClient and SimpleRpcServer Signed-off-by: Nick Dimiduk <[email protected]> Signed-off-by: Bryan Beaudreault <[email protected]>
Signed-off-by: Bryan Beaudreault <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>
…egistry (apache#5744) Signed-off-by: Nick Dimiduk <[email protected]>
Our objective is to remove ZooKeeper from our public interface, remaking it as an internal concern. Connecting to a cluster via ZooKeeper quorum will be considered deprecated starting in 2.6. Our default connection mechanism will switch to via RPC in 3.0 And finally we intend to remove the ZooKeeper connection mechanism from client-facing APIs in 4.0. Signed-off-by: Bryan Beaudreault <[email protected]>
…3.0.0-beta-2 (apache#5697) Signed-off-by: Bryan Beaudreault <[email protected]>
…ut/Delete mutations (apache#5760) Signed-off-by: Viraj Jasani <[email protected]>
…segment (apache#5705) Signed-off-by: Bryan Beaudreault <[email protected]>
…e#5706) Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Bryan Beaudreault <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Wei-Chiu Chuang <[email protected]>
…nfigurable. (apache#5743) Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Andrew Purtell <[email protected]>
…ed (apache#5713) Signed-off-by: Bryan Beaudreault <[email protected]>
…s to global archived dir (apache#5756) Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Pankaj Kumar < [email protected]> Signed-off-by: Rajeshbabu Chintaguntla <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
…pache#5765) Signed-off-by: Bryan Beaudreault <[email protected]> Signed-off-by: Andrew Purtell <[email protected]>
…erval (apache#5773) Signed-off-by: Bryan Beaudreault <[email protected]>
…ntiateDeleteTracker (apache#6133) Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Nihal Jain <[email protected]>
* Sync code as per irb 1.4.2 * Also provide option to try irb's new functionalities for colorize and autocomplete Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Pankaj <[email protected]> Signed-off-by: Istvan Toth <[email protected]>
… from output tarball (apache#6157) Signed-off-by: Duo Zhang <[email protected]>
…che#6162) Signed-off-by: Pankaj <[email protected]>
…nvoking setStoragePolicy() (apache#5189)
…eTransition if procedure is initialised by next Active master (apache#6129) Added masterActiveTime as fencing token for remote procedures Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Aman Poonia <[email protected]>
…nalSslHandler (apache#6149) Signed-off-by: Balazs Meszaros <[email protected]>
… disabled at table level (apache#6169) - Fail fast by adding a check before even submitting a procedure - Update test cases to assert for expected exception post this change - Remove deprecated method mergeRegionsAsync's usage in test - Make use of RegionInfo.getShortNameToLog instead of logging complete region info - Update comments in procedure implementation Signed-off-by: Duo Zhang <[email protected]>
HBASE-28793 Update hbase-thirdparty to 4.1.8 Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Reviewed-by: Vineet Kumar Maheshwari <[email protected]>
…apache#6176) Signed-off-by: Pankaj Kumar<[email protected]> Reviewed-by: Vineet Kumar Maheshwari <[email protected]>
…rable state for the given backup (apache#6088) Co-authored-by: Ray Mattingly <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…lete (apache#6089) Co-authored-by: Ray Mattingly <[email protected]>
… cache. (apache#6183) HBASE-28805: Chunked persistence of backing map for persistent bucket cache. Signed-off-by: Wellington Chevreuil <[email protected]>
…fined order (apache#6168) Signed-off-by: Nick Dimiduk <[email protected]>
…ks a connection to ZooKeeper (apache#6147) Co-authored-by: rodenli <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
…pache#6196) Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.4 to 43.0.1. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@42.0.4...43.0.1) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Duo Zhang <[email protected]>
…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]>
…#6076) Co-authored-by: Evie Boland <[email protected]> Signed-off-by: Nick Dimiduk <[email protected]>
…ame of the datanode (apache#6148) Co-authored-by: wangxin <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Reviewed-by: Vineet Kumar Maheshwari <[email protected]> Reviewed-by: guluo <[email protected]>
…#6205) Signed-off-by: Nick Dimiduk <[email protected]>
…apache#6187) Co-authored-by: wangxin <[email protected]> Signed-off-by: Nihal Jain <[email protected]> (cherry picked from commit b161ad5)
NihalJain
added
the
backport
This PR is a back port of some issue or issues already committed to master
label
Sep 6, 2024
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Will reopen as another PR. closing without commit.! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #6187
CC: @1458451310