HBASE-20693 Refactor thrift jsp's and extract header and footer #5732

NihalJain · 2024-02-29T16:56:07Z

Fixes the way logLevel page renders in UI

- Fixes the way logLevel page renders in UI

NihalJain · 2024-02-29T17:04:02Z

Built code locally, extracted assembly, started a local cluster and started HBase Thrift server.

Verified the landing page has the right page title, all the tabs are visible and no error in page rendering.
Verified /logLevel page is fixed with appropriate tabs, as expected and shown below:
- Before patch:
- After patch:
Verified all other pages like /logs, /jmx, /conf works as before
Also ran Thrift demo client org.apache.hadoop.hbase.thrift.DemoClient and ensured no error

Apache-HBase · 2024-02-29T17:52:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 21s	master passed
+1 💚	spotless	0m 47s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 12s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	spotless	0m 49s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 11s	The patch does not generate ASF License warnings.
		9m 39s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5732/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5732
Optional Tests	dupname asflicense javac spotless
uname	Linux a52e732846c3 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1c41e86`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	74 (vs. ulimit of 30000)
modules	C: hbase-thrift U: hbase-thrift
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5732/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-29T17:59:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 41s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 34s	master passed
+1 💚	javadoc	0m 29s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 4s	the patch passed
+1 💚	javadoc	0m 24s	the patch passed
		_ Other Tests _
+1 💚	unit	7m 8s	hbase-thrift in the patch passed.
		16m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5732/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5732
Optional Tests	javac javadoc unit
uname	Linux db84ed659803 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1c41e86`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5732/1/testReport/
Max. process+thread count	1236 (vs. ulimit of 30000)
modules	C: hbase-thrift U: hbase-thrift
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5732/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-29T18:03:33Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 36s	master passed
+1 💚	javadoc	0m 53s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	6m 50s	hbase-thrift in the patch passed.
		19m 25s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5732/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5732
Optional Tests	javac javadoc unit
uname	Linux f0c46a893b9c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1c41e86`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5732/1/testReport/
Max. process+thread count	1302 (vs. ulimit of 30000)
modules	C: hbase-thrift U: hbase-thrift
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5732/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-02-29T18:12:09Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 51s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 56s	master passed
+1 💚	javadoc	0m 44s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 44s	the patch passed
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	8m 41s	hbase-thrift in the patch passed.
		20m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5732/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5732
Optional Tests	javac javadoc unit
uname	Linux b70235588a30 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1c41e86`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5732/1/testReport/
Max. process+thread count	1266 (vs. ulimit of 30000)
modules	C: hbase-thrift U: hbase-thrift
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5732/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-03-01T07:07:21Z

Hey @ndimiduk would you have some cycles to review this? Similar refactoring was also part of rest module in #5215 Also you had a +1 on JIRA HBASE-20693

ndimiduk

LGTM

- Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd)

…oter (apache#5732)" and Backport "HBASE-18382 add transport type info into Thrift UI (apache#880)" to branch-2

…he#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd)

… (#5737) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd)

…he#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd)

* HBASE-18382 add transport type info into Thrift UI (#880) Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 82e155e) * HBASE-20693 Refactor thrift jsp's and extract header and footer (#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd) * HBASE-24624 Optimize table.jsp code (#1963) Signed-off-by: Guangxu Cheng <[email protected]> (cherry picked from commit 9ad16aa) * HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Pankaj Kumar<[email protected]> (cherry picked from commit 157200e) * HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d) --------- Co-authored-by: Beata Sudi <[email protected]> Co-authored-by: Nihal Jain <[email protected]> Co-authored-by: xincunSong <[email protected]> Co-authored-by: Akshay Sudheer <[email protected]> Co-authored-by: Peng Lu <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Andrew Purtell <[email protected]>

* HBASE-27406 Make /prometheus endpoint accessible from HBase UI (#4833) Signed-off-by: Andor Molnar <[email protected]> Signed-off-by: Balazs Meszaros <[email protected]> (cherry picked from commit dffc8e0) * HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer (#5215) Other changes: - Ensure info server stops during stop() - Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693) - Add hostname in the landing page instead of just port similar to other web UIs Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit a683fcf) * HBASE-18382 add transport type info into Thrift UI (#880) Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 82e155e) * HBASE-20693 Refactor thrift jsp's and extract header and footer (#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd) * HBASE-24624 Optimize table.jsp code (#1963) Signed-off-by: Guangxu Cheng <[email protected]> (cherry picked from commit 9ad16aa) * HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Pankaj Kumar<[email protected]> (cherry picked from commit 157200e) * HBASE-27309 Add major compact table or region operation on master web table page (#4793) Co-authored-by: zhengsicheng <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit eb6b274) * HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d) * HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp (#5620) Co-authored-by: Haosen Chen <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit e3a0174) * HBASE-20452 Master UI: Table merge button should validate required fields before submit Signed-off-by: tedyu <[email protected]> (cherry picked from commit 6ce1136) * HBASE-29028 Removed Prometheus links from navbar as the feature (HBASE-20904) is not even supported by backend. --------- Co-authored-by: Luca Kovács <[email protected]> Co-authored-by: Nihal Jain <[email protected]> Co-authored-by: Beata Sudi <[email protected]> Co-authored-by: xincunSong <[email protected]> Co-authored-by: Akshay Sudheer <[email protected]> Co-authored-by: SiCheng-Zheng <[email protected]> Co-authored-by: Peng Lu <[email protected]> Co-authored-by: haosen chen <[email protected]> Co-authored-by: Nihal Jain <[email protected]> Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Nihal Jain <[email protected]>

HBASE-20693 Refactor thrift jsp's and extract header and footer

28b70f2

- Fixes the way logLevel page renders in UI

NihalJain requested a review from ndimiduk March 1, 2024 07:07

ndimiduk approved these changes Mar 1, 2024

View reviewed changes

NihalJain merged commit ede4ccd into apache:master Mar 1, 2024
1 check passed

NihalJain added a commit that referenced this pull request Mar 1, 2024

HBASE-20693 Refactor thrift jsp's and extract header and footer (#5732)

102b1a5

- Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd)

NihalJain added a commit to NihalJain/hbase that referenced this pull request Mar 1, 2024

Backport "HBASE-20693 Refactor thrift jsp's and extract header and fo…

25930ed

…oter (apache#5732)" and Backport "HBASE-18382 add transport type info into Thrift UI (apache#880)" to branch-2

NihalJain mentioned this pull request Mar 1, 2024

Backport "HBASE-20693 Refactor thrift jsp's and extract header and footer" to branch-2 #5737

Merged

PDavid mentioned this pull request Dec 13, 2024

HBASE-29028 Backport missing UI patches to branch-2.5 #6542

Merged

PDavid mentioned this pull request Dec 16, 2024

HBASE-29036 Backport missing UI patches to branch-2.6 #6546

Closed

PDavid mentioned this pull request Dec 18, 2024

HBASE-29036 Backport missing UI patches to branch-2.6 #6550

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-20693 Refactor thrift jsp's and extract header and footer #5732

HBASE-20693 Refactor thrift jsp's and extract header and footer #5732

NihalJain commented Feb 29, 2024

NihalJain commented Feb 29, 2024

Apache-HBase commented Feb 29, 2024

Apache-HBase commented Feb 29, 2024

Apache-HBase commented Feb 29, 2024

Apache-HBase commented Feb 29, 2024

NihalJain commented Mar 1, 2024

ndimiduk left a comment

HBASE-20693 Refactor thrift jsp's and extract header and footer #5732

HBASE-20693 Refactor thrift jsp's and extract header and footer #5732

Conversation

NihalJain commented Feb 29, 2024

NihalJain commented Feb 29, 2024

Apache-HBase commented Feb 29, 2024

Apache-HBase commented Feb 29, 2024

Apache-HBase commented Feb 29, 2024

Apache-HBase commented Feb 29, 2024

NihalJain commented Mar 1, 2024

ndimiduk left a comment

Choose a reason for hiding this comment