HBASE-29028 Backport missing UI patches to branch-2.5 #6542

PDavid · 2024-12-13T17:00:13Z

Cherry-picked the following patches which were missing on branch-2.5 branch. Most of these applied as a clean cherry-pick (without conflicts). Unfortunately there were some which had conflicts and I manually resolved them.
Each commit message contains from which commit it was cherry-picked from.

HBASE-27406 Make /prometheus endpoint accessible from HBase UI (HBASE-27406 Make "/prometheus" endpoint accessible from HBase UI #4833)
HBASE-27814 Add support for dump and process metrics servlet in REST InfoServer (HBASE-27814 Add support for dump and process metrics servlet in REST … #5215)
HBASE-18382 add transport type info into Thrift UI (HBASE-18382 add transport type info into Thrift UI #880)
HBASE-20693 Refactor thrift jsp's and extract header and footer (HBASE-20693 Refactor thrift jsp's and extract header and footer #5732)
HBASE-24624 Optimize table.jsp code (HBASE-24624 Optimize table.jsp code #1963) - ⚠️ This did not apply cleanly - had to resolve conflicts manually
HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (HBASE-25402 HBase UI: sorting order by start key or end key is not considering empty start key/end key #2955)
HBASE-27309 Add major compact table or region operation on master web table page (HBASE-27309 Add major compact table or region operation on master web… #4793)
HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.js… #6152)
HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp (HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp #5620)
HBASE-20452 Master UI: Table merge button should validate required fields before submit

Is it OK to have multiple patches in one PR like this or would you prefer having a separate PR for each commit?

…e#4833) Signed-off-by: Andor Molnar <[email protected]> Signed-off-by: Balazs Meszaros <[email protected]> (cherry picked from commit dffc8e0)

…InfoServer (apache#5215) Other changes: - Ensure info server stops during stop() - Extract header and footer. This would fix the log level page layout for rest web UI (See HBASE-20693) - Add hostname in the landing page instead of just port similar to other web UIs Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit a683fcf)

Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 82e155e)

…he#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd)

Signed-off-by: Guangxu Cheng <[email protected]> (cherry picked from commit 9ad16aa)

…empty start key/end key (apache#2955) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Pankaj Kumar<[email protected]> (cherry picked from commit 157200e)

… table page (apache#4793) Co-authored-by: zhengsicheng <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit eb6b274)

…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)

…pache#5620) Co-authored-by: Haosen Chen <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit e3a0174)

…elds before submit Signed-off-by: tedyu <[email protected]> (cherry picked from commit 6ce1136)

NihalJain · 2024-12-19T06:00:34Z

Hi @PDavid please let me know once this PR is ready for review

PDavid · 2024-12-19T08:39:05Z

Hi @NihalJain,
Many thanks, I think this is now ready to review. Some tests failed in the PR build but I think they are not related.

NihalJain · 2024-12-24T07:19:43Z

Tried the change, they work fine for me:

Master: LGTM, except navbar all look good. Again navbar should not be issue as bootstrap bump will fix it eventually

Rest UI: LGTM

Thrift UI: LGTM

NihalJain

We may need to drop HBASE-27406 Make /prometheus endpoint accessible from HBase UI (#4833) as the feature is not even supported by backend.
Trying to open /prometheus give 404 with this change.

PDavid · 2025-01-06T10:45:24Z

Hi @NihalJain,

Many thanks for testing the changes. 👍

We may need to drop HBASE-27406 Make /prometheus endpoint accessible from HBase UI (#4833) as the feature is not even supported by backend. Trying to open /prometheus give 404 with this change.

Very good catch, thanks. I was not aware and somehow did not found this. 🤦‍♂️ I'll have a look and fix this.

Would it work if we keep the "Metrics" dropdown but remove the Prometheus links? So we would only have the "JMX" and "JMX with description" links there.

What do you think?

NihalJain · 2025-01-06T10:58:18Z

Would it work if we keep the "Metrics" dropdown but remove the Prometheus links? So we would only have the "JMX" and "JMX with description" links there.

Sounds good to me!

as the feature (HBASE-20904) is not even supported by backend.

PDavid · 2025-01-06T16:58:45Z

OK, now the Prometheus links are removed.

Master UI

Region Server UI

REST Server UI

Thrift Server UI

NihalJain · 2025-01-07T05:25:11Z

Dropped a mail on dev thread to decide on whether we want to take this and other related changes in before the upcoming release. https://lists.apache.org/thread/86ds4dxprvyot243g3jg0ztxzjn5btrq

FYI @PDavid

CC: #6525

Apache-HBase · 2025-01-07T14:03:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-2.5 Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 58s		branch-2.5 passed
+1 💚	compile	3m 36s		branch-2.5 passed
+1 💚	checkstyle	1m 14s		branch-2.5 passed
+1 💚	spotbugs	2m 57s		branch-2.5 passed
-1 ❌	spotless	0m 44s		branch has 1 errors when running spotless:check, run spotless:apply to fix.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 44s		the patch passed
+1 💚	compile	3m 38s		the patch passed
+1 💚	javac	3m 38s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 13s		the patch passed
+1 💚	spotbugs	3m 22s		the patch passed
+1 💚	hadoopcheck	20m 34s		Patch does not cause any errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 27s		The patch does not generate ASF License warnings.
		47m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6542
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 169095e7f19e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.5 / `bb074da`
Default Java	Eclipse Adoptium-11.0.23+9
spotless	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/3/artifact/yetus-general-check/output/branch-spotless.txt
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6542/3/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid · 2025-01-07T16:01:28Z

The spotless check itself was successful in the CI build but there was some other error:

INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  39.461 s
[INFO] Finished at: 2025-01-07T13:29:55Z
[INFO] ------------------------------------------------------------------------
[ERROR] An internal error occurred during: "Periodic workspace save.".
java.lang.IllegalStateException: Job manager has been shut down.
    at org.eclipse.core.internal.jobs.JobManager.schedule (JobManager.java:1295)
    at org.eclipse.core.internal.jobs.InternalJob.schedule (InternalJob.java:385)
    at org.eclipse.core.runtime.jobs.Job.schedule (Job.java:684)
    at org.eclipse.core.internal.events.AutoBuildJob.build (AutoBuildJob.java:110)
    at org.eclipse.core.internal.events.BuildManager.endTopLevel (BuildManager.java:604)
    at org.eclipse.core.internal.resources.Workspace.endOperation (Workspace.java:1518)
    at org.eclipse.core.internal.resources.SaveManager.save (SaveManager.java:1246)
    at org.eclipse.core.internal.resources.SaveManager.save (SaveManager.java:1143)
    at org.eclipse.core.internal.resources.DelayedSnapshotJob.run (DelayedSnapshotJob.java:55)
    at org.eclipse.core.internal.jobs.Worker.run (Worker.java:63)

Also run spotless check locally and was successful.

apurtell

I see the branch-2 PR has been merged already, and that presumably the branch-2.6 (#6550) will be merged soon. This can go in to branch-2.5 after that. @NihalJain

NihalJain · 2025-01-08T05:00:29Z

We already have a go ahead for this; thanks to @Apache9 and @apurtell on mail thread.
Hi, @PDavid Please let me know if this is good to merge today!

PDavid · 2025-01-08T08:06:30Z

We already have a go ahead for this; thanks to @Apache9 and @apurtell on mail thread. Hi, @PDavid Please let me know if this is good to merge today!

Hi @NihalJain and @apurtell,

Many thanks for the reviews. I think this is ready to be merged.

lucakovacs and others added 4 commits December 12, 2024 15:36

HBASE-27406 Make /prometheus endpoint accessible from HBase UI (apach…

137c6dc

…e#4833) Signed-off-by: Andor Molnar <[email protected]> Signed-off-by: Balazs Meszaros <[email protected]> (cherry picked from commit dffc8e0)

HBASE-18382 add transport type info into Thrift UI (apache#880)

6a4dbea

Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 82e155e)

HBASE-20693 Refactor thrift jsp's and extract header and footer (apac…

71f65b5

…he#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd)

PDavid changed the title ~~HBASE-29028 Backport missing UI patches to branch-2.x~~ HBASE-29028 Backport missing UI patches to branch-2.5 Dec 13, 2024

This comment has been minimized.

Sign in to view

songxincun and others added 6 commits December 16, 2024 10:10

HBASE-24624 Optimize table.jsp code (apache#1963)

79a181e

Signed-off-by: Guangxu Cheng <[email protected]> (cherry picked from commit 9ad16aa)

HBASE-25402 Sorting order by start key or end key is not considering …

b8d5f98

…empty start key/end key (apache#2955) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Pankaj Kumar<[email protected]> (cherry picked from commit 157200e)

HBASE-27309 Add major compact table or region operation on master web…

0b0ac60

… table page (apache#4793) Co-authored-by: zhengsicheng <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit eb6b274)

HBASE-28778 NPE may occur when opening master-status or table.jsp or …

8b14486

…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)

HBASE-28305 Add "Uncompressed StoreFileSize" column to the table.jsp (a…

ebdeef2

…pache#5620) Co-authored-by: Haosen Chen <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit e3a0174)

HBASE-20452 Master UI: Table merge button should validate required fi…

a9d154d

…elds before submit Signed-off-by: tedyu <[email protected]> (cherry picked from commit 6ce1136)

PDavid force-pushed the HBASE-29028-UI-missing-patches-branch-2.5 branch from ed87ac8 to a9d154d Compare December 16, 2024 09:19

PDavid mentioned this pull request Dec 16, 2024

HBASE-28832 Upgrade from bootstrap 3.4.1 to non vulnerable version 5.3.3 #6490

Merged

This comment has been minimized.

Sign in to view

PDavid marked this pull request as ready for review December 18, 2024 07:23

NihalJain requested changes Dec 24, 2024

View reviewed changes

PDavid marked this pull request as draft January 6, 2025 13:55

HBASE-29028 Removed Prometheus links from navbar

bb074da

as the feature (HBASE-20904) is not even supported by backend.

NihalJain approved these changes Jan 7, 2025

View reviewed changes

PDavid marked this pull request as ready for review January 7, 2025 09:26

apurtell approved these changes Jan 7, 2025

View reviewed changes

NihalJain mentioned this pull request Jan 8, 2025

HBASE-29036 Backport missing UI patches to branch-2.6 #6550

Merged

NihalJain merged commit 526bad7 into apache:branch-2.5 Jan 8, 2025
1 check failed

PDavid deleted the HBASE-29028-UI-missing-patches-branch-2.5 branch January 8, 2025 12:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-29028 Backport missing UI patches to branch-2.5 #6542

HBASE-29028 Backport missing UI patches to branch-2.5 #6542

PDavid commented Dec 13, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

NihalJain commented Dec 19, 2024

PDavid commented Dec 19, 2024

NihalJain commented Dec 24, 2024 •

edited

Loading

NihalJain left a comment •

edited

Loading

PDavid commented Jan 6, 2025

NihalJain commented Jan 6, 2025

PDavid commented Jan 6, 2025

NihalJain commented Jan 7, 2025 •

edited

Loading

Apache-HBase commented Jan 7, 2025

PDavid commented Jan 7, 2025 •

edited

Loading

apurtell left a comment •

edited

Loading

NihalJain commented Jan 8, 2025

PDavid commented Jan 8, 2025

HBASE-29028 Backport missing UI patches to branch-2.5 #6542

HBASE-29028 Backport missing UI patches to branch-2.5 #6542

Conversation

PDavid commented Dec 13, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

NihalJain commented Dec 19, 2024

PDavid commented Dec 19, 2024

NihalJain commented Dec 24, 2024 • edited Loading

NihalJain left a comment • edited Loading

Choose a reason for hiding this comment

PDavid commented Jan 6, 2025

NihalJain commented Jan 6, 2025

PDavid commented Jan 6, 2025

NihalJain commented Jan 7, 2025 • edited Loading

Apache-HBase commented Jan 7, 2025

PDavid commented Jan 7, 2025 • edited Loading

apurtell left a comment • edited Loading

Choose a reason for hiding this comment

NihalJain commented Jan 8, 2025

PDavid commented Jan 8, 2025

PDavid commented Dec 13, 2024 •

edited

Loading

NihalJain commented Dec 24, 2024 •

edited

Loading

NihalJain left a comment •

edited

Loading

NihalJain commented Jan 7, 2025 •

edited

Loading

PDavid commented Jan 7, 2025 •

edited

Loading

apurtell left a comment •

edited

Loading