-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.js… #6152
Conversation
…p while Master is initializing
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
HRegion region = null; | ||
if (regionName != null) { | ||
region = rs.getRegion(regionName); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We input directly into the browser http://localhost:16030/region.json, without specifying a region name (http://localhost:16030/region.json?name=123456789), we would get NPE in here.
Although this situation does not occur frequently, it is best to handle it.
🎊 +1 overall
This message was automatically generated. |
@@ -47,8 +47,28 @@ | |||
<%@ page import="org.apache.hadoop.hbase.metrics.Histogram" %> | |||
<%@ page import="java.util.TreeMap" %> | |||
<%@ page import="org.apache.hadoop.hbase.metrics.impl.HistogramImpl" %> | |||
|
|||
<jsp:include page="header.jsp"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we move this page here? Because we may add some elements in the below code block and it should be placed after header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…procedure.jsp while Master is initializing (#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)
…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)
…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)
…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)
…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)
…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)
…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)
* HBASE-24624 Optimize table.jsp code (#1963) Signed-off-by: Guangxu Cheng <[email protected]> (cherry picked from commit 9ad16aa) * HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (#2955) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Pankaj Kumar<[email protected]> (cherry picked from commit 157200e) * HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d) * HBASE-20452 Master UI: Table merge button should validate required fields before submit Signed-off-by: tedyu <[email protected]> (cherry picked from commit 6ce1136) --------- Co-authored-by: xincunSong <[email protected]> Co-authored-by: Akshay Sudheer <[email protected]> Co-authored-by: Peng Lu <[email protected]> Co-authored-by: Nihal Jain <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Nihal Jain <[email protected]>
…p while Master is initializing
Details see: HBASE-28778