HBASE-29036 Backport missing UI patches to branch-2.6 #6550

PDavid · 2024-12-18T07:29:27Z

Cherry-picked the following patches which were missing on branch-2.6 branch. Most of these applied as a clean cherry-pick (without conflicts). Unfortunately there were some which had conflicts and I manually resolved them.
Each commit message contains from which commit it was cherry-picked from.

HBASE-18382 add transport type info into Thrift UI (HBASE-18382 add transport type info into Thrift UI #880)
HBASE-20693 Refactor thrift jsp's and extract header and footer (HBASE-20693 Refactor thrift jsp's and extract header and footer #5732)
HBASE-24624 Optimize table.jsp code (HBASE-24624 Optimize table.jsp code #1963) - ⚠️ This did not apply cleanly - had to resolve conflicts manually
HBASE-25402 Sorting order by start key or end key is not considering empty start key/end key (HBASE-25402 HBase UI: sorting order by start key or end key is not considering empty start key/end key #2955)
HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.jsp while Master is initializing (HBASE-28778 NPE may occur when opening master-status or table.jsp or procedure.js… #6152)

Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 82e155e)

…he#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd)

Signed-off-by: Guangxu Cheng <[email protected]> (cherry picked from commit 9ad16aa)

…empty start key/end key (apache#2955) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Pankaj Kumar<[email protected]> (cherry picked from commit 157200e)

…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)

Apache-HBase · 2024-12-18T07:59:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 0s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	4m 26s		branch-2.6 passed
+1 💚	spotless	1m 3s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 56s		the patch passed
+1 💚	blanks	0m 1s		The patch has no blanks issues.
+1 💚	spotless	0m 46s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 21s		The patch does not generate ASF License warnings.
		13m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6550/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6550
Optional Tests	dupname asflicense javac codespell detsecrets spotless
uname	Linux 903841654ef0 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `59d05d6`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6550/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-18T11:08:38Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 47s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 42s		branch-2.6 passed
+1 💚	javadoc	0m 45s		branch-2.6 passed
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 46s		the patch passed
+1 💚	javadoc	0m 44s		the patch passed
			_ Other Tests _
-1 ❌	unit	182m 31s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
+1 💚	unit	8m 5s		hbase-thrift in the patch passed.
		202m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6550/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6550
Optional Tests	javac javadoc unit
uname	Linux d5ec75c3e92b 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `59d05d6`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6550/1/testReport/
Max. process+thread count	4288 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6550/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-18T11:13:12Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 13s		branch-2.6 passed
+1 💚	javadoc	0m 47s		branch-2.6 passed
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 7s		the patch passed
+1 💚	javadoc	0m 45s		the patch passed
			_ Other Tests _
+1 💚	unit	188m 19s		hbase-server in the patch passed.
+1 💚	unit	7m 44s		hbase-thrift in the patch passed.
		207m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6550/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6550
Optional Tests	javac javadoc unit
uname	Linux cce46f069979 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `59d05d6`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6550/1/testReport/
Max. process+thread count	4418 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6550/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-12-18T11:19:04Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2.6 Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 25s		branch-2.6 passed
+1 💚	javadoc	0m 44s		branch-2.6 passed
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 5s		the patch passed
+1 💚	javadoc	0m 41s		the patch passed
			_ Other Tests _
-1 ❌	unit	192m 26s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
+1 💚	unit	7m 18s		hbase-thrift in the patch passed.
		213m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6550/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6550
Optional Tests	javac javadoc unit
uname	Linux 5fe0462c0e77 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2.6 / `59d05d6`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6550/1/testReport/
Max. process+thread count	4079 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6550/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-12-19T05:59:45Z

Hi @PDavid please let me know once this PR is ready for review

PDavid · 2024-12-19T08:40:17Z

Hi @NihalJain,
Many thanks, I think this is now ready to review. Some tests failed in the PR build but I think they are not related.

bea0113 and others added 5 commits December 18, 2024 08:27

HBASE-18382 add transport type info into Thrift UI (apache#880)

3b3cb5d

Signed-off-by: Wellington Chevreuil <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 82e155e)

HBASE-20693 Refactor thrift jsp's and extract header and footer (apac…

ed3ad95

…he#5732) - Fixes the way logLevel page renders in UI Signed-off-by: Nick Dimiduk <[email protected]> (cherry picked from commit ede4ccd)

HBASE-24624 Optimize table.jsp code (apache#1963)

fc28cee

Signed-off-by: Guangxu Cheng <[email protected]> (cherry picked from commit 9ad16aa)

HBASE-25402 Sorting order by start key or end key is not considering …

9e4d233

…empty start key/end key (apache#2955) Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Pankaj Kumar<[email protected]> (cherry picked from commit 157200e)

HBASE-28778 NPE may occur when opening master-status or table.jsp or …

59d05d6

…procedure.jsp while Master is initializing (apache#6152) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit 3caaf2d)

PDavid mentioned this pull request Dec 18, 2024

HBASE-29036 Backport missing UI patches to branch-2.6 #6546

Closed

PDavid marked this pull request as ready for review December 19, 2024 08:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-29036 Backport missing UI patches to branch-2.6 #6550

HBASE-29036 Backport missing UI patches to branch-2.6 #6550

PDavid commented Dec 18, 2024

Apache-HBase commented Dec 18, 2024

Apache-HBase commented Dec 18, 2024

Apache-HBase commented Dec 18, 2024

Apache-HBase commented Dec 18, 2024

NihalJain commented Dec 19, 2024

PDavid commented Dec 19, 2024

HBASE-29036 Backport missing UI patches to branch-2.6 #6550

Are you sure you want to change the base?

HBASE-29036 Backport missing UI patches to branch-2.6 #6550

Conversation

PDavid commented Dec 18, 2024

Apache-HBase commented Dec 18, 2024

Apache-HBase commented Dec 18, 2024

Apache-HBase commented Dec 18, 2024

Apache-HBase commented Dec 18, 2024

NihalJain commented Dec 19, 2024

PDavid commented Dec 19, 2024