HBASE-28648 Change the deprecation cycle for RegionObserver.postInstantiateDeleteTracker #6133

2005hithlj · 2024-08-02T05:09:52Z

https://issues.apache.org/jira/browse/HBASE-28648

…ntiateDeleteTracker

2005hithlj · 2024-08-02T05:10:23Z

@Apache9 Could you take a look? Thanks.

Apache-HBase · 2024-08-02T05:56:31Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	3m 0s		master passed
+1 💚	compile	2m 58s		master passed
+1 💚	checkstyle	0m 38s		master passed
+1 💚	spotbugs	1m 35s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	3m 2s		the patch passed
+1 💚	javac	3m 2s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 38s		the patch passed
+1 💚	spotbugs	1m 40s		the patch passed
+1 💚	hadoopcheck	10m 30s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		35m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6133/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6133
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 689f94432af5 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `db6d7a1`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6133/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2024-08-02T08:46:11Z

hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java

@@ -1567,7 +1567,8 @@ default List<Pair<Cell, Cell>> postAppendBeforeWAL(
   * @param ctx        the environment provided by the region server
   * @param delTracker the deleteTracker that is created by the QueryMatcher
   * @return the Delete Tracker
-   * @deprecated Since 2.0 with out any replacement and will be removed in 3.0
+   * @deprecated Since 2.0, will be removed in 4.0. Visibility label feature still use this method,


Please change to '2.0.0', '4.0.0' and '3.0.0'

@Apache9 Thanks for your review. I have revised it. could you take a look? Thanks.

Apache-HBase · 2024-08-02T09:15:55Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 11s		master passed
+1 💚	compile	0m 55s		master passed
+1 💚	javadoc	0m 28s		master passed
+1 💚	shadedjars	5m 49s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 3s		the patch passed
+1 💚	compile	0m 57s		the patch passed
+1 💚	javac	0m 57s		the patch passed
+1 💚	javadoc	0m 27s		the patch passed
+1 💚	shadedjars	5m 44s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	210m 2s		hbase-server in the patch passed.
		235m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6133/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6133
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux bb1b92a44aa6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `db6d7a1`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6133/1/testReport/
Max. process+thread count	5049 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6133/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…ntiateDeleteTracker

Apache-HBase · 2024-08-02T11:11:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	2m 53s		master passed
+1 💚	compile	2m 58s		master passed
+1 💚	checkstyle	0m 36s		master passed
+1 💚	spotbugs	1m 32s		master passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	2m 57s		the patch passed
+1 💚	javac	2m 57s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 38s		the patch passed
+1 💚	spotbugs	1m 39s		the patch passed
+1 💚	hadoopcheck	10m 25s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 44s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 11s		The patch does not generate ASF License warnings.
		35m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6133/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6133
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 47d04dd12e70 5.4.0-186-generic #206-Ubuntu SMP Fri Apr 26 12:31:10 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31c6550`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6133/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-02T14:30:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
-0 ⚠️	yetus	0m 2s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	3m 3s		master passed
+1 💚	compile	0m 56s		master passed
+1 💚	javadoc	0m 26s		master passed
+1 💚	shadedjars	5m 44s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	3m 7s		the patch passed
+1 💚	compile	0m 57s		the patch passed
+1 💚	javac	0m 57s		the patch passed
+1 💚	javadoc	0m 26s		the patch passed
+1 💚	shadedjars	5m 45s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	209m 44s		hbase-server in the patch passed.
		234m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6133/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6133
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 65819338b38e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31c6550`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6133/2/testReport/
Max. process+thread count	4938 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6133/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

…ntiateDeleteTracker (#6133) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit edbb145)

HBASE-28648 Change the deprecation cycle for RegionObserver.postInsta…

db6d7a1

…ntiateDeleteTracker

Apache9 reviewed Aug 2, 2024

View reviewed changes

HBASE-28648 Change the deprecation cycle for RegionObserver.postInsta…

31c6550

…ntiateDeleteTracker

Apache9 approved these changes Aug 2, 2024

View reviewed changes

2005hithlj merged commit edbb145 into apache:master Aug 2, 2024
1 check passed

Apache9 pushed a commit that referenced this pull request Aug 5, 2024

HBASE-28648 Change the deprecation cycle for RegionObserver.postInsta…

b4e56fb

…ntiateDeleteTracker (#6133) Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit edbb145)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28648 Change the deprecation cycle for RegionObserver.postInstantiateDeleteTracker #6133

HBASE-28648 Change the deprecation cycle for RegionObserver.postInstantiateDeleteTracker #6133

2005hithlj commented Aug 2, 2024

2005hithlj commented Aug 2, 2024

Apache-HBase commented Aug 2, 2024

Apache9 Aug 2, 2024

2005hithlj Aug 2, 2024

Apache-HBase commented Aug 2, 2024

Apache-HBase commented Aug 2, 2024

Apache-HBase commented Aug 2, 2024

HBASE-28648 Change the deprecation cycle for RegionObserver.postInstantiateDeleteTracker #6133

HBASE-28648 Change the deprecation cycle for RegionObserver.postInstantiateDeleteTracker #6133

Conversation

2005hithlj commented Aug 2, 2024

2005hithlj commented Aug 2, 2024

Apache-HBase commented Aug 2, 2024

Apache9 Aug 2, 2024

Choose a reason for hiding this comment

2005hithlj Aug 2, 2024

Choose a reason for hiding this comment

Apache-HBase commented Aug 2, 2024

Apache-HBase commented Aug 2, 2024

Apache-HBase commented Aug 2, 2024