HBASE-28416 Remove hbase-examples from hbase-assembly #5739

stoty · 2024-03-04T05:35:10Z

No description provided.

Apache-HBase · 2024-03-04T06:09:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 4s	master passed
+1 💚	compile	0m 19s	master passed
+1 💚	shadedjars	5m 11s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 47s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	shadedjars	5m 9s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 18s	hbase-assembly in the patch passed.
		18m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5739
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4b3238ccc4f7 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/1/testReport/
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-assembly U: hbase-assembly
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-04T06:09:29Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 40s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	5m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 27s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	5m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 17s	hbase-assembly in the patch passed.
		19m 1s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5739
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ec5c47fcf98f 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/1/testReport/
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-assembly U: hbase-assembly
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-04T06:11:27Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 13s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	spotless	0m 43s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 1s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	5m 23s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 42s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 10s	The patch does not generate ASF License warnings.
		20m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5739
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile
uname	Linux 0676fae4b07e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-assembly U: hbase-assembly
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-04T06:11:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 28s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	5m 55s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 57s	the patch passed
+1 💚	compile	0m 18s	the patch passed
+1 💚	javac	0m 18s	the patch passed
+1 💚	shadedjars	5m 51s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 18s	hbase-assembly in the patch passed.
		21m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5739
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f32d582be182 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/1/testReport/
Max. process+thread count	80 (vs. ulimit of 30000)
modules	C: hbase-assembly U: hbase-assembly
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/1/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-03-05T03:47:38Z

We should also remove the include statement at https://github.com/apache/hbase/blob/master/hbase-assembly/src/main/assembly/hadoop-three-compat.xml#L43, right?

stoty · 2024-03-05T06:27:29Z

We should also remove the include statement at https://github.com/apache/hbase/blob/master/hbase-assembly/src/main/assembly/hadoop-three-compat.xml#L43, right?

I haven't noticed that.
Yes, we should.

stoty · 2024-03-05T07:18:18Z

Fixed the assembly descriptor problem noticed by @NihalJain .

stoty · 2024-03-05T07:21:26Z

Created an assembly and checked it.
hbase-examples is not present, and the curator versions are coming from Hadoop (i.e. 4.2.0) (as expected)

Apache-HBase · 2024-03-05T07:22:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 12s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	2m 23s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	5m 4s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 26s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	shadedjars	5m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 16s	hbase-assembly in the patch passed.
		17m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#5739
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 289d05bb70f6 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Temurin-1.8.0_352-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/2/testReport/
Max. process+thread count	64 (vs. ulimit of 30000)
modules	C: hbase-assembly U: hbase-assembly
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-05T07:24:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 14s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 2s	master passed
+1 💚	compile	0m 18s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 12s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 49s	the patch passed
+1 💚	compile	0m 19s	the patch passed
+1 💚	javac	0m 19s	the patch passed
+1 💚	shadedjars	5m 17s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 10s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 18s	hbase-assembly in the patch passed.
		18m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#5739
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f952b5d6c986 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Eclipse Adoptium-17.0.10+7
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/2/testReport/
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-assembly U: hbase-assembly
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-05T07:26:04Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 20s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	shadedjars	5m 48s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 11s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	2m 58s	the patch passed
+1 💚	compile	0m 20s	the patch passed
+1 💚	javac	0m 20s	the patch passed
+1 💚	shadedjars	5m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 9s	the patch passed
		_ Other Tests _
+1 💚	unit	0m 17s	hbase-assembly in the patch passed.
		20m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#5739
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cf0c46e364c1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Eclipse Adoptium-11.0.17+8
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/2/testReport/
Max. process+thread count	78 (vs. ulimit of 30000)
modules	C: hbase-assembly U: hbase-assembly
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-03-05T07:26:32Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	2m 59s	master passed
+1 💚	compile	0m 17s	master passed
+1 💚	spotless	0m 42s	branch has no errors when running spotless:check.
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 5s	the patch passed
+1 💚	compile	0m 17s	the patch passed
+1 💚	javac	0m 17s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	xml	0m 2s	The patch has no ill-formed XML file.
+1 💚	hadoopcheck	5m 30s	Patch does not cause any errors with Hadoop 3.3.6.
+1 💚	spotless	0m 41s	patch has no errors when running spotless:check.
		_ Other Tests _
+1 💚	asflicense	0m 8s	The patch does not generate ASF License warnings.
		20m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#5739
Optional Tests	dupname asflicense javac hadoopcheck spotless xml compile
uname	Linux 160e69213d01 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ede4ccd`
Default Java	Eclipse Adoptium-11.0.17+8
Max. process+thread count	79 (vs. ulimit of 30000)
modules	C: hbase-assembly U: hbase-assembly
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5739/2/console
versions	git=2.34.1 maven=3.8.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

taklwu

LGTM and merging soon

Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]>

Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]> Signed-off-by: Duo Zhang <[email protected]>

Signed-off-by: Andrew Purtell <[email protected]> Signed-off-by: Nihal Jain <[email protected]> Signed-off-by: Tak Lon (Stephen) Wu <[email protected]> Signed-off-by: Duo Zhang <[email protected]> (cherry picked from commit c1a11c0)

HBASE-28416 Remove hbase-examples from hbase-assembly

714fd45

apurtell approved these changes Mar 4, 2024

View reviewed changes

also remove from assembly xml

b99fb8b

NihalJain approved these changes Mar 5, 2024

View reviewed changes

taklwu approved these changes Mar 7, 2024

View reviewed changes

taklwu merged commit 3229250 into apache:master Mar 7, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28416 Remove hbase-examples from hbase-assembly #5739

HBASE-28416 Remove hbase-examples from hbase-assembly #5739

stoty commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

NihalJain commented Mar 5, 2024 •

edited

Loading

stoty commented Mar 5, 2024

stoty commented Mar 5, 2024

stoty commented Mar 5, 2024

Apache-HBase commented Mar 5, 2024

Apache-HBase commented Mar 5, 2024

Apache-HBase commented Mar 5, 2024

Apache-HBase commented Mar 5, 2024

taklwu left a comment

HBASE-28416 Remove hbase-examples from hbase-assembly #5739

HBASE-28416 Remove hbase-examples from hbase-assembly #5739

Conversation

stoty commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

Apache-HBase commented Mar 4, 2024

NihalJain commented Mar 5, 2024 • edited Loading

stoty commented Mar 5, 2024

stoty commented Mar 5, 2024

stoty commented Mar 5, 2024

Apache-HBase commented Mar 5, 2024

Apache-HBase commented Mar 5, 2024

Apache-HBase commented Mar 5, 2024

Apache-HBase commented Mar 5, 2024

taklwu left a comment

Choose a reason for hiding this comment

NihalJain commented Mar 5, 2024 •

edited

Loading