Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-28379 Upgrade thirdparty dep to 4.1.6 #5693

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

ndimiduk
Copy link
Member

Initial PR is pinned to SNAPSHOT built from apache/hbase-thirdparty#112 .

pom.xml Outdated Show resolved Hide resolved
@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@ndimiduk
Copy link
Member Author

jdk8 we get,

[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR] org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush.null
[ERROR]   Run 1: TestHRegionWithInMemoryFlush>TestHRegion.testMutateRowInParallel:7456->Object.wait:-2 » TestTimedOut test timed out after 780 seconds
[ERROR]   Run 2: TestHRegionWithInMemoryFlush>TestHRegion.lambda$testMutateRowInParallel$3:7428 »  Appears to be stuck in thread Thread-6326
[INFO] 
[INFO] 
[ERROR] Tests run: 6937, Failures: 0, Errors: 1, Skipped: 36

jdk11 give us

[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR] org.apache.hadoop.hbase.TestAcidGuaranteesWithBasicPolicy.null
[ERROR]   Run 1: TestAcidGuaranteesWithBasicPolicy>AcidGuaranteesTestBase.testMobGetAtomicity:122->AcidGuaranteesTestBase.runTestAtomicity:102->Object.wait:-2 » TestTimedOut test timed out after 780 seconds
[ERROR]   Run 2: TestAcidGuaranteesWithBasicPolicy »  Appears to be stuck in thread MiniHBaseClusterRegionServer-EventLoopGroup-3-1
[INFO] 
[WARNING] Flakes: 
[WARNING] org.apache.hadoop.hbase.replication.TestReplicationEmptyWALRecovery.testReplicationOfEmptyWALSurroundedNonEmptyWAL
[ERROR]   Run 1: TestReplicationEmptyWALRecovery.testReplicationOfEmptyWALSurroundedNonEmptyWAL:313 Replicated entries are not correct expected:<40> but was:<20>
[INFO]   Run 2: PASS
[INFO] 
[WARNING] org.apache.hadoop.hbase.replication.multiwal.TestReplicationEndpointWithMultipleAsyncWAL.testInterClusterReplication
[ERROR]   Run 1: TestReplicationEndpointWithMultipleAsyncWAL>TestReplicationEndpoint.testInterClusterReplication:244 Waiting timed out after [30,000] msec Failed to replicate all edits, expected = 2500 replicated = 2488
[INFO]   Run 2: PASS
[INFO] 
[INFO] 
[ERROR] Tests run: 6941, Failures: 0, Errors: 1, Skipped: 36, Flakes: 2

@ndimiduk
Copy link
Member Author

ndimiduk commented Feb 21, 2024

In local testing, TestHRegionWithInMemoryFlush is broken on master using both jdk8 and jdk11, with and without this patch. Same failure mode -- hmaster startup timeout -- though in different test methods each time.

https://issues.apache.org/jira/browse/HBASE-28387

@ndimiduk
Copy link
Member Author

TestAcidGuaranteesWithBasicPolicy passes for me locally, with and without this patch.

@ndimiduk ndimiduk marked this pull request as ready for review February 22, 2024 07:15
Copy link
Contributor

@NihalJain NihalJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to non-snapshot before merge.

@ndimiduk ndimiduk force-pushed the 28379-thirdparty-4.1.6 branch from f795b4b to 57e5347 Compare February 23, 2024 08:59
@Apache-HBase

This comment was marked as outdated.

@ndimiduk
Copy link
Member Author

Okay strange. The shade plugin version bump isn't picked up in the yetus build. Its respected locally though...

@ndimiduk ndimiduk force-pushed the 28379-thirdparty-4.1.6 branch from 6777479 to 80d0be0 Compare February 23, 2024 12:48
@ndimiduk
Copy link
Member Author

Trying squish the commit history.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase

This comment was marked as outdated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for branch
+1 💚 mvninstall 4m 25s master passed
+1 💚 compile 7m 8s master passed
+1 💚 spotless 0m 52s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 4m 9s the patch passed
+1 💚 compile 6m 47s the patch passed
+1 💚 javac 6m 47s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 10s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 5m 54s Patch does not cause any errors with Hadoop 3.3.6.
+1 💚 spotless 0m 51s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
39m 24s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5693
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux cff1a651f05d 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c4a02f7
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 24s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
+1 💚 mvninstall 3m 29s master passed
+1 💚 compile 1m 56s master passed
+1 💚 shadedjars 6m 14s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 11s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 31s Maven dependency ordering for patch
+1 💚 mvninstall 2m 58s the patch passed
+1 💚 compile 2m 15s the patch passed
+1 💚 javac 2m 15s the patch passed
+1 💚 shadedjars 5m 47s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 54s the patch passed
_ Other Tests _
-1 ❌ unit 389m 15s root in the patch failed.
423m 3s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 3767f763a320 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / c4a02f7
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/testReport/
Max. process+thread count 5818 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/5/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

ndimiduk added 2 commits March 4, 2024 12:33
Also bump maven-shade-plugin version to support jackson upgrade and JDK21 bytecode class version
65
@ndimiduk ndimiduk force-pushed the 28379-thirdparty-4.1.6 branch from e540f7b to 856d3bd Compare March 4, 2024 11:34
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 2m 52s master passed
+1 💚 compile 4m 54s master passed
+1 💚 spotless 0m 42s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 2m 46s the patch passed
+1 💚 compile 4m 53s the patch passed
+1 💚 javac 4m 53s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 5s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 4m 48s Patch does not cause any errors with Hadoop 3.3.6.
+1 💚 spotless 0m 42s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
29m 53s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #5693
Optional Tests dupname asflicense javac hadoopcheck spotless xml compile
uname Linux 604a976521cc 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd
Default Java Eclipse Adoptium-11.0.17+8
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for branch
+1 💚 mvninstall 3m 1s master passed
+1 💚 compile 2m 6s master passed
+1 💚 shadedjars 5m 18s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 41s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 2m 53s the patch passed
+1 💚 compile 2m 7s the patch passed
+1 💚 javac 2m 7s the patch passed
+1 💚 shadedjars 5m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 45s the patch passed
_ Other Tests _
+1 💚 unit 285m 17s root in the patch passed.
319m 18s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #5693
Optional Tests javac javadoc unit shadedjars compile
uname Linux e2078314aaa3 5.4.0-172-generic #190-Ubuntu SMP Fri Feb 2 23:24:22 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd
Default Java Eclipse Adoptium-17.0.10+7
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/testReport/
Max. process+thread count 8615 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 50s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 4m 5s master passed
+1 💚 compile 2m 47s master passed
+1 💚 shadedjars 6m 4s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 43s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 3m 51s the patch passed
+1 💚 compile 2m 33s the patch passed
+1 💚 javac 2m 33s the patch passed
+1 💚 shadedjars 6m 29s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 47s the patch passed
_ Other Tests _
-1 ❌ unit 369m 29s root in the patch failed.
410m 34s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #5693
Optional Tests javac javadoc unit shadedjars compile
uname Linux f3d5dbd2a5ce 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd
Default Java Eclipse Adoptium-11.0.17+8
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/testReport/
Max. process+thread count 5312 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 50s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for branch
+1 💚 mvninstall 3m 40s master passed
+1 💚 compile 2m 21s master passed
+1 💚 shadedjars 6m 11s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 36s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for patch
+1 💚 mvninstall 3m 24s the patch passed
+1 💚 compile 2m 17s the patch passed
+1 💚 javac 2m 17s the patch passed
+1 💚 shadedjars 6m 25s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 2m 22s the patch passed
_ Other Tests _
-1 ❌ unit 456m 48s root in the patch failed.
494m 5s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #5693
Optional Tests javac javadoc unit shadedjars compile
uname Linux 75631bbf4d70 5.4.0-169-generic #187-Ubuntu SMP Thu Nov 23 14:52:28 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ede4ccd
Default Java Temurin-1.8.0_352-b08
unit https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/testReport/
Max. process+thread count 6477 (vs. ulimit of 30000)
modules C: hbase-protocol-shaded hbase-examples hbase-shaded . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5693/6/console
versions git=2.34.1 maven=3.8.6
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@ndimiduk ndimiduk merged commit 4f97ece into apache:master Mar 5, 2024
1 check failed
@ndimiduk ndimiduk deleted the 28379-thirdparty-4.1.6 branch March 5, 2024 08:01
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Mar 5, 2024
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Mar 5, 2024
ndimiduk added a commit to ndimiduk/hbase that referenced this pull request Mar 5, 2024
ndimiduk added a commit that referenced this pull request Mar 5, 2024
Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Pankaj Kumar < [email protected]>
ndimiduk added a commit that referenced this pull request Mar 5, 2024
Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Pankaj Kumar < [email protected]>
ndimiduk added a commit that referenced this pull request Mar 5, 2024
Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Pankaj Kumar < [email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants