HBASE-28777 mTLS client hostname verification doesn't work with OptionalSslHandler #6149

anmolnar · 2024-08-12T19:41:42Z

Added our version of OptionalSslHandler which carries hostport information
Removed the (IMHO) unnecessary reverse DNS lookup from initSSL
Unit test to cover plaintext and TLS-only cases

Apache-HBase · 2024-08-12T20:30:03Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 26s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 3s		master passed
+1 💚	compile	3m 40s		master passed
+1 💚	checkstyle	0m 48s		master passed
+1 💚	spotbugs	2m 0s		master passed
+1 💚	spotless	0m 44s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	3m 37s		the patch passed
+1 💚	javac	3m 37s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 13s	/results-checkstyle-hbase-common.txt	hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	spotbugs	2m 15s		the patch passed
+1 💚	hadoopcheck	10m 56s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 42s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 18s		The patch does not generate ASF License warnings.
		39m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6149/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6149
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux d031819bd2cb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c9dabc1`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	84 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6149/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-12T23:58:51Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 16s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 8s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 3s		master passed
+1 💚	compile	1m 18s		master passed
+1 💚	javadoc	0m 48s		master passed
+1 💚	shadedjars	5m 24s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	1m 20s		the patch passed
+1 💚	javac	1m 20s		the patch passed
+1 💚	javadoc	0m 47s		the patch passed
+1 💚	shadedjars	5m 19s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	2m 20s		hbase-common in the patch passed.
-1 ❌	unit	219m 55s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		248m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6149/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6149
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 15157a41a31b 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c9dabc1`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6149/1/testReport/
Max. process+thread count	5754 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6149/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-13T02:14:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 50s		master passed
+1 💚	compile	3m 32s		master passed
+1 💚	checkstyle	0m 47s		master passed
+1 💚	spotbugs	1m 58s		master passed
+1 💚	spotless	0m 41s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 57s		the patch passed
+1 💚	compile	3m 33s		the patch passed
+1 💚	javac	3m 33s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 13s	/results-checkstyle-hbase-common.txt	hbase-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
+1 💚	spotbugs	2m 11s		the patch passed
+1 💚	hadoopcheck	10m 33s		Patch does not cause any errors with Hadoop 3.3.6 3.4.0.
+1 💚	spotless	0m 41s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 16s		The patch does not generate ASF License warnings.
		38m 33s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6149/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6149
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux a8865ba37cfd 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5837eda`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6149/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-08-13T05:42:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 13s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 54s		master passed
+1 💚	compile	1m 19s		master passed
+1 💚	javadoc	0m 47s		master passed
+1 💚	shadedjars	5m 17s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 55s		the patch passed
+1 💚	compile	1m 21s		the patch passed
+1 💚	javac	1m 21s		the patch passed
+1 💚	javadoc	0m 46s		the patch passed
+1 💚	shadedjars	5m 20s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	2m 20s		hbase-common in the patch passed.
+1 💚	unit	219m 7s		hbase-server in the patch passed.
		247m 16s

Subsystem	Report/Notes
Docker	ClientAPI=1.46 ServerAPI=1.46 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6149/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6149
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux b034455aca04 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `5837eda`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6149/2/testReport/
Max. process+thread count	5724 (vs. ulimit of 30000)
modules	C: hbase-common hbase-server U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6149/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

anmolnar · 2024-08-15T14:49:17Z

@meszibalu @bbeaudreault PTAL.

…nalSslHandler (#6149) Signed-off-by: Balazs Meszaros <[email protected]>

…nalSslHandler (apache#6149) Signed-off-by: Balazs Meszaros <[email protected]>

anmolnar added 3 commits August 12, 2024 13:06

HBASE-28777. Add hostport information to OptionalSslHandler, unit tests

91deb41

HBASE-28777. Unit tests

eb4c47c

HBASE-28777. Spotless apply

c9dabc1

anmolnar requested review from meszibalu and bbeaudreault August 12, 2024 19:41

HBASE-28777. Fix copy-paste issue

5837eda

meszibalu approved these changes Aug 26, 2024

View reviewed changes

anmolnar merged commit 27684d0 into apache:master Aug 28, 2024
1 check passed

anmolnar deleted the HBASE-28777 branch August 28, 2024 15:13

anmolnar added a commit that referenced this pull request Aug 28, 2024

HBASE-28777 mTLS client hostname verification doesn't work with Optio…

1fa1f13

…nalSslHandler (#6149) Signed-off-by: Balazs Meszaros <[email protected]>

anmolnar added a commit to anmolnar/hbase that referenced this pull request Aug 28, 2024

HBASE-28777 mTLS client hostname verification doesn't work with Optio…

8282734

…nalSslHandler (apache#6149) Signed-off-by: Balazs Meszaros <[email protected]>

anmolnar added a commit to anmolnar/hbase that referenced this pull request Aug 28, 2024

HBASE-28777 mTLS client hostname verification doesn't work with Optio…

f077349

…nalSslHandler (apache#6149) Signed-off-by: Balazs Meszaros <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-28777 mTLS client hostname verification doesn't work with OptionalSslHandler #6149

HBASE-28777 mTLS client hostname verification doesn't work with OptionalSslHandler #6149

anmolnar commented Aug 12, 2024

Apache-HBase commented Aug 12, 2024

Apache-HBase commented Aug 12, 2024

Apache-HBase commented Aug 13, 2024

Apache-HBase commented Aug 13, 2024

anmolnar commented Aug 15, 2024

HBASE-28777 mTLS client hostname verification doesn't work with OptionalSslHandler #6149

HBASE-28777 mTLS client hostname verification doesn't work with OptionalSslHandler #6149

Conversation

anmolnar commented Aug 12, 2024

Apache-HBase commented Aug 12, 2024

Apache-HBase commented Aug 12, 2024

Apache-HBase commented Aug 13, 2024

Apache-HBase commented Aug 13, 2024

anmolnar commented Aug 15, 2024