This repository has been archived by the owner on May 30, 2024. It is now read-only.
Update SwiftLint to 0.47.1 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have two Buildkite agents thanks to a newly added M1 Mac mini from MacStadium. Running the analyze job should be considerably faster than the VMs that run on Azure Pipelines, although still slower than if we were to run them with Xcode 13.2.1 because of the performance regressions described in #3920.
* Only skip autocorrect on files with errors * Use other kind of warning so tests succeed on Linux * Update CHANGELOG.md Co-authored-by: JP Simard <[email protected]> Co-authored-by: JP Simard <[email protected]>
Bumps [cocoapods-downloader](https://github.com/CocoaPods/cocoapods-downloader) from 1.4.0 to 1.6.3. - [Release notes](https://github.com/CocoaPods/cocoapods-downloader/releases) - [Changelog](https://github.com/CocoaPods/cocoapods-downloader/blob/master/CHANGELOG.md) - [Commits](CocoaPods/cocoapods-downloader@1.4.0...1.6.3) --- updated-dependencies: - dependency-name: cocoapods-downloader dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
So tests don't fail on whatever the next Swift releases are.
Warns if a SwiftUI Image does not have an accessibility label and is not hidden from accessibility. When this is the case, the image's accessibility label defaults to the name of the image file causing a poor UX.
* [CI] Update to Xcode 13.3.1 * Update jazzy
…ment (#3952) There is no real benefit for this option. Files and folders to lint/analyze can be passed to `swiftlint` as last arguments. There cannot be multiple `--path` arguments. If there is more than one only the last path is considered.
This hasn't been properly supported for years. Fixes #3782
…false-positives (#4000)
It was just "warning". Now it is the description of the rule (default).
This makes the added test cases work in Xcode 13.2 where the wrapping does not happen. The call expression is the first substructure in the dictionary, while in Xcode 13.3 it's an argument containing the call expression.
…cks are involved (#4002)
* Support arrays for `included` & `excluded` in custom rules * Extract shouldValidate(filePath:) and add tests
i-pavlov
approved these changes
Jul 5, 2022
siwasit-anmahapong-agoda
pushed a commit
to siwasit-anmahapong-agoda/SwiftLint
that referenced
this pull request
May 9, 2023
This frequently crashes and I don't think it's due to a real TSan race. E.g. https://buildkite.com/swiftlint/swiftlint/builds/4912#0185c098-a803-4525-8df1-827d1c97ed01 ``` swiftlint(373,0x1ecdd3a80) malloc: nano zone abandoned due to inability to preallocate reserved vm space. Linting Swift files in current working directory 1 of 538 [ ] ETA: 0s (13129 files/s) PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace. ThreadSanitizer:DEADLYSIGNAL ==373==ERROR: ThreadSanitizer: SEGV on unknown address 0x000000000008 (pc 0x000102cbe380 bp 0x00016f50ee00 sp 0x00016f50edc0 T30753687) ==373==The signal is caused by a UNKNOWN memory access. ==373==Hint: address points to the zero page. #0 __tsan::ThreadClock::release(__tsan::DenseSlabAllocCache*, __tsan::SyncClock*) <null>:46801128 (libclang_rt.tsan_osx_dynamic.dylib:arm64e+0x2a380) agoda-com#1 __tsan::Release(__tsan::ThreadState*, unsigned long, unsigned long) <null>:46801128 (libclang_rt.tsan_osx_dynamic.dylib:arm64e+0x7456c) agoda-com#2 swift::runJobInEstablishedExecutorContext(swift::Job*) <null>:46801128 (libswift_Concurrency.dylib:arm64e+0x40588) agoda-com#3 swift_job_runImpl(swift::Job*, swift::ExecutorRef) <null>:46801128 (libswift_Concurrency.dylib:arm64e+0x41404) agoda-com#4 _dispatch_root_queue_drain <null>:46801128 (libdispatch.dylib:arm64e+0x15f90) agoda-com#5 _dispatch_worker_thread2 <null>:46801128 (libdispatch.dylib:arm64e+0x167bc) realm#6 _pthread_wqthread <null>:46801128 (libsystem_pthread.dylib:arm64e+0x30c0) realm#7 start_wqthread <null>:46801128 (libsystem_pthread.dylib:arm64e+0x1e1c) ==373==Register values: x[0] = 0x0000000102a53458 x[1] = 0x0000000000000538 x[2] = 0x0000000000000000 x[3] = 0x0000000000000000 x[4] = 0x0000000000000001 x[5] = 0x0000000000000000 x[6] = 0x0095000004220122 x[7] = 0x0000000000000001 x[8] = 0x0000000000000008 x[9] = 0x0000000000000000 x[10] = 0x0000000000000000 x[11] = 0x0000000000000000 x[12] = 0x0000000000000020 x[13] = 0x0000000110904040 x[14] = 0x0000000000000000 x[15] = 0x0000000106251910 x[16] = 0x0000000104190960 x[17] = 0x0000000000200018 x[18] = 0x0000000000000000 x[19] = 0x000000010f5d3488 x[20] = 0x0000000109ca03f0 x[21] = 0x0000000102a53458 x[22] = 0x0000000109ca03f0 x[23] = 0x0000000109cc0078 x[24] = 0x00040c0000fd77c4 x[25] = 0x0000010000000000 x[26] = 0x00000002287898f8 x[27] = 0x0000000000000000 x[28] = 0x000000016f50f0e0 fp = 0x000000016f50ee00 lr = 0x0000000102cbe360 sp = 0x000000016f50edc0 ThreadSanitizer can not provide additional info. SUMMARY: ThreadSanitizer: SEGV (libclang_rt.tsan_osx_dynamic.dylib:arm64e+0x2a380) in __tsan::ThreadClock::release(__tsan::DenseSlabAllocCache*, __tsan::SyncClock*)+0x174 ==373==ABORTING ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetched upstream from
realm/SwiftLint