Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rule Request] Prefer comma-separated inheritance #3950

Closed
2 tasks done
marcelofabri opened this issue Apr 13, 2022 · 0 comments · Fixed by #3954
Closed
2 tasks done

[Rule Request] Prefer comma-separated inheritance #3950

marcelofabri opened this issue Apr 13, 2022 · 0 comments · Fixed by #3954
Labels
rule-request Requests for a new rules.

Comments

@marcelofabri
Copy link
Collaborator

marcelofabri commented Apr 13, 2022

New Issue Checklist

New rule request

  1. Why should this rule be added? Share links to existing discussion about what
    the community thinks about this.

I don't think I've ever seen this mentioned in any style guide, but my gut feeling is that using commas is way more popular - especially since the & syntax came later in Swift's life.

  1. Provide several examples of what would and wouldn't trigger violations.
// triggers
struct Size: Codable & Equatable {
  let width: Int
  let height: Int
}

// ok
struct Size: Codable, Equatable {
  let width: Int
  let height: Int
}
  1. Should the rule be configurable, if so what parameters should be configurable?

Just severity

  1. Should the rule be opt-in or enabled by default? Why?
    See README.md for guidelines on when to mark a rule as opt-in.

I think this is popular enough that it can be enabled by default.

@marcelofabri marcelofabri added the rule-request Requests for a new rules. label Apr 13, 2022
marcelofabri added a commit that referenced this issue Apr 16, 2022
marcelofabri added a commit that referenced this issue Apr 17, 2022
marcelofabri added a commit that referenced this issue Apr 17, 2022
marcelofabri added a commit that referenced this issue Apr 17, 2022
marcelofabri added a commit that referenced this issue Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rule-request Requests for a new rules.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant