Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arrays for included & excluded in custom rules #4006

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

marcelofabri
Copy link
Collaborator

In certain cases, it's easier to specify multiple patterns than combining everything in one.

@SwiftLintBot
Copy link

SwiftLintBot commented Jun 24, 2022

12 Messages
📖 Linting Aerial with this PR took 0.98s vs 0.98s on master (0% slower)
📖 Linting Alamofire with this PR took 1.09s vs 1.1s on master (0% faster)
📖 Linting Firefox with this PR took 4.35s vs 4.34s on master (0% slower)
📖 Linting Kickstarter with this PR took 7.54s vs 7.55s on master (0% faster)
📖 Linting Moya with this PR took 0.57s vs 0.53s on master (7% slower)
📖 Linting Nimble with this PR took 0.41s vs 0.41s on master (0% slower)
📖 Linting Quick with this PR took 0.19s vs 0.18s on master (5% slower)
📖 Linting Realm with this PR took 9.94s vs 9.94s on master (0% slower)
📖 Linting SourceKitten with this PR took 0.34s vs 0.34s on master (0% slower)
📖 Linting Sourcery with this PR took 2.04s vs 2.03s on master (0% slower)
📖 Linting Swift with this PR took 3.42s vs 3.41s on master (0% slower)
📖 Linting WordPress with this PR took 8.1s vs 8.08s on master (0% slower)

Generated by 🚫 Danger

Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have one remark regarding tests, though:

@codecov-commenter
Copy link

Codecov Report

Merging #4006 (eb1ef78) into master (04972a3) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4006      +/-   ##
==========================================
- Coverage   92.55%   92.43%   -0.12%     
==========================================
  Files         446      447       +1     
  Lines       22492    22605     +113     
==========================================
+ Hits        20817    20896      +79     
- Misses       1675     1709      +34     
Impacted Files Coverage Δ
.../Rules/RuleConfigurations/RegexConfiguration.swift 91.02% <100.00%> (+2.31%) ⬆️
...e/SwiftLintFramework/Rules/Style/CustomRules.swift 100.00% <100.00%> (ø)
...sts/SwiftLintFrameworkTests/CustomRulesTests.swift 94.04% <100.00%> (+0.25%) ⬆️
...ftLintFrameworkTests/RegexConfigurationTests.swift 100.00% <100.00%> (ø)
...ork/Rules/Idiomatic/UnavailableConditionRule.swift 4.16% <0.00%> (-6.95%) ⬇️
Source/SwiftLintFramework/Models/Linter.swift 82.77% <0.00%> (-1.67%) ⬇️
...iftLintFramework/Extensions/String+SwiftLint.swift 90.00% <0.00%> (-0.91%) ⬇️
...SwiftLintFrameworkTests/StringExtensionTests.swift 100.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@marcelofabri marcelofabri merged commit a19ffdd into master Jun 27, 2022
@marcelofabri marcelofabri deleted the marcelo/custom-rules-excluded-included-arrays branch June 27, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants