Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only skip autocorrect on files with errors #3933

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

marcelofabri
Copy link
Collaborator

No description provided.

@marcelofabri marcelofabri requested a review from jpsim April 5, 2022 01:00
@SwiftLintBot
Copy link

SwiftLintBot commented Apr 5, 2022

12 Messages
📖 Linting Aerial with this PR took 0.97s vs 0.98s on master (1% faster)
📖 Linting Alamofire with this PR took 1.09s vs 1.11s on master (1% faster)
📖 Linting Firefox with this PR took 4.1s vs 4.18s on master (1% faster)
📖 Linting Kickstarter with this PR took 7.34s vs 7.47s on master (1% faster)
📖 Linting Moya with this PR took 4.31s vs 4.42s on master (2% faster)
📖 Linting Nimble with this PR took 0.39s vs 0.4s on master (2% faster)
📖 Linting Quick with this PR took 0.16s vs 0.17s on master (5% faster)
📖 Linting Realm with this PR took 9.95s vs 9.69s on master (2% slower)
📖 Linting SourceKitten with this PR took 0.33s vs 0.33s on master (0% slower)
📖 Linting Sourcery with this PR took 2.03s vs 2.05s on master (0% faster)
📖 Linting Swift with this PR took 3.16s vs 3.16s on master (0% slower)
📖 Linting WordPress with this PR took 7.49s vs 7.49s on master (0% slower)

Generated by 🚫 Danger

@codecov-commenter
Copy link

Codecov Report

Merging #3933 (18767ea) into master (e92a3ae) will increase coverage by 0.03%.
The diff coverage is 97.29%.

@@            Coverage Diff             @@
##           master    #3933      +/-   ##
==========================================
+ Coverage   92.57%   92.60%   +0.03%     
==========================================
  Files         441      441              
  Lines       22174    22203      +29     
==========================================
+ Hits        20527    20561      +34     
+ Misses       1647     1642       -5     
Impacted Files Coverage Δ
Source/SwiftLintFramework/Models/Linter.swift 82.22% <87.50%> (+3.12%) ⬆️
...iftLintFrameworkTests/ParserDiagnosticsTests.swift 100.00% <100.00%> (ø)
Tests/SwiftLintFrameworkTests/TestHelpers.swift 79.08% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: JP Simard <[email protected]>
@marcelofabri marcelofabri merged commit 0fbf010 into master Apr 5, 2022
@marcelofabri marcelofabri deleted the marcelo/warnings-dont-skip branch April 5, 2022 17:59
coffmark pushed a commit to coffmark/SwiftLint that referenced this pull request Apr 10, 2022
* Only skip autocorrect on files with errors

* Use other kind of warning so tests succeed on Linux

* Update CHANGELOG.md

Co-authored-by: JP Simard <[email protected]>

Co-authored-by: JP Simard <[email protected]>
coffmark added a commit to coffmark/SwiftLint that referenced this pull request Apr 11, 2022
coffmark pushed a commit to coffmark/SwiftLint that referenced this pull request Apr 11, 2022
* Only skip autocorrect on files with errors

* Use other kind of warning so tests succeed on Linux

* Update CHANGELOG.md

Co-authored-by: JP Simard <[email protected]>

Co-authored-by: JP Simard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants