-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent crash for private types named _
in type_name
rules
#3972
Conversation
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #3972 +/- ##
==========================================
- Coverage 92.55% 92.55% -0.01%
==========================================
Files 446 446
Lines 22490 22490
==========================================
- Hits 20816 20815 -1
- Misses 1674 1675 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the bug report and your contribution!
Would you please add a test case that had caused the crash? You can do it like:
Example("...", excludeFromDocumentation: true)
The excludeFromDocumentation
keeps the documentation clean and simple.
You may also credit yourself in the CHANGELOG.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the tests! Now we just have to find the right place for them. 😉
_
in type_name
rules
Adds “Prevent crash for private types named `_` in type_name rules”
Fixes #3971