Prevent type name’s out of bounds crashes

realm · May 8, 2022 · 3206d1b · 3206d1b
1 parent ca9217d
commit 3206d1b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Source/SwiftLintFramework/Rules/Idiomatic/GenericTypeNameRule.swift b/Source/SwiftLintFramework/Rules/Idiomatic/GenericTypeNameRule.swift
@@ -69,7 +69,7 @@ public struct GenericTypeNameRule: ASTRule, ConfigurationProviderRule {
                                reason: "Generic type name should only contain alphanumeric characters: '\(name)'")
             ]
         } else if configuration.validatesStartWithLowercase &&
-            !String(name[name.startIndex]).isUppercase() {
+            name.first?.isLowercase == true {
             return [
                 StyleViolation(ruleDescription: Self.description,
                                severity: .error,

diff --git a/Source/SwiftLintFramework/Rules/Idiomatic/TypeNameRule.swift b/Source/SwiftLintFramework/Rules/Idiomatic/TypeNameRule.swift
@@ -48,7 +48,7 @@ public struct TypeNameRule: ASTRule, ConfigurationProviderRule {
                                    location: Location(file: file, byteOffset: offset),
                                    reason: "Type name should only contain alphanumeric characters: '\(name)'")]
         } else if configuration.validatesStartWithLowercase &&
-            !String(name[name.startIndex]).isUppercase() {
+            name.first?.isLowercase == true {
             return [StyleViolation(ruleDescription: Self.description,
                                    severity: .error,
                                    location: Location(file: file, byteOffset: offset),