Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unavailable_condition rule #3953

Merged
merged 1 commit into from
Apr 17, 2022
Merged

Conversation

marcelofabri
Copy link
Collaborator

Fixes #3897

@SwiftLintBot
Copy link

4 Warnings
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/AerialView.swift:182:12: warning: Unavailable Condition Violation: Use #unavailable instead of #available with an empty body. (unavailable_condition)
⚠️ This PR introduced a violation in Aerial: /Aerial/Source/Views/PrefPanel/InfoWeatherView.swift:41:12: warning: Unavailable Condition Violation: Use #unavailable instead of #available with an empty body. (unavailable_condition)
⚠️ This PR introduced a violation in Aerial: /Resources/MainUI/First time setup/VideoFormatViewController.swift:30:12: warning: Unavailable Condition Violation: Use #unavailable instead of #available with an empty body. (unavailable_condition)
⚠️ This PR introduced a violation in Realm: /examples/ios/swift/ListSwiftUI/Views/ContentView.swift:271:20: warning: Unavailable Condition Violation: Use #unavailable instead of #available with an empty body. (unavailable_condition)
12 Messages
📖 Linting Aerial with this PR took 0.99s vs 0.98s on master (1% slower)
📖 Linting Alamofire with this PR took 1.12s vs 1.12s on master (0% slower)
📖 Linting Firefox with this PR took 4.24s vs 4.2s on master (0% slower)
📖 Linting Kickstarter with this PR took 7.51s vs 7.46s on master (0% slower)
📖 Linting Moya with this PR took 4.38s vs 4.39s on master (0% faster)
📖 Linting Nimble with this PR took 0.4s vs 0.4s on master (0% slower)
📖 Linting Quick with this PR took 0.18s vs 0.18s on master (0% slower)
📖 Linting Realm with this PR took 10.22s vs 9.99s on master (2% slower)
📖 Linting SourceKitten with this PR took 0.34s vs 0.33s on master (3% slower)
📖 Linting Sourcery with this PR took 2.04s vs 2.02s on master (0% slower)
📖 Linting Swift with this PR took 3.25s vs 3.22s on master (0% slower)
📖 Linting WordPress with this PR took 7.59s vs 7.53s on master (0% slower)

Generated by 🚫 Danger

@codecov-commenter
Copy link

Codecov Report

Merging #3953 (f800663) into master (291b500) will decrease coverage by 0.04%.
The diff coverage is 19.04%.

@@            Coverage Diff             @@
##           master    #3953      +/-   ##
==========================================
- Coverage   92.61%   92.57%   -0.05%     
==========================================
  Files         441      442       +1     
  Lines       22239    22260      +21     
==========================================
+ Hits        20597    20607      +10     
- Misses       1642     1653      +11     
Impacted Files Coverage Δ
...ork/Rules/Idiomatic/UnavailableConditionRule.swift 10.52% <10.52%> (ø)
...tFrameworkTests/AutomaticRuleTests.generated.swift 100.00% <100.00%> (ø)
Tests/SwiftLintFrameworkTests/TestHelpers.swift 79.65% <0.00%> (+0.57%) ⬆️
Source/SwiftLintFramework/Models/Linter.swift 84.44% <0.00%> (+2.22%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@SimplyDanny SimplyDanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcelofabri marcelofabri merged commit 1752587 into master Apr 17, 2022
@marcelofabri marcelofabri deleted the marcelo/unavailable_condition branch April 17, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rule Request] Prefer #unavailable
4 participants