Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URL(fileURLWithPath:isDirectory) to avoid file system call #3976

Merged
merged 1 commit into from
May 26, 2022

Conversation

marcelofabri
Copy link
Collaborator

Probably not going to make a huge impact, but I'll take anything that can make SwiftLint faster

https://twitter.com/bwebster/status/1111035640223678464

@SwiftLintBot
Copy link

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
12 Messages
📖 Linting Aerial with this PR took 0.98s vs 0.98s on master (0% slower)
📖 Linting Alamofire with this PR took 1.1s vs 1.1s on master (0% slower)
📖 Linting Firefox with this PR took 4.22s vs 4.22s on master (0% slower)
📖 Linting Kickstarter with this PR took 7.46s vs 7.5s on master (0% faster)
📖 Linting Moya with this PR took 0.51s vs 0.56s on master (8% faster)
📖 Linting Nimble with this PR took 0.41s vs 0.41s on master (0% slower)
📖 Linting Quick with this PR took 0.19s vs 0.18s on master (5% slower)
📖 Linting Realm with this PR took 10.18s vs 9.97s on master (2% slower)
📖 Linting SourceKitten with this PR took 0.34s vs 0.34s on master (0% slower)
📖 Linting Sourcery with this PR took 2.01s vs 2.0s on master (0% slower)
📖 Linting Swift with this PR took 3.2s vs 3.2s on master (0% slower)
📖 Linting WordPress with this PR took 7.77s vs 7.81s on master (0% faster)

Here's an example of your CHANGELOG entry:

* Use URL(fileURLWithPath:isDirectory) to avoid file system call.  
  [marcelofabri](https://github.com/marcelofabri)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@marcelofabri marcelofabri marked this pull request as ready for review May 26, 2022 19:54
@marcelofabri marcelofabri merged commit 4382ef4 into master May 26, 2022
@marcelofabri marcelofabri deleted the marcelo/url-is-directory branch May 26, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants