chore: merge master #1786
Merged
chore: merge master #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it does not make sense to render the InstallButton when the installation is in progress or finished. The same apply for the login screen, product selection, and product progress.
Changing the default focus in the confirmation dialog from 'Continue' to
'Cancel' to avoid the user triggering the installation because
accidentally sending the {enter} keystroke.
sles_enhanced_base pattern was removed from SLES 16 and replaced by base pattern
To avoid circular dependencies.
Agama-weblate commit: f986d72e1d4c02b8baa9e9ee27defde2c6d2f186
Agama-weblate commit: f986d72e1d4c02b8baa9e9ee27defde2c6d2f186
Agama-weblate commit: f986d72e1d4c02b8baa9e9ee27defde2c6d2f186
…#1717) ## Problems 1. The "Install" button is shown during the installation progress :disappointed_relieved: Thanks @imobachgs! 2. The install confirmation dialog could be accepted by mistake because of 'Continue' button receiving the focus by default https://trello.com/c/8ZWINXjs (internal/private link) ## Solutions 1. Do not show the "Install" button when it does not make sense 2. Set 'Cancel' button as focused by default via [autofocus](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/autofocus) attribute (a.k.a. `autoFocus` prop) ## Testing - New behavior covered by unit tests. ## Notes Constants for router paths were moved to a single _routes/paths_ file in order to avoid circular dependencies that made test suite fail after agama-project@fe18300
sles_enhanced_base pattern was removed from SLES 16 and replaced by base pattern ## Problem sles_enhanced_base pattern was removed from SLES 16 - [bsc#1232618](https://bugzilla.suse.com/show_bug.cgi?id=1232618) ## Solution Replace sles_enhanced_base pattern with base pattern ## Testing - NA ## Screenshots NA
Updating the web translation files from the agama-weblate repository
Updating the product translations from the agama-weblate repository
## Problem The "Installation Finished" page is not shown when the installation finishes. It seems to be related to latest changes regarding the application layout. Now, the `App` component is not always on top. ## Solution Listen for status changes in the installation progress page. ## Testing - Tested manually
Updating the service translation files from the agama-weblate repository
…gama-project#1767) ## Problem When a drive was configured with an empty search for partitions like this (in which there is no configuration about deleting or resizing the found partitions)... ```json { "storage": { "drives": [ { "partitions": [ { "search": "*" }, { "filesystem": { "path": "/" } } ] } ] } } ``` ...all the matched pre-existing partitions are considered as candidates to be shrunk. ## Solution With this fix, partitions with no actions do not generate any SpaceMaker action. ## Bonus `AgamaProposal` now returns an exception of type `Y2Storage::NoDiskSpaceError` when the SpaceMaker fails to find space. That was the documented behavior, but a generic `Y2Storage::Error` was returned instead. ## Testing - Added a new unit test - Tested manually
Co-authored-by: Imobach González Sosa <[email protected]>
…ject#1764) ## Problem Missing SLES for SAP Application product in SLE based products ## Solution Add SLES for SAP Application product to SLE based products NOTE: temporally the SLES for SAP Application description is the same as SLES, a new PR will be submitted with the final text agreed with PM ## Testing - *Tested manually*
## Problem - https://trello.com/c/5PjJQ2Vq There are various issues detected when working on this PBI: 1. The authentication method is not selected properly 2. The form reports that auhentication failed when it is already connected. 3. Some times the labels and buttons for the selected wifi does not correspond whith the current state. 4. After a sync with master branch the backend started failing when reading wireless connections ## Solution We have fixes some of the issues but the handle of state is quite fragile and coupled to the websockets notification in the frontend and the UI therefore we plan to do some changes in the UI (Drawer and selection of the WiFi) as well as in the backend trying to store the authentication state there being able to request the state from the backend without lostling any information in case of not subscribed to changes. About the fixes in particular: 1. The authentication method is recognized again (removed method probably by error). 2. In case that a wireless device is activated the needAuth is also removed from the cached queries 3. To be better handled. 4. Get some of the wireless settings as optional (band, channel, bssid, hidden, pmf) ... ## Testing - Tested manually
…roject#1769) ## Context Back in the time, It was internally proposed to have a different layout for easily distinguish between screens that allow users to fine tuning the installation of the selected product from the rest of screens. The idea was to easily give the user a sense of _different context_ in order to avoid mixing the product selection or installer settings with the configuration of installation itself. A good idea, to be honest. When the Agama UI was completely changed to a more PatternFly layout, we tried make it a reality by applying below changes when user visiting a route out of the _installation settings scope_ * No topbar title (probably a mistake) * No topbar actions (a mistake) * Using same background for topbar and main content in an attempt of creating the illusion there is no topbar at all * Using neither, _footbar_ nor sidebar. Although not perfect, the above allowed to create such a _visually context change_ Quickly, we realize we needed the topbar actions in these layout too to allow users _Download the logs_ (along other _global actions_) from the same place across all Agama screens. ## Problem Not a problem at all, but perhaps a minor inconsistency: while the permanent sticky footer was completely dropped, Agama still keeps the main actions fixed at the bottom of viewport when users are selecting from a long list within the _installation settings scope_. E.G., when selecting a keyboard layout, a language, or even software patterns. In contrast, this behavior changes when selecting a product, where the "Accept" and "Cancel" actions might fall out of the viewport depending on several factors like screen size, resolution, orientation, or zoom level to name a few. This isn’t a major issue, as we’re using a simple, well-structured HTML form that users around the world are familiar with: a list of options presented as a radio button group that supports keyboard navigation, including submitting the selected option by pressing "Enter." That said, maintaining consistency with the rest of the UI by keeping the form actions always visible at the bottom of the viewport wouldn’t hurt (or at least it shouldn’t). Still, this approach is far from ideal when it comes to truly helping users complete the task at hand. Additionally, I’m concerned it might lead to yet another scroll complaint (more on this in an upcoming discussion). ## Solution Force product selection form actions to be stick at the bottom of viewport. ## Testing - Tested manually --- Related to https://trello.com/c/ZdOMjg3r (internal link)
Agama-weblate commit: bf9047c81ed24cc07122ea2d33a4893242c8b62d
Agama-weblate commit: bf9047c81ed24cc07122ea2d33a4893242c8b62d
Updating the web translation files from the agama-weblate repository
Updating the service translation files from the agama-weblate repository
) ## Problem The OpenAPI specification does not describe the common HTTP APIs (e.g., The specification of the common (shared) HTTP APIs the OpenAPI description. ## Solution Add the description of *issues*, *service status* and *progress* HTTP APIs. Unless there are more omissions, it should close agama-project#1700. ## Testing - *Tested manually*
## Problem - The Agama autoinstallation and CLI accept the first user and the root passwords only in plain text - That's insecure, everybody who can access the installation profile knows the root password ## Solution - Support passing an already encrypted (hashed) password in the profile - Similar to AutoYaST, an additional `encryptedPassword` boolean flag is used to determine whether the specified password is encrypted (`true` value) or plain text (`false` value or missing in the profile) ## Notes - The web UI allows specifying only plain text passwords - Encrypted passwords are long and hard to type and they need to be encrypted externally ## Features - Adapted schema definition - Adapted the AutoYaST conversion tool - When an encrypted password is set from Agama CLI then web UI resets the flag back to plain text (it supports only plain text passwords) ## Testing - Tested manually (both root user and first user), tested the AutoYaST profile conversion - Updated unit tests --------- Co-authored-by: Imobach González Sosa <[email protected]>
Fix the default path of the `Questions` D-Bus object and the `ISCSI.Initiator` interface.
joseivanlopez
merged commit 7d2d581
into
agama-project:storage-config-ui
4 of 5 checks passed
Merged
imobachgs
added a commit
that referenced
this pull request
Jan 13, 2025
Update to release version 11. * #1495 * #1564 * #1617 * #1618 * #1625 * #1626 * #1627 * #1628 * #1630 * #1631 * #1632 * #1633 * #1634 * #1635 * #1636 * #1639 * #1640 * #1641 * #1642 * #1643 * #1644 * #1645 * #1646 * #1647 * #1648 * #1649 * #1650 * #1651 * #1652 * #1654 * #1655 * #1656 * #1657 * #1660 * #1663 * #1666 * #1667 * #1668 * #1670 * #1671 * #1673 * #1674 * #1675 * #1676 * #1677 * #1681 * #1682 * #1683 * #1684 * #1687 * #1688 * #1689 * #1690 * #1691 * #1692 * #1693 * #1694 * #1695 * #1696 * #1698 * #1699 * #1702 * #1703 * #1704 * #1705 * #1707 * #1708 * #1709 * #1710 * #1711 * #1712 * #1713 * #1714 * #1715 * #1716 * #1717 * #1718 * #1720 * #1721 * #1722 * #1723 * #1727 * #1728 * #1729 * #1731 * #1732 * #1733 * #1734 * #1735 * #1736 * #1737 * #1740 * #1741 * #1743 * #1744 * #1745 * #1746 * #1751 * #1753 * #1754 * #1755 * #1757 * #1762 * #1763 * #1764 * #1765 * #1766 * #1767 * #1769 * #1771 * #1772 * #1773 * #1774 * #1777 * #1778 * #1785 * #1786 * #1787 * #1788 * #1789 * #1790 * #1791 * #1792 * #1793 * #1794 * #1795 * #1796 * #1797 * #1798 * #1799 * #1800 * #1802 * #1803 * #1804 * #1805 * #1807 * #1808 * #1809 * #1810 * #1811 * #1812 * #1814 * #1815 * #1821 * #1822 * #1823 * #1824 * #1825 * #1826 * #1827 * #1828 * #1830 * #1831 * #1832 * #1833 * #1834 * #1835 * #1836 * #1837 * #1838 * #1839 * #1840 * #1841 * #1842 * #1843 * #1844 * #1845 * #1847 * #1848 * #1849 * #1850 * #1851 * #1854 * #1855 * #1856 * #1857 * #1860 * #1861 * #1863 * #1864 * #1865 * #1866 * #1867 * #1871 * #1872 * #1873 * #1875 * #1876 * #1877 * #1878 * #1880 * #1881 * #1882 * #1883 * #1884 * #1885 * #1886 * #1888 * #1889 * #1890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge master into the feature branch and fix issue with storage overview.