Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fixes to UI #1712

Merged

Conversation

ancorgs
Copy link
Contributor

@ancorgs ancorgs commented Oct 29, 2024

Now that we don't have a Proposal object exported at the API, this should prevent the UI from crashing right away.

Temporarily the storage page looks like this:

storage

@ancorgs ancorgs force-pushed the storage-config-ui-show-result branch from 89660a1 to 20dae0b Compare October 29, 2024 16:11
@ancorgs ancorgs force-pushed the storage-config-ui-show-result branch from 20dae0b to 0d418d8 Compare October 30, 2024 08:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11589529728

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 71.574%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-server/src/storage/web.rs 0 1 0.0%
rust/agama-lib/src/storage/client.rs 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
rust/agama-lib/src/storage/client.rs 1 0.0%
Totals Coverage Status
Change from base Build 11557776614: -0.01%
Covered Lines: 17031
Relevant Lines: 23795

💛 - Coveralls

@ancorgs ancorgs marked this pull request as ready for review October 30, 2024 09:03
@ancorgs
Copy link
Contributor Author

ancorgs commented Oct 30, 2024

We agreed to merge this to the feature/playground branch even with some broken tests. Anyways, the branch will be heavily polished before even considering merge to master.

@@ -69,6 +70,11 @@ impl<'a> StorageClient<'a> {
.cache_properties(zbus::CacheProperties::No)
.build()
.await?,
// Same than above, actions are reexported with every call to recalculate
devices_proxy: DevicesProxy::builder(&connection)
.cache_properties(zbus::CacheProperties::No)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Storage1.Devices interface is not reexported. This should be similar to the storage_proxy and calculator_proxy. I would say caching it is ok here. Anyway, it is not that important because we are caching at client level.

Copy link
Contributor

@joseivanlopez joseivanlopez Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point I would like to reevalute the Devices interface. I think it would be better to add a new method Storage1#devices instead of having a separate interface. That method would report a JSON according to a schema, for example:

{
  system: {},
  target: {},
  actions: {}
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Definitely all the proxies need to be reconsidered... afterwards.

@ancorgs ancorgs merged commit 53fe9b5 into agama-project:storage-config-ui Oct 30, 2024
1 of 2 checks passed
@imobachgs imobachgs mentioned this pull request Jan 10, 2025
imobachgs added a commit that referenced this pull request Jan 13, 2025
Update to release version 11.

* #1495
* #1564
* #1617
* #1618
* #1625
* #1626
* #1627
* #1628
* #1630
* #1631
* #1632
* #1633
* #1634
* #1635
* #1636
* #1639
* #1640
* #1641
* #1642
* #1643
* #1644
* #1645
* #1646
* #1647
* #1648
* #1649
* #1650
* #1651
* #1652
* #1654
* #1655
* #1656
* #1657
* #1660
* #1663
* #1666
* #1667
* #1668
* #1670
* #1671
* #1673
* #1674
* #1675
* #1676
* #1677
* #1681
* #1682
* #1683
* #1684
* #1687
* #1688
* #1689
* #1690
* #1691
* #1692
* #1693
* #1694
* #1695
* #1696
* #1698
* #1699
* #1702
* #1703
* #1704
* #1705
* #1707
* #1708
* #1709
* #1710
* #1711
* #1712
* #1713
* #1714
* #1715
* #1716
* #1717
* #1718
* #1720
* #1721
* #1722
* #1723
* #1727
* #1728
* #1729
* #1731
* #1732
* #1733
* #1734
* #1735
* #1736
* #1737
* #1740
* #1741
* #1743
* #1744
* #1745
* #1746
* #1751
* #1753
* #1754
* #1755
* #1757
* #1762
* #1763
* #1764
* #1765
* #1766
* #1767
* #1769
* #1771
* #1772
* #1773
* #1774
* #1777
* #1778
* #1785
* #1786
* #1787
* #1788
* #1789
* #1790
* #1791
* #1792
* #1793
* #1794
* #1795
* #1796
* #1797
* #1798
* #1799
* #1800
* #1802
* #1803
* #1804
* #1805
* #1807
* #1808
* #1809
* #1810
* #1811
* #1812
* #1814
* #1815
* #1821
* #1822
* #1823
* #1824
* #1825
* #1826
* #1827
* #1828
* #1830
* #1831
* #1832
* #1833
* #1834
* #1835
* #1836
* #1837
* #1838
* #1839
* #1840
* #1841
* #1842
* #1843
* #1844
* #1845
* #1847
* #1848
* #1849
* #1850
* #1851
* #1854
* #1855
* #1856
* #1857
* #1860
* #1861
* #1863
* #1864
* #1865
* #1866
* #1867
* #1871
* #1872
* #1873
* #1875
* #1876
* #1877
* #1878
* #1880
* #1881
* #1882
* #1883
* #1884
* #1885
* #1886
* #1888
* #1889
* #1890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants