Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translate storage component when UI language changes #1644

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

imobachgs
Copy link
Contributor

Problem

Some parts of the UI are not properly translated when the language of the UI changes (see #1629).

Solution

This is a fix for storage components which consist on not calling _ at module level.

Testing

  • Tested manually

Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit e7a8f50 into master Sep 27, 2024
2 checks passed
@imobachgs imobachgs deleted the fix-ui-i18n branch September 27, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants