AgamaProposal: fix bug when partitions are searched but not managed #1767
+59
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a drive was configured with an empty search for partitions like this (in which there is no configuration about deleting or resizing the found partitions)...
...all the matched pre-existing partitions are considered as candidates to be shrunk.
Solution
With this fix, partitions with no actions do not generate any SpaceMaker action.
Bonus
AgamaProposal
now returns an exception of typeY2Storage::NoDiskSpaceError
when the SpaceMaker fails to find space. That was the documented behavior, but a genericY2Storage::Error
was returned instead.Testing