Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] improvements in agama logs store #1762

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

mchf
Copy link
Contributor

@mchf mchf commented Nov 14, 2024

Problem

  • some information were missed in the result

Solution

  • added journal output for (new) agama-web-server
  • collected package versions (either .packages.root or "rpm -qa")
  • minor improvements - do not include empty files (when command produces no output) into the resulting archive; do not mask errors reported by the backend (either authentication required)
  • WIP: collect d-bus logs

Testing

  • Tested manually

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11834112851

Details

  • 0 of 21 (0.0%) changed or added relevant lines in 3 files are covered.
  • 567 unchanged lines in 27 files lost coverage.
  • Overall coverage increased (+0.07%) to 71.395%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rust/agama-cli/src/logs.rs 0 1 0.0%
rust/agama-lib/src/base_http_client.rs 0 6 0.0%
rust/agama-lib/src/logs.rs 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
rust/agama-lib/src/base_http_client.rs 1 53.85%
rust/agama-lib/src/network/settings.rs 2 62.5%
rust/agama-lib/src/storage/settings.rs 2 0.0%
rust/agama-lib/src/lib.rs 5 31.25%
rust/agama-lib/src/scripts/model.rs 5 86.11%
rust/agama-server/src/web/docs/l10n.rs 6 0.0%
rust/agama-server/src/web/docs/manager.rs 6 0.0%
rust/agama-server/src/web/docs/misc.rs 6 0.0%
rust/agama-server/src/web/docs/questions.rs 6 0.0%
rust/agama-server/src/web/docs/software.rs 6 0.0%
Totals Coverage Status
Change from base Build 11831842629: 0.07%
Covered Lines: 16895
Relevant Lines: 23664

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants