-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use AgamaProposal for the initial storage proposal #1699
Merged
ancorgs
merged 16 commits into
agama-project:storage-config-ui
from
ancorgs:probe_agama_proposal
Oct 28, 2024
Merged
Use AgamaProposal for the initial storage proposal #1699
ancorgs
merged 16 commits into
agama-project:storage-config-ui
from
ancorgs:probe_agama_proposal
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: José Iván López <[email protected]>
…gama-project#1696) ## Problem At the storage configuration, it's possible to specify a section describing a device (drive, partition, volume group, logical volume, etc.) with a `search` entry to indicate such a description corresponds to one or several previously existing device(s) that should be found in the system. That `search` entry can contain `ifNotFound: "skip"` to indicate the description should be ignored if the corresponding devices are not found. If that happens, a warning is added to the list of found issues with a message like "_No device found for an optional drive/partition/whatever_". That warning looks overkill. Especially having into account the default value for `ifNotFound` is "error", which means profiles using "skip" really mean it. ## Solution Reduce the noise by not longer generating the issue for missing optional devices.
## Problem The *scripts* section is misplaced in the profile schema (inside *storage* section) ## Solution Place *scripts* section at first level.
ancorgs
force-pushed
the
probe_agama_proposal
branch
from
October 25, 2024 14:49
d139a2b
to
14f4d79
Compare
Pull Request Test Coverage Report for Build 11557338726Details
💛 - Coveralls |
ancorgs
force-pushed
the
probe_agama_proposal
branch
from
October 25, 2024 15:10
14f4d79
to
8694e5f
Compare
## Problem See agama-project#1701. The CLI uses a PUT instead of a POST when applying the network configuration. ## Solution Use the correct HTTP verb when applying the network configuration. ## Testing - Tested manually
The products definition package could not be submitted due to a problem in a date format.
ancorgs
force-pushed
the
probe_agama_proposal
branch
from
October 28, 2024 11:38
8694e5f
to
6ee1a8b
Compare
ancorgs
changed the title
WIP: Use AgamaProposal for the initial storage proposal
Use AgamaProposal for the initial storage proposal
Oct 28, 2024
ancorgs
force-pushed
the
probe_agama_proposal
branch
from
October 28, 2024 11:50
6ee1a8b
to
12049b5
Compare
joseivanlopez
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add a changelog entry.
## Problem The checks at GitHub were failing for new pull requests because it was not possible to install ruby-augeas 0.5.0 at the containers. Apparently that was triggered by a recent update of the version of the package at openSUSE Tumbleweed (it moved to 0.6.0). ## Solution This updates `Gemfile.lock` to use the same version that is now available on Tumbleweed. Apparently that fixes CI for the new pull requests.
ancorgs
force-pushed
the
probe_agama_proposal
branch
from
October 28, 2024 15:32
2d59206
to
18c8139
Compare
joseivanlopez
approved these changes
Oct 28, 2024
Merged
imobachgs
added a commit
that referenced
this pull request
Jan 13, 2025
Update to release version 11. * #1495 * #1564 * #1617 * #1618 * #1625 * #1626 * #1627 * #1628 * #1630 * #1631 * #1632 * #1633 * #1634 * #1635 * #1636 * #1639 * #1640 * #1641 * #1642 * #1643 * #1644 * #1645 * #1646 * #1647 * #1648 * #1649 * #1650 * #1651 * #1652 * #1654 * #1655 * #1656 * #1657 * #1660 * #1663 * #1666 * #1667 * #1668 * #1670 * #1671 * #1673 * #1674 * #1675 * #1676 * #1677 * #1681 * #1682 * #1683 * #1684 * #1687 * #1688 * #1689 * #1690 * #1691 * #1692 * #1693 * #1694 * #1695 * #1696 * #1698 * #1699 * #1702 * #1703 * #1704 * #1705 * #1707 * #1708 * #1709 * #1710 * #1711 * #1712 * #1713 * #1714 * #1715 * #1716 * #1717 * #1718 * #1720 * #1721 * #1722 * #1723 * #1727 * #1728 * #1729 * #1731 * #1732 * #1733 * #1734 * #1735 * #1736 * #1737 * #1740 * #1741 * #1743 * #1744 * #1745 * #1746 * #1751 * #1753 * #1754 * #1755 * #1757 * #1762 * #1763 * #1764 * #1765 * #1766 * #1767 * #1769 * #1771 * #1772 * #1773 * #1774 * #1777 * #1778 * #1785 * #1786 * #1787 * #1788 * #1789 * #1790 * #1791 * #1792 * #1793 * #1794 * #1795 * #1796 * #1797 * #1798 * #1799 * #1800 * #1802 * #1803 * #1804 * #1805 * #1807 * #1808 * #1809 * #1810 * #1811 * #1812 * #1814 * #1815 * #1821 * #1822 * #1823 * #1824 * #1825 * #1826 * #1827 * #1828 * #1830 * #1831 * #1832 * #1833 * #1834 * #1835 * #1836 * #1837 * #1838 * #1839 * #1840 * #1841 * #1842 * #1843 * #1844 * #1845 * #1847 * #1848 * #1849 * #1850 * #1851 * #1854 * #1855 * #1856 * #1857 * #1860 * #1861 * #1863 * #1864 * #1865 * #1866 * #1867 * #1871 * #1872 * #1873 * #1875 * #1876 * #1877 * #1878 * #1880 * #1881 * #1882 * #1883 * #1884 * #1885 * #1886 * #1888 * #1889 * #1890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to stop relying on the YaST proposal and always use the new so-called
AgamaProposal
both for the auto-installation and for the interactive one.This makes that change effective by generating an initial storage configuration that fulfills the product settings and executing
AgamaProposal
for it during the storage probing phase.Bonus
This includes a merge of
master
into the feature branch. To keep things in sync and, even more important, to get some fixes from there.