fix: properly handle installer language changes #1746
Conversation
|
According to the PR's description, looks to me you're working on https://trello.com/c/isE3194l/620-agama-translations-not-working-consitently too. Please, have a look. Thanks for addressing these translation issues. |
imobachgs
force-pushed
the
bsc-1233160
branch
from
c98259a
to
4145587
Compare
| @@ -20,7 +20,8 @@ | |||
| //! [D-Bus standard interfaces]: https://dbus.freedesktop.org/doc/dbus-specification.html#standard-interfaces, | |||
| use zbus::proxy; | |||
| #[proxy( | |||
| default_service = "org.opensuse.Agama1", | |||
| default_service = "org.opensuse.Agama.Manager1", | |||
| default_path = "/org/opensuse/Agama/Manager1", | |||
There was a problem hiding this comment.
Good catch... except it does not work: 🤣 😢
When I run this code and change the UI langue in the browser, journalctl has:
Nov 12 13:10:23 c75fbede8655 agama-web-server[28278]: Sending message: Msg { type: MethodCall, serial: 157, sender: UniqueName(":1.7"), path: ObjectPath("/org/freedesktop/Locale"), iface: InterfaceName("org.freedesktop.DBus.Properties"), member: MemberName("Set"), body: Structure(Dynamic { fields: [Str, Str, Variant] }), fds: [] }
...
Nov 12 13:10:23 c75fbede8655 agama-web-server[28278]: 5:185m5:185mCould not synchronize settings in the localization D-Bus service: D-Bus service error: org.freedesktop.DBus.Error.UnknownObject: Unknown object '/org/freedesktop/Locale'
Looking up "Could not synchronize settings" in the source, I arrive at a update_dbus fn, which uses a set_locales fn, defined in...
Which is a similar, yet different file from this diff
🤷
There was a problem hiding this comment.
Well, it works for me (TM) 😉 Actually, I would not expect the set_locales method to be involved because that's responsible for changing the locales to install, not the installer's language. Are you changing the language through the "Installer Options" menu? Did you restart the agama-dbus-server process too (restarting the agama.service should be enough)?
Having two interfaces with the same name (org.opensuse.Agama1.Locale) is unfortunate, I know, but they are different things:
- localization/proxies refers to the Locale API (implemented in
agama-dbus-server). We kept a D-Bus interface because it was needed for internal communication. But the idea is to get rid of it and rely only on HTTP. - proxies/locale refers to an interface that is implemented by all Ruby-based services which allows to change the language.
I wonder if we should add default_path = "/org/opensuse/Agama1/Locale", to the 1st proxy, but in my testing system it seems to work (unless I am missing something).
In any case, I will build an image that includes all the changes so we can perform more tests.
There was a problem hiding this comment.
I have fixed both proxies and now I see no error in the logs.
There was a problem hiding this comment.
Having two interfaces with the same name (org.opensuse.Agama1.Locale) is unfortunate, I know, but they are different things:
It's not unfortunate, it is wrong 😄 but it happens to work now. I hope I can add a simple fix, otherwise postpone it for another PR
There was a problem hiding this comment.
Yes, it is wrong 😅 The point is that we plan to drop one of them, so it won't be duplicated anymore.
imobachgs
changed the title
Pull Request Test Coverage Report for Build 11825620593Details
💛 - Coveralls |
it has only a SetLocale method, used as a mixin, to localize the output of various components, but it collided with org.opensuse.Agama1.Locale which is the main locale config for the system
Problem
Problems:
pt-BR).es_ARdoes not fallback toes_ES, it uses English instead #860Solution
Fix the D-Bus path of the LocaleProxy to the Manager's
org.opensuse.Agama1.Localeinterface.Testing